[SciPy-Dev] PR for overlap-add convolution

[Eric Larson]

Agreed. Or you can use the `monkeypatch` pytest fixture, monkeypatching (in
the given test) `scipy.signal.fftconvolve` to be a one-liner than throws an
error.

Eric


On Fri, Sep 27, 2019 at 2:17 AM Nathaniel Smith <njs at pobox.com> wrote:

> On Thu, Sep 26, 2019 at 8:56 PM Todd <toddrjen at gmail.com> wrote:
> > To be clear, the situations where it falls back on fftconvolve are the
> situations where oaconvolve reduces to fftconvolve.
>
> I definitely wouldn't expose any argument to let users control this then.
>
> You could have an internal function that has that argument, write the
> fine-grained tests against that internal function, and then have a
> public wrapper that just calls the internal function.
>
> -n
>
> --
> Nathaniel J. Smith -- https://vorpus.org
> _______________________________________________
> SciPy-Dev mailing list
> SciPy-Dev at python.org
> https://mail.python.org/mailman/listinfo/scipy-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/scipy-dev/attachments/20190927/6a76bcf9/attachment.html>