<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small">Submitted :)<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Apr 12, 2021 at 1:40 PM Ralf Gommers <<a href="mailto:ralf.gommers@gmail.com">ralf.gommers@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Apr 12, 2021 at 5:00 AM Tirth Patel <<a href="mailto:tirthasheshpatel@gmail.com" target="_blank">tirthasheshpatel@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-family:verdana,sans-serif;font-size:small">Hi Ralf,</div><div style="font-family:verdana,sans-serif;font-size:small"><br></div><div style="font-family:verdana,sans-serif;font-size:small">Thanks a lot for taking a look and for the positive feedback! I have tried to address your comments on the doc. Feel free to check them or ask for more changes.<br></div></div></blockquote><div><br></div><div>Looks good. I suggest submitting it, since the deadline is tomorrow - don't leave it till the last minute:)<br></div><div><br></div><div>Cheers,<br></div><div>Ralf</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div style="font-family:verdana,sans-serif;font-size:small"></div><div style="font-family:verdana,sans-serif;font-size:small"><br></div><div style="font-family:verdana,sans-serif;font-size:small"><br clear="all"></div><div><div dir="ltr"><div dir="ltr"><div>Kind Regards,</div><div>Tirth Patel</div></div></div></div><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Apr 11, 2021 at 10:33 PM Ralf Gommers <<a href="mailto:ralf.gommers@gmail.com" target="_blank">ralf.gommers@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Apr 11, 2021 at 10:46 AM Tirth Patel <<a href="mailto:tirthasheshpatel@gmail.com" target="_blank">tirthasheshpatel@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div><div dir="ltr"><div style="font-family:verdana,sans-serif;font-size:small">Hi everyone,</div><div style="font-family:verdana,sans-serif;font-size:small"><br></div><div style="font-family:verdana,sans-serif;font-size:small">I have been working on a draft proposal lately and think it is almost ready. Please feel free to add suggestions/comments, if any.</div><div style="font-family:verdana,sans-serif;font-size:small"><br></div><div style="font-family:verdana,sans-serif;font-size:small">Proposal: <a href="https://docs.google.com/document/d/1xvRdpNVseTL8d7eWdiyY6rcNxBVKCXt81xE9HyXvtqE/edit?usp=sharing" rel="noreferrer" target="_blank">https://docs.google.com/document/d/1xvRdpNVseTL8d7eWdiyY6rcNxBVKCXt81xE9HyXvtqE/edit?usp=sharing</a></div></div></div></div></blockquote><div><br></div><div>Hi Tirth, this is a very well-written proposal. I added one comment in your GDoc about keeping some time for discussing the API with the community and if needed iterating on it. Your proposal seems good to submit though, it has enough detail and the plan and milestones look good.</div><div><br></div><div>Cheers,<br></div><div>Ralf</div><div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="auto"><div><div dir="ltr"><div style="font-family:verdana,sans-serif;font-size:small" dir="auto"><br></div><div style="font-family:verdana,sans-serif;font-size:small" dir="auto"><br></div><div style="font-family:verdana,sans-serif;font-size:small" dir="auto">Kind regards,</div><div style="font-family:verdana,sans-serif;font-size:small" dir="auto">Tirth Patel</div><br></div><br><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Apr 2, 2021 at 7:19 PM Tirth Patel <<a href="mailto:tirthasheshpatel@gmail.com" rel="noreferrer" target="_blank">tirthasheshpatel@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi all,<br>
<br>
I would like to participate in GSoC this year and found this project<br>
very interesting!<br>
<br>
TL; DR: I have a few questions regarding the project:<br>
- Is the user interface desired as a separate python submodule<br>
(inside `scipy.stats`) or does it serve as an extension of the `rvs`<br>
method?<br>
- Should UNU.RAN C library be included as a submodule within SciPy<br>
(e.g. gh-12043) or be cloned from a separate GitHub submodule (e.g<br>
gh-13328)?<br>
<br>
About Me<br>
********<br>
I am Tirth (@tirthasheshpatel on GitHub), a third-year computer<br>
science undergrad student. I am quite familiar with Cython and a lot<br>
of my college courses make use of C. I have a good knowledge of<br>
probability theory and statistics.<br>
<br>
Open Source work: I have participated in GSoC with the PyMC team last<br>
year. I am a contributor to SciPy since May 2020 and recently a<br>
maintainer.<br>
<br>
About Project<br>
*************<br>
I had a question about the project. Is the user interface desired as a<br>
separate python submodule inside `scipy.stats`? like:<br>
<br>
import scipy.stats as stats<br>
<br>
# sample a 1000 variates from a normal distribution<br>
# with mean 0 and std 1.5. Let UNU.RAN choose the method<br>
rvs = stats.random.normal(0., 1.5, size=1000, method='auto')<br>
<br>
# sample 100 samples from the beta distribution using TDR method<br>
beta_rvs = stats.random.beta(1, 2, size=100, method='tdr')<br>
<br>
# the `rvs` methods remains unaffected.<br>
norm_rvs = stats.norm.rvs(0, 1.5, size=1000)<br>
<br>
Or does it serve as an extension of the `rvs` method:<br>
<br>
from scipy.stats import norm, beta<br>
<br>
# something like this:<br>
# method = None => same behaviour as previous versions<br>
# method = 'auto' => use UNU.RAN and let it choose the method<br>
rvs = norm.rvs(0, 1.5, size=1000, method='auto')<br>
<br>
beta_rvs = beta.rvs(1, 2, size=100, method='tdr')<br>
<br>
Also, should UNU.RAN C library be included as a submodule within SciPy<br>
(e.g. gh-12043) or be cloned from a separate GitHub submodule (e.g<br>
gh-13328)?<br>
<br>
<br>
--<br>
Kind Regards,<br>
Tirth<br>
</blockquote></div>
</div></div>
_______________________________________________<br>
SciPy-Dev mailing list<br>
<a href="mailto:SciPy-Dev@python.org" target="_blank">SciPy-Dev@python.org</a><br>
<a href="https://mail.python.org/mailman/listinfo/scipy-dev" rel="noreferrer" target="_blank">https://mail.python.org/mailman/listinfo/scipy-dev</a><br>
</blockquote></div></div>
_______________________________________________<br>
SciPy-Dev mailing list<br>
<a href="mailto:SciPy-Dev@python.org" target="_blank">SciPy-Dev@python.org</a><br>
<a href="https://mail.python.org/mailman/listinfo/scipy-dev" rel="noreferrer" target="_blank">https://mail.python.org/mailman/listinfo/scipy-dev</a><br>
</blockquote></div>
_______________________________________________<br>
SciPy-Dev mailing list<br>
<a href="mailto:SciPy-Dev@python.org" target="_blank">SciPy-Dev@python.org</a><br>
<a href="https://mail.python.org/mailman/listinfo/scipy-dev" rel="noreferrer" target="_blank">https://mail.python.org/mailman/listinfo/scipy-dev</a><br>
</blockquote></div></div>
_______________________________________________<br>
SciPy-Dev mailing list<br>
<a href="mailto:SciPy-Dev@python.org" target="_blank">SciPy-Dev@python.org</a><br>
<a href="https://mail.python.org/mailman/listinfo/scipy-dev" rel="noreferrer" target="_blank">https://mail.python.org/mailman/listinfo/scipy-dev</a><br></blockquote><div><br></div><div style="font-family:verdana,sans-serif;font-size:small" class="gmail_default"><div><span class="gmail_default" style="font-family:verdana,sans-serif;font-size:small"></span>Kind Regards,</div><div>Tirth Patel</div></div></div></div>