<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Hi,
<div><br>
</div>
<div>Following up on this. It was determined that gh-14256 contains too much</div>
<div>content for a single PR. I've closed that PR and am now breaking it up</div>
<div>into several smaller PRs. I've submitted gh-14287 which contains only</div>
<div>the tests from gh-14256 and the script in scipy.special._precompute that</div>
<div>I'm using to generate test cases with mpmath. I've made what I think are</div>
<div>improvements to the tests since closing the previous PR. The line count</div>
<div>in this PR is also large, but many of the lines are taken up by test</div>
<div>cases. I've made the tests self-validating, so that the reviewers will</div>
<div>not need to validate that each of the many test-cases test what is</div>
<div>claimed. This new PR does not contain specialized numerical mathematics</div>
<div>and would be accessible to a wider class of reviewers than the previous</div>
<div>PR.</div>
<div><br>
</div>
<div>Feel free to join the discussion in gh-14256.</div>
<div><br>
</div>
<div>Thanks,</div>
Albert<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> SciPy-Dev <scipy-dev-bounces+albert_steppi=hms.harvard.edu@python.org> on behalf of Ralf Gommers <ralf.gommers@gmail.com><br>
<b>Sent:</b> Sunday, June 20, 2021 8:36 AM<br>
<b>To:</b> SciPy Developers List <scipy-dev@python.org><br>
<b>Subject:</b> Re: [SciPy-Dev] Proposal to translate hyp2f1 for complex numbers into Cython</font>
<div> </div>
</div>
<div>
<div dir="ltr">
<div dir="ltr"><br>
</div>
<br>
<div class="x_gmail_quote">
<div dir="ltr" class="x_gmail_attr">On Sun, Jun 20, 2021 at 5:06 AM Steppi, Albert <<a href="mailto:Albert_Steppi@hms.harvard.edu">Albert_Steppi@hms.harvard.edu</a>> wrote:<br>
</div>
<blockquote class="x_gmail_quote" style="margin:0px 0px 0px 0.8ex; border-left:1px solid rgb(204,204,204); padding-left:1ex">
<div dir="ltr">
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
Hi everyone,
<div><br>
</div>
<div>I've submitted the PR gh-14256, which is a beginning towards moving the</div>
<div>implementation of Gauss's hypergeometric function hyp2f1 for complex numbers</div>
<div>from Fortran into Cython. Josh Wilson mentioned at</div>
<div><br>
</div>
<div><a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_scipy_scipy_pull_8151-23issuecomment-2D845227864&d=DwMFaQ&c=WO-RGvefibhHBZq3fL85hQ&r=6G-pYXDrRNN7Q79BwRHXuvnsUFnhjXBhWoUaZsjutXQ&m=HtKJE76TYmrXzjM4DJ4G0Axt6WsYfb0g1pKaQ2FfOYs&s=3v6PThX-Bs4OSsxmYL2fJcECuU1krGRSLuF1h9QGQ6k&e=" target="_blank">https://github.com/scipy/scipy/pull/8151#issuecomment-845227864</a></div>
<div><br>
</div>
<div>that this would be appreciated, and I'd like to work on this little by little in</div>
<div>my spare time. The current Fortran implementation has several outstanding</div>
<div>issues gh-4894, gh-7340, gh-8054, and gh-8083. Pull requests gh-8110 and</div>
<div>gh-8151 were submitted by GitHub user FormerPhysicist to fix some of the</div>
<div>outstanding issues but these have languished for almost four years now due to a</div>
<div>lack of reviewers conversant in both numerical computation of special functions</div>
<div>and Fortran 77. This PR has a fix for gh-7430. I intend to address other</div>
<div>defects in the implementation of hyp2f1 in future PRs. Please see my opening</div>
<div>comment in gh-14256 for more information on the contents of this PR and plans</div>
<div>for the future.</div>
</div>
</div>
</blockquote>
<div><br>
</div>
<div>This sounds great. hyp2f1 has given us headaches for a long time. Thanks for working on this Albert!</div>
<div><br>
</div>
<div>Cheers,<br>
</div>
<div>Ralf</div>
<div><br>
</div>
<blockquote class="x_gmail_quote" style="margin:0px 0px 0px 0.8ex; border-left:1px solid rgb(204,204,204); padding-left:1ex">
<div dir="ltr">
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<div><br>
</div>
<div>Feel free to join the discussion of this update in gh-14256!</div>
<div><br>
</div>
<div><br>
</div>
<div>Thanks,</div>
Albert<br>
</div>
<div>
<div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:12pt; color:rgb(0,0,0)">
<br>
</div>
<div id="x_gmail-m_-5962867075652257423Signature">
<div>
<div></div>
<div></div>
<div id="x_gmail-m_-5962867075652257423divtagdefaultwrapper" dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif">
Albert Steppi III, PhD</div>
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif">
Scientific Software Developer</div>
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif">
Laboratory of Systems Pharmacology</div>
<div dir="ltr" style="font-size:12pt; color:rgb(0,0,0); font-family:Calibri,Helvetica,sans-serif">
Harvard Medical School<br>
</div>
</div>
</div>
</div>
</div>
_______________________________________________<br>
SciPy-Dev mailing list<br>
<a href="mailto:SciPy-Dev@python.org" target="_blank">SciPy-Dev@python.org</a><br>
<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__mail.python.org_mailman_listinfo_scipy-2Ddev&d=DwMFaQ&c=WO-RGvefibhHBZq3fL85hQ&r=6G-pYXDrRNN7Q79BwRHXuvnsUFnhjXBhWoUaZsjutXQ&m=HtKJE76TYmrXzjM4DJ4G0Axt6WsYfb0g1pKaQ2FfOYs&s=Jn4XyXE7z9jNOvj0g1CYb12fI2_QpkzWynRgfsqY74Y&e=" rel="noreferrer" target="_blank">https://mail.python.org/mailman/listinfo/scipy-dev</a><br>
</blockquote>
</div>
</div>
</div>
</body>
</html>