[SciPy-user] bdist_rpm build error in scipy_core from CVS

[Pearu Peterson]

On Sat, 29 Jan 2005, Fernando Perez wrote:

>> Also, try
>> 
>>    rm -rf build MANIFEST scipy_core/{build,MANIFEST,MANIFEST.in}
>> 
>> before running setup.py build.
>
> OK, that did it:

<snip>

> So it looks like we're good to go!  This made me think of the following, 
> which is part of ipython's setup.py:
>
> # BEFORE importing distutils, remove MANIFEST. distutils doesn't properly
> # update it when the contents of directories change.
> if os.path.exists('MANIFEST'): os.remove('MANIFEST')
>
> It might be worth adding a bit of such protection to scipy's setup files, no? 
> This would make the process more robust, I think.
>
> Before applying my patch, I'd prefer to have a bit more confirmation from 
> you/others that it doesn't break everything.

I have learned long time ago that using distutils MANIFEST feature is a 
source of trouble, especially in superpackage like scipy (distutils was 
not designed to support such packages, that's why we have 
scipy_distutils). So, in scipy all sources should be specified in 
setup_*.py files and that avoids any effects caused by distutils MANIFEST.

Recent failures was due to the fact that a line was added to MANIFEST.in.
This is now fixed but people should remove their MANIFEST files manually, 
or, we could also apply your patch. But note that the effect from your 
patch is only temporary; once broken MANIFEST file is removed, the patch 
is not needed anymore (until someone puts files to MANIFEST.in again;-).

Although the patch is completely harmless, I wouldn't apply this patch 
because it is unnecessary and would (may be indirectly) indicate to 
developers that it is ok to use MANIFEST.in, while it's not,

Finally, I recommend reading

   http://www.scipy.org/development/developscipy.txt

to anyone who is interested in scipy setup structure.

Pearu