[spambayes-bugs] [ spambayes-Patches-848311 ] sb_imapfilter.py obeys launch_browser

[SourceForge.net]

Patches item #848311, was opened at 2003-11-25 03:24
Message generated for change (Comment added) made by anadelonbrin
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498105&aid=848311&group_id=61702

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Barry A. Warsaw (bwarsaw)
Assigned to: Nobody/Anonymous (nobody)
Summary: sb_imapfilter.py obeys launch_browser

Initial Comment:
Here's a patch to make sb_imapfilter.py obey the
html_ui::launch_browser option.  This script's -b flag
is overloaded both with starting the web server and
with launching a browser.  I want to start the server
but not launch the browser (since I already have
Mozilla running).

With this patch -b starts the web server, but the
browser is launched on the basis of the
bayescustomize.ini file.


----------------------------------------------------------------------

>Comment By: Tony Meyer (anadelonbrin)
Date: 2003-11-25 19:02

Message:
Logged In: YES 
user_id=552329

This is a bug from older versions of the code that didn't do 
this (my fault, no doubt :).  What about this patch?

----------------------------------------------------------------------

Comment By: Barry A. Warsaw (bwarsaw)
Date: 2003-11-25 17:17

Message:
Logged In: YES 
user_id=12800

My problem was that without the -b option, sb_imapfilter.py
exits with the following message:

You need to specify both a server and a username.

Your patch doesn't change that.  So it seems that the -b or
launchUI variable is overloaded.  I can't suss out what the
original intent was, but I think the script should have
/some/ behavior where it starts the webserver and no browser. ;)


----------------------------------------------------------------------

Comment By: Tony Meyer (anadelonbrin)
Date: 2003-11-25 15:50

Message:
Logged In: YES 
user_id=552329

I prefer the attached patch, which more closely resembles 
the way sb_server.py works.  At the moment you can already 
launch the server without the browser - just 
do "sb_imapfilter.py".

My patch makes *that* command observe the config value, 
and the "-b" switch has the same behaviour as sb_server - it 
forces the option to True.

(So it's a shortcut for -o:html_ui:launch_browser:True or 
however that new-fangled method works).

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498105&aid=848311&group_id=61702