[spambayes-bugs] [ spambayes-Bugs-800555 ] 1.0a5 release missing key outlook files.

Fri Sep 5 21:13:09 EDT 2003

Bugs item #800555, was opened at 2003-09-05 04:09
Message generated for change (Comment added) made by anadelonbrin
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498103&aid=800555&group_id=61702

Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Alastair Rankine (alastair)
Assigned to: Nobody/Anonymous (nobody)
Summary: 1.0a5 release missing key outlook files.

Initial Comment:
Environment:

spambayes-1.0a5 (source)

Python 2.3

win32all-155

Symptom:

Spambayes Manager will not load from either the Outlook toolbar, or from "python manager.py" on the command line. Stack trace is as follows:

pythoncom error: Python error invoking COM method.

Traceback (most recent call last):

  File "C:\Python23\lib\site-packages\win32com\server\policy.py", line 275, in _Invoke_

    return self._invoke_(dispid, lcid, wFlags, args)

  File "C:\Python23\lib\site-packages\win32com\server\policy.py", line 280, in _invoke_

    return S_OK, -1, self._invokeex_(dispid, lcid, wFlags, args, None, None)

  File "C:\Python23\lib\site-packages\win32com\server\policy.py", line 541, in _invokeex_

    return func(*args)

  File "c:\Program Files\spambayes-1.0a5\Outlook2000\addin.py", line 219, in OnClick

    self.handler(*self.args)

  File "c:\Program Files\spambayes-1.0a5\Outlook2000\manager.py", line 790, in ShowManager

    dialogs.ShowDialog(0, self, self.config, "IDD_MANAGER")

  File "c:\Program Files\spambayes-1.0a5\Outlook2000\dialogs\__init__.py", line 48, in ShowDialog

    manager.dialog_parser = LoadDialogs()

  File "c:\Program Files\spambayes-1.0a5\Outlook2000\dialogs\__init__.py", line 34, in LoadDialogs

    if rc_mtime!=mtime or rc_size!=size:

exceptions.UnboundLocalError: local variable 'rc_size' referenced before assignment

Attempted fix:

Add assignment for rc_size within dialogs\__init__.py:

        except OSError:

            rc_mtime = None

            rc_size = None             ### Added

        if rc_mtime!=mtime or rc_size!=size:

Still doesn't seem to work though :(

Outlook2000 $ python manager.py

[... snip ...]

messagesTraceback (most recent call last):

  File "manager.py", line 863, in ?

    sys.exit(main(verbose))

  File "manager.py", line 843, in main

    ShowManager(mgr)

  File "manager.py", line 833, in ShowManager

    mgr.ShowManager()

  File "manager.py", line 790, in ShowManager

    dialogs.ShowDialog(0, self, self.config, "IDD_MANAGER")

  File "c:\Program Files\spambayes-1.0a5\Outlook2000\dialogs\__init__.py", line 49, in ShowDialog

    manager.dialog_parser = LoadDialogs()

  File "c:\Program Files\spambayes-1.0a5\Outlook2000\dialogs\__init__.py", line 42, in LoadDialogs

    mod = __import__(mod_name)

ImportError: No module named dialogs

----------------------------------------------------------------------

>Comment By: Tony Meyer (anadelonbrin)
Date: 2003-09-06 15:13

Message:
Logged In: YES 
user_id=552329

Fixed in MANIFEST.in v1.5

----------------------------------------------------------------------

Comment By: Alastair Rankine (alastair)
Date: 2003-09-06 10:08

Message:
Logged In: YES 
user_id=28845

Confirm that the latest version from CVS fixes this problem.

However there is another problem which happens when you click on the "start training" button:

Outlook2000 $ python manager.py

Loaded bayes database from 'C:\Documents and Settings\arankine\Application Data\

SpamBayes\default_bayes_database.db'

Loaded message database from 'C:\Documents and Settings\arankine\Application Dat

a\SpamBayes\default_message_database.db'

Bayes database initialized with 137 spam and 460 good messages

Exception in thread Thread-1:

Traceback (most recent call last):

  File "C:\Python23\Lib\threading.py", line 436, in __bootstrap

    self.run()

  File "C:\Python23\Lib\threading.py", line 416, in run

    self.__target(*self.__args, **self.__kwargs)

  File "c:\Program Files\spambayes\Outlook2000\dialogs\async_processor.py", line 222, in thread_target

    self.func( self.window.manager, self.window.config, progress)

  File "c:\Program Files\spambayes\Outlook2000\train.py", line 148, in trainer

    classifier_data.InitNew()

  File "c:\Program Files\spambayes\Outlook2000\manager.py", line 258, in InitNew

    self.bayes = self.db_manager.new_bayes()

  File "c:\Program Files\spambayes\Outlook2000\manager.py", line 169, in new_bayes

    return self.open_bayes()

  File "c:\Program Files\spambayes\Outlook2000\manager.py", line 197, in open_bayes

    return bayes_storage.DBDictClassifier(fname)

NameError: global name 'bayes_storage' is not defined

Saving configuration -> C:\Documents and Settings\arankine\Application Data\Spam

Bayes\MS Exchange Settings.ini

Outlook2000 $

Can raise a new bug report for this if needed - just let me know.

New manager app looks fantastic - Keep up the good work guys!

----------------------------------------------------------------------

Comment By: Richie Hindle (richiehindle)
Date: 2003-09-05 19:16

Message:
Logged In: YES 
user_id=85414

I've just added instructions on making a source release

to README-DEVEL.txt.

----------------------------------------------------------------------

Comment By: Tony Meyer (anadelonbrin)
Date: 2003-09-05 15:14

Message:
Logged In: YES 
user_id=552329

AFAIK (this is what I did for 1.0a4) it's just to use 

distutils.  "setup.py bdist" or something like that, from memory.

This means adding a "data_files" list to the setup.py file, I 

think (you'd probably have a better idea than me).  I'll do this 

if you don't.

----------------------------------------------------------------------

Comment By: Mark Hammond (mhammond)
Date: 2003-09-05 14:23

Message:
Logged In: YES 
user_id=14198

I presume that the script to build the release simply

doesn't know to include .rc and .h files.  What is the

release process?

----------------------------------------------------------------------

Comment By: Tony Meyer (anadelonbrin)
Date: 2003-09-05 12:02

Message:
Logged In: YES 
user_id=552329

Mark - any idea why this would be?  I'll be putting out 1.0a6 

tomorrow (if everything goes to plan) so I could fix it for that.

----------------------------------------------------------------------

Comment By: Mark Hammond (mhammond)
Date: 2003-09-05 10:53

Message:
Logged In: YES 
user_id=14198

This is an issue with the 1.0a5 release - it is missing at

least 2 key files.  Please grab either the latest binary, or

the source code from CVS.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498103&aid=800555&group_id=61702