[spambayes-bugs] [ spambayes-Patches-909088 ] remove STLS pop3 capability

[SourceForge.net]

Patches item #909088, was opened at 2004-03-04 04:06
Message generated for change (Comment added) made by anadelonbrin
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498105&aid=909088&group_id=61702

Category: None
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Wummel (calvin)
Assigned to: Richie Hindle (richiehindle)
Summary: remove STLS pop3 capability

Initial Comment:
Inserting this under the pipelineRe stuff in
sb_server.py makes it possible for me to use our cyrus
pop server:

            tlsRE = r'(?im)^STLS[^\n]*\n'
            self.response = re.sub(tlsRE, '',
self.response)


Without it, the connection hangs after this log entry:
IMPLEMENTATION Cyrus POP3 server
v2.1.15-Invoca-RPM-2.1.15-1
.
STLS
+OK Begin TLS negotiation now
[encryption challenge stuff witout newline...]


anyway, thanks for making spambayes :)

----------------------------------------------------------------------

>Comment By: Tony Meyer (anadelonbrin)
Date: 2004-08-03 18:52

Message:
Logged In: YES 
user_id=552329

I've checked this in (the code in Richie's comment, which
appears to work fine).  I've also updated the test, and it
passes, so I presume this works (and can't see why it
wouldn't).  I don't have access to a POP3 server that
legimately offers STLS, though, so can't be 100% certain.

----------------------------------------------------------------------

Comment By: Richie Hindle (richiehindle)
Date: 2004-04-30 06:39

Message:
Logged In: YES 
user_id=85414

Go ahead - it looks fine to me.

Possibly the PIPELINING and STLS pieces should be merged, 
creating a list of unsupported functions.  Something like
(untested):

# There are some features, tested by clients using CAPA,
# that we don't support.  We strip them from the CAPA
# response here, so that the client won't use them.
for unsupported in ['PIPELINING', 'STLS']:
    unsupportedLine = r'(?im)^%s[^\n]*\n' % unsupported
    self.response = re.sub(unsupportedLine, '', self.response)

(there's a test case for PIPELINING in test_sb-server.py,
so the edit ought to include extending that test for STLS
as well, but I won't lose sleep if it doesn't 8-)


----------------------------------------------------------------------

Comment By: Tony Meyer (anadelonbrin)
Date: 2004-04-29 13:48

Message:
Logged In: YES 
user_id=552329

I don't see any problems with this, but check with Richie
first.  If I don't hear back, I'll check this in once 1.0 is
out.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498105&aid=909088&group_id=61702