[spambayes-bugs] [ spambayes-Bugs-990700 ] Changes to asyncore in Python 2.4 break ServerLineReader

SourceForge.net noreply at sourceforge.net
Wed Jul 14 09:01:58 CEST 2004


Bugs item #990700, was opened at 2004-07-14 19:01
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498103&aid=990700&group_id=61702

Category: pop3proxy
Group: Source code - CVS
Status: Open
Resolution: None
Priority: 5
Submitted By: Tony Meyer (anadelonbrin)
Assigned to: Richie Hindle (richiehindle)
Summary: Changes to asyncore in Python 2.4 break ServerLineReader

Initial Comment:
Another Python 2.3.4 -> Python 2.4a1 problem.

Python 2.3.4 has this in asyncore:
"""
    def add_channel(self, map=None):
        #self.log_info('adding channel %s' % self)
        if map is None:
            map = socket_map
        map[self._fileno] = self
"""

The Python 2.4a1 version is this:
"""
    def add_channel(self, map=None):
        #self.log_info('adding channel %s' % self)
        if map is None:
            map = self._map
        map[self._fileno] = self
"""

ServerLineReader defaults to having self._map be None,
so the map[self._fileno] line crashes with a TypeError.

Putting "if map is not None:" before line 191 of
Dibbler.py (and indenting the "self._map = map" line)
fixes this, but again I'd like to check with you that
this is correct before checking it in.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498103&aid=990700&group_id=61702


More information about the Spambayes-bugs mailing list