[spambayes-bugs] [ spambayes-Patches-1707808 ] imap-tte

SourceForge.net noreply at sourceforge.net
Sat May 26 08:05:07 CEST 2007 

Patches item #1707808, was opened at 2007-04-25 22:12
Message generated for change (Comment added) made by david_abrahams
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498105&aid=1707808&group_id=61702

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Open
Resolution: Accepted
Priority: 5
Private: No
Submitted By: David Abrahams (david_abrahams)
Assigned to: Tony Meyer (anadelonbrin)
Summary: imap-tte

Initial Comment:
A patch that enables train-to-exhaustion support for IMAP.

This patch has three parts:

1. an __init__.py in the scripts folder that makes some of the classes in sb_imapfilter available to tte.py.  This change is not represented in the patch file; you'll have to add __init__.py yourself.

2. Some imap support in mboxutils.py

3. Some refactoring in sb_imapfilter.py to sink the port selection logic into IMAPSession.__init__ so that it can be used by tte.py.  In the process we simplify the uses of IMAPSession considerably.

This is probably not refactored in the best way; in particular, #1 above should probably never happen and whatever is used by both sb_imapfilter.py and tte.py should be moved into spambayes/ or at least out of scripts/.  However, before taking on any major restructuring I wanted to get this into the hands of a spambayes devel who can make sure I'm on the right track.

----------------------------------------------------------------------

>Comment By: David Abrahams (david_abrahams)
Date: 2007-05-26 01:05

Message:
Logged In: YES 
user_id=52572
Originator: YES

On --cullext vs --cull, I was thinking it could be '--cullext=' but if
getopt doesn't like that, I'm fine with --cull.

Since tony isn't very active, the thing got auto-closed.  But shouldn't
the patch be applied if he's not going to look at it?
File Added: spambayes.patch

----------------------------------------------------------------------

Comment By: SourceForge Robot (sf-robot)
Date: 2007-05-25 21:20

Message:
Logged In: YES 
user_id=1312539
Originator: NO

This Tracker item was closed automatically by the system. It was
previously set to a Pending status, and the original submitter
did not respond within 14 days (the time period specified by
the administrator of this Tracker).

----------------------------------------------------------------------

Comment By: Skip Montanaro (montanaro)
Date: 2007-05-10 21:26

Message:
Logged In: YES 
user_id=44345
Originator: NO

I'm a little curious about the -C flag.  The code reads:

         elif opt in ("-c", "--cullext"):
             cullext = arg
         elif opt in ("-C", "--cullext"):
             cullext = ''
In general it seems you cleaned up my crappy code in tte.py quite a bit. 
Thanks for that...  A couple comments:

* The "--cullext" can't work for both -C and -c.  Maybe you should have
"--cull" (cull with no extension) to avoid conflict?  I made that change. 
Let me know if you have a different change in mind.

* I don't know the sb_imapfilter code at all.  I'll assign this to Tony in
case he has a moment to scan that part of the patch.  Tony, just mark it
closed if you agree with the changes or can easily change anything you take
issue with.

* You're using psycopg classifier?  Brave man. ;-)

Skip


----------------------------------------------------------------------

Comment By: David Abrahams (david_abrahams)
Date: 2007-05-10 20:18

Message:
Logged In: YES 
user_id=52572
Originator: YES

Great!  Please give the code a once-over before checking it in.  It
touches quite a few parts of SpamBayes and I don't want to step on any
toes.

----------------------------------------------------------------------

Comment By: Skip Montanaro (montanaro)
Date: 2007-05-10 19:26

Message:
Logged In: YES 
user_id=44345
Originator: NO

I applied it to my environment.  tte.py and my strange
fetchmail/sb_bnfilter.py setup seems to work fine.

    contrib/tte.py 1.18
    spambayes/mboxutils.py 1.11
    spambayes/storage.py 1.63
    scripts/sb_imapfilter.py 1.67


----------------------------------------------------------------------

Comment By: David Abrahams (david_abrahams)
Date: 2007-05-10 09:28

Message:
Logged In: YES 
user_id=52572
Originator: YES

File Added: sb.patch

----------------------------------------------------------------------

Comment By: David Abrahams (david_abrahams)
Date: 2007-05-09 10:14

Message:
Logged In: YES 
user_id=52572
Originator: YES

I would like you to try it out a little, at least, before feeling
confident about it.  I've only used it on IMAP folders and I wouldn't want
to break the other use cases.

----------------------------------------------------------------------

Comment By: Skip Montanaro (montanaro)
Date: 2007-05-09 10:04

Message:
Logged In: YES 
user_id=44345
Originator: NO

Dave,

Do you think this has stabilized well enough to apply to the
repository?  If so, I'll just make a quick review and apply
it.

Skip


----------------------------------------------------------------------

Comment By: David Abrahams (david_abrahams)
Date: 2007-05-09 00:33

Message:
Logged In: YES 
user_id=52572
Originator: YES

That patch evolved yet again, massively.  I implemented a version of
culling for IMAP and refactored tte.py to greatly simplify it and remove
redundancy.  Hope you find that nice and not annoying ;-)
File Added: sb.patch

----------------------------------------------------------------------

Comment By: David Abrahams (david_abrahams)
Date: 2007-04-26 17:03

Message:
Logged In: YES 
user_id=52572
Originator: YES

It looks like I forgot one thing in sb_imapfilter.py:

@@ -1200,6 +1209,7 @@
             imap_filter = IMAPFilter(classifier, message_db)
 
         httpServer = UserInterfaceServer(options["html_ui", "port"])
+        pwds = [ x[2] for x in servers_data ]
         httpServer.register(IMAPUserInterface(classifier, imaps, pwds,
                                               IMAPSession, stats=stats,
                                               close_db=close_db,


I've attached a complete patch that contains that change and all of my
other fixes/workarounds (I have several patches in this tracker that
haven't been acted on).  You can ignore it if you prefer and just make the
additional change above.

File Added: spambayes.patch

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498105&aid=1707808&group_id=61702

More information about the Spambayes-bugs mailing list