[spambayes-dev] Nuke experimental_ham_spam_imbalance_adjustment?

[Skip Montanaro]

    Mark> However, there is an issue regarding existing users of the addin.
    Mark> For Outlook in particular, if an old copy of
    Mark> "default_bayes_customize.ini" exists, we do not copy our new
    Mark> version over it.  As experimental_ham_spam_imbalance_adjustment
    Mark> was set to True in early versions, this option will remain in
    Mark> effect, even when these users upgrade to newer versions.

If you rip out the code in classifier.py, you should be able to simply
change its name in Options.py to

    x-experimental_ham_spam_imbalance_adjustment

That's how you deprecate an option based upon the code I added to
OptionsClass.py the other day.  If the user sets "foo" but it doesn't exist
and "x-foo" does, a message is printed to stderr, but nothing bombs.  Take a
look at the docstring for the OptionsClass module.

    Mark> Longer term, I think the way we copy this file to the users data
    Mark> directory was a mistake, and I am likely to fix it (there is a bug
    Mark> on it from a confused user).

What's the mistake?  I think it's correct to not obliterate the user's local
copy of the config file.  Plenty of programs either don't copy config files
during install if a copy is already present, or install it to a different
name so the user can compare local and as-distributed versions of the file.

Skip