[spambayes-dev] [ spambayes-Bugs-737967 ] Malformed messages break pop3proxy (et al)

[SourceForge.net]

Bugs item #737967, was opened at 2003-05-14 23:49
Message generated for change (Comment added) made by richiehindle
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498103&aid=737967&group_id=61702

Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Tony Meyer (anadelonbrin)
Assigned to: Nobody/Anonymous (nobody)
Summary: Malformed messages break pop3proxy (et al)

Initial Comment:
Those applications using message.py (pop3proxy, 
imapfilter, maybe others at some point) die if a message 
fails to parse through the email package.

----------------------------------------------------------------------

>Comment By: Richie Hindle (richiehindle)
Date: 2003-07-02 19:45

Message:
Logged In: YES 
user_id=85414

This is now fixed for pop3proxy.  When the email package
barfs on a message, the proxy recovers and adds an
X-Spambayes-Exception header to the message, giving
details of the exception.  No classification headers are
added.  I won't close the bug report because it's only
fixed for the POP3 proxy.


----------------------------------------------------------------------

Comment By: Tony Meyer (anadelonbrin)
Date: 2003-05-14 23:52

Message:
Logged In: YES 
user_id=552329

Moving from "Bugs item #737642":

I'm using pop3proxy (from cvs 2003.05.13) and sometime I'm 
not able to retreive my mail from one my pop account 

I'm getting the following error: 
error: uncaptured python exception, closing channel 
<__main__.ServerLineReader c 
onnected at 0x138d160> 
(email.Errors.HeaderParseError:Not a header, not a contin 
uation: ``charset="iso-8859-1"'' 
[C:\Devtools\Python\PYTHON~1.2\lib\asyncore.py| 
poll|99] 
[C:\Devtools\Python\PYTHON~1.2
\lib\asyncore.py|handle_read_event|396] 
[ 
C:\Devtools\Python\PYTHON~1.2
\lib\asynchat.py|handle_read|130] 
[C:\Devtools\SPAM 
BA~1\SPAMBA~1.13\POP3PR~1.PY|found_terminator|146] 
[C:\Devtools\SPAMBA~1\SPAMBA~ 
1.13\POP3PR~1.PY|onServerLine|214] 
[C:\Devtools\SPAMBA~1\SPAMBA~1.13\POP3PR~1.PY 
|onResponse|288] 
[C:\Devtools\SPAMBA~1\SPAMBA~1.13
\POP3PR~1.PY|onTransaction|389 
] 
[C:\Devtools\SPAMBA~1\SPAMBA~1.13
\POP3PR~1.PY|onRetr|436] 
[C:\Devtools\SPAMBA~ 
1\SPAMBA~1.13\spambayes\message.py|setPayload|168] 
[C:\Devtools\Python\PYTHON~1. 
2\lib\email\Parser.py|_parsebody|228] 
[C:\Devtools\Python\PYTHON~1.2\lib\email\P 
arser.py|parsestr|75] 
[C:\Devtools\Python\PYTHON~1.2\lib\email\Parser.py|parse|6 
2] 
[C:\Devtools\Python\PYTHON~1.2
\lib\email\Parser.py|_parseheaders|128]) 


I retrieve the mail directly without using pop3proxy 
and tested each message with the classify options on 
the web interface and there was not problem. 

Remi 
papaDoc at videotron.ca 


----------------------------------------------------------------------

Comment By: Tony Meyer (anadelonbrin)
Date: 2003-05-14 23:51

Message:
Logged In: YES 
user_id=552329

I suspect this was behind this (really old closed) bug as well:
[ 650496 ] hammie.py discards headers

----------------------------------------------------------------------

Comment By: Tony Meyer (anadelonbrin)
Date: 2003-05-14 23:50

Message:
Logged In: YES 
user_id=552329

(Comment from the list)

As others have said, hammie eats the headers if there is a 
message parsing failure.  This is fairly easy to cause with a 
malformed MIME section.  I mentioned this on list a couple 
times a few months ago (including a message which causes 
it to happen), and the general reaction at the time was that 
Barry should fix the non-strict MIME parser in the email 
package, rather than making the error handling in spambayes 
itself more robust.  This hasn't been a high-priority task, given 
that it's really only idiots like me who hand-craft MIME 
messages (with the occasional error) who are sending 
malformed messages to trigger the problem.

- Alex

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498103&aid=737967&group_id=61702