[spambayes-dev] Does this seem too brutal?
Skip Montanaro
skip at pobox.com
Tue Sep 9 14:04:42 EDT 2003
Tony> What about the attached diff? It's basically Skip's patch but
Tony> also with Richie's suggestion. (And also without the hack part,
Tony> based on the c.l.p. response to Skip's query).
A couple other suggestions:
* Realign the indentation of the args in the setup() call. Everything else
in the file has four-space indents. The args to setup() have a
combination of two-space and eight-space indents.
* Make sure the os.remove() calls in .run() don't bomb out in case any old
scripts have already been deleted.
* ??? Return parent.run(self) in all cases. In your code if there are old
scripts but the user chooses not to remove them, parent.run(self) is not
called.
Attached is a(nother) proposed mod.
Skip
-------------- next part --------------
A non-text attachment was scrubbed...
Name: setup.py.diff
Type: application/octet-stream
Size: 4566 bytes
Desc: not available
Url : http://mail.python.org/pipermail/spambayes-dev/attachments/20030909/95b89dd2/setup.py.obj
More information about the spambayes-dev
mailing list