[spambayes-dev] Use of email factory function

[Sjoerd Mullender]

Another buglet still: in IMAPMessage.Save there is still a reference to 
the variable imap.  This should probably be self.imap_server instead.

Sjoerd Mullender wrote:
> Tony Meyer wrote:
> 
>>> It doesn't work and I wonder how it can work in your environment.
>>
>>
>>
>> I did say I did limited testing.  The tests didn't raise any of the
>> (incorrect) BadIMAPResponse exceptions, so they didn't cause 
>> problems.  I've
>> fixed those, thanks.
> 
> 
> There is still one except BadIMAPResponse: in folder_list.
> 
>>> Also, since in sb_imapfilter.py imap is no longer a global variable, 
>>> the call to imap.close() in IMAPSession.SelectFolder()
>>> causes a NameError exception.  Should that be self.close() instead?
>>
>>
>>
>> This one I missed because I don't expunge.  It should be
>> self.imap_server.close(), and I've fixed this, too, thanks.
> 
> 
> Is that so?  The call is in IMAPSession class, not in IMAPMessage where 
> all other references to self.imap_server are.  I don't see where 
> self.imap_server is initialized in the IMAPSession class.
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> spambayes-dev mailing list
> spambayes-dev at python.org
> http://mail.python.org/mailman/listinfo/spambayes-dev


-- 
Sjoerd Mullender <sjoerd at acm.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 374 bytes
Desc: OpenPGP digital signature
Url : http://mail.python.org/pipermail/spambayes-dev/attachments/20040806/18edca67/signature.pgp