[Spambayes] proposed changes to hammie & co.

[Tim Stone - Four Stones Expressions]

So then, Neale Pickett is all like:

11/19/2002 5:39:45 PM, Neale Pickett <neale@woozle.org> wrote:

>So then, Tim Stone - Four Stones Expressions <tim@fourstonesExpressions.com> 
is all like:
>
>> I'll wait for your checkin, and do some more work on the dbdict module
>> to add my load/store stuff...
>
>Okay Tim, I'll tell you what.  I'm going to create a branch and check in
>everything I've got.  I'm branching because what I have right now breaks
>some existing functionality.

Ok, I've got the branch right now... I'll make my little tweaks.  You'll see 
how I do the load/store stuff with the dbm in LSDBDict(DBDict).  Basically, 
keeps a working file...

I have a few other tweaks to the Corpus stuff that are really unrelated to 
this work, more to do with Richie's needs.  I'll put them in the playground as 
well, just for consistency's sake.

>
>In the branch, we can play around with moving things out of the
>classifier, moving options, etc.  When we get something that we think is
>stable, and everyone else okays it, we can merge it all back in to HEAD.
>
>I've called the branch "hammie-playground".  To get to it, just 
>
>  $ cvs update -r hammie-playground
>
>The branch need not be around for a long time, just long enough to work
>out all these changes.
>

>> I think we should think about where WordInfo class goes...
>> I think we should take Bayes out of classifier and put it in Bayes.py
>
>That's rather unorthodox.  Why?
>Now that's downright heretical!  ;)  It makes sense, I think, Bayes.py
>being where all the Bayes stuff hangs out.  But if you take WordInfo out
>of classifier, and you take Bayes out of classifier, all you'll have
>left is two constants.  Maybe you just want to rename classifier.py.  I
>wonder what the other Tim thinks about this idea...
>

Yeah, the more I think about it, the more I realize my issue is that 
classifier kinda doesn't tell me what's in there.  WordInfo and Bayes 
superclass... Doesn't really matter to me, but would make more sense to me 
from a packaging point of view to simply have one file to distribute rather 
than two...

>I'm leaning heavily toward dictching WIDict and subclassing
>Pickler/Unpickler; I think that's the Right Thing.  It will be slower
>running, but maybe not significantly so.  I'll run some trials when I
>get home.

I don't see WIDict in the playground, so I assume you've ditched it already?  
But I don't see a pickle subclass either... am I missing something.  Haven't 
tried running anything yet, so maybe it will become obvious to me when I do... 
<wink>

>Neale
>
>
- Tim
www.fourstonesExpressions.com