[Spambayes] [ spambayes-Bugs-737874 ] Outlook crash wipes out SpamBayes addin settings & training

[SourceForge.net]

Bugs item #737874, was opened at 2003-05-15 06:18
Message generated for change (Comment added) made by mhammond
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498103&aid=737874&group_id=61702

Category: Outlook
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 5
Submitted By: Scott Sanders (giveuptheghost)
Assigned to: Mark Hammond (mhammond)
Summary: Outlook crash wipes out SpamBayes addin settings & training

Initial Comment:
When Outlook crashes, it wipes out the SpamBayes
Outlook Addin's settings, including all its training.
At least, it does for me.

Most programs have their important data and settings in
a file somewhere or the Registry where it somehow can't
be corrupted, much less erased, when a problem comes
up. <sarcasm>Maybe SpamBayes should look into this
concept.</sarcasm>

I've attached the log for the affected session, though,
after perusing it myself, it looks like SpamBayes is
not causing Outlook to crash. I think it has to do with
my network printer driver when I'm offline from the
network, which causes a similar problem with other
programs. (As a workaround, I've removed the Print
button from the Outlook windows that I use, since it
seems to crash just on mouseover!)

I'm running SpamBayes Outlook Addin 002 with Outlook XP
under Windows XP Pro. The other Outlook COM addins that
are enabled are SpamSource and SyncNow.

----------------------------------------------------------------------

>Comment By: Mark Hammond (mhammond)
Date: 2003-05-19 10:52

Message:
Logged In: YES 
user_id=14198

I'm going to mark this as fixed - please re-open if the
current CVS version still fails for you (or if the next
binary still does).

The current code takes a number defensive measures:
* All config files (and pickle databases) are saved to a
temp file, then moved to the real file.
* Configuration is saved whenever the dialog is closed.
* Databases are saved after any training operations

The combination of these things should resolve this issue.

----------------------------------------------------------------------

Comment By: Scott Sanders (giveuptheghost)
Date: 2003-05-15 10:20

Message:
Logged In: YES 
user_id=184281

Hi.

The last crash occurred this afternoon, and the settings
files that exist and their modified dates are as follows:

default_bayes_customize.ini - 5/10/2003 3:45 PM
default_bayes_database.db - 5/13/2003 3:59 PM
default_configuration.pck - 5/13/2003 3:59 PM
default_message_database.db - 5/10/2003 3:45 PM

Apparently the settings/training isn't changed until Outlook
is closed? I usually have Outlook always running, and I
seldom intentionally close it, except for an Outlook-related
program update (rare) or if I shut down my comp. (also
rare). I may be an exception, but I think the
settings/training should be written at the time of
setting/training.

----------------------------------------------------------------------

Comment By: Tony Meyer (anadelonbrin)
Date: 2003-05-15 09:21

Message:
Logged In: YES 
user_id=552329

The settings are saved in various files which, for you, are in 
the directory:
C:\Documents and Settings\Administrator\Application 
Data\SpamBayes\

Neither the database nor the config pickle should be 
corrupted by an Outlook crash unless they were being used 
at the time.  At one point the plugin didn't save the config 
settings until shutdown (this might even still be the case), so 
if you are crashing before you close Outlook, you would never 
save the settings, which would cause this behaviour.

Check to see if the files are there, before and after the crash, 
and if they are modifed after the crash.

It certainly does seem from the log that neither file is saved.  
This could perhaps be changed, but as I said above, it might 
have done so already since the 002 release.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=498103&aid=737874&group_id=61702