[Tracker-discuss] Feature/Change request handling procedure

"Martin v. Löwis" martin at v.loewis.de
Sun Nov 26 09:33:30 CET 2006


Stefan Seefeld schrieb:
> How would you tag patches (attachments, generally) to decide / indicate
> whether it actually contains a patch and not some other content, and whether
> it really fixes the bug ? Doesn't this involve at least some developer
> interaction anyway, at which point we could simply set a 'contains fix'
> flag that would be part of the bug type, or absorb into the status
> enumeration as 'fix_provided_but_needs_testing', as suggested earlier ?

I have no preference here. Having a "patch" tag might work; classifying
attachments as patches might also work. Typically, *all* patches in
"open" submissions still need review: if they are successfully reviewed,
the patch gets either accepted or rejected; if accepted, it gets
committed and the issue closed. So I don't see the need to distinguish
between "has patch" and "has working patch". If the patch is not
acceptable as-is, the submitter may be asked to rework it. I had
no need to filter for that status: if I open the issue, I can easily
see that it is still in the feedback phase (and reject the patch
if the submitter is unresponsive).

Regards,
Martin



More information about the Tracker-discuss mailing list