[Tracker-discuss] [issue264] Mail gateway borks quotes and console sessions

Daniel Diniz metatracker at psf.upfronthosting.co.za
Tue Apr 7 19:29:27 CEST 2009

Daniel Diniz <ajaksu at gmail.com> added the comment:

In the original code, a for-else is used with wrong logic, so that if there was
a response ('no blank line between quoted message and response') in the section,
the loop would break and not execute the else[1]. Unfortunately, the code that
checks whether to include the quoted text verbatim is inside the else clause.

Attached patch fixes this and reorganizes the code a bit.

[1] http://docs.python.org/reference/compound_stmts.html#the-for-statement

PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_quotes.diff
Type: text/x-diff
Size: 2175 bytes
Desc: not available
URL: <http://mail.python.org/pipermail/tracker-discuss/attachments/20090407/eda64e82/attachment.diff>

More information about the Tracker-discuss mailing list