[Tracker-discuss] [issue270] Upgrade to 1.4.8

["Martin v. Löwis" <metatracker@psf.upfronthost at psf.upfronthosting.co.za]

Martin v. Löwis <martin at v.loewis.de> added the comment:

> Should I keep this change (lowercasing existing POSTs) out of the 1.4.8 patch?

Yes, please. A "it now validates" patch would be better.

> I'd like to gradually make our template more general were it doesn't
> cause us harm. I'm fine with relying on set() being built-in and I can
> edit the patch on that assumption. But the fact that our
> nosyreaction.py still uses "import sets [...] sets.Set()" makes me
> think that the least we diverge from upstream (without creating more
> work for us), the better.

Ok, patching detectors to match more closely the upstream reactors
is good (i.e. if a fragment is in 1.4.8, it has a place in this patch).

Stuff that is *not* in the upstream code does not belong into this
patch. Wrt. 2.3 support, I think any effort in providing it is wasted.

> IMHO, both explicitly targeting a specific (set of) version(s) or
> using the anypy helper could help us make our detectors better and
> less prone to bit-rot. So, what would you prefer: target 2.4 and above
> (2.x), target  2.4-2.6, rely on anypy, something else?

I disagree that the python-dev tracker is the place to start
a generic reusable template. Feel free to contribute it to roundup,
and perhaps talk roundup maintainers into making it a new template,
but leave this project please out of our instances.

The tracker instance is *not* reusable. It is tightly integrated
with the rest of python.org in terms of layout, and it should
stay that way.

>> - I wonder why _generic.help now uses "structure"
> 
> The patch makes it stop using structure, which fixes some security
> issues in the helpers: structure means "do not encode '<' and '>' ",
> making it possible to use raw html there. As Richard said, some of our
> problems in this area are fixed upstream in the classic template.

Ah, ok. That's fine, then.

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue270>
_______________________________________________________