[Tracker-discuss] [issue611] Update issue with a commit information

[Maciej Szulik]

Maciej Szulik added the comment:

> This seems to have some odd behavior, see for example https://bugs.python.org/issue29381

> Each action (add message, change status, change resolution, change stage) all happened separately, which means 4 separate emails sent to everyone on the nosy list.

Thanks for the pointer, I'll look into why there are multiple events. Yes, one should be done.


> Also, automatic closure isn't the correct behavior, IMO; it should match the existing hg integration where closure only occurs if the message contains "Closes #<num>" or "Fixes #<num>" rather than just "Issue #<num>".

Yes it should work like that, apparently something went wrong, will dig deeper.


> BTW, there is a separate issue to set appropriate fields when an issue is manually closed: http://psf.upfronthosting.co.za/roundup/meta/issue595 (I should probably apply it :))

Didn't know about that, I'll look and apply accordingly.


> Note https://mail.python.org/pipermail/docs/2017-February/thread.html
> The multiple email issue is definitely going to need to be fixed sooner rather than later :)

Multiple emails due to hg + gh will be fixed when we migrate to gh. 
Multiple emails due to above needs fixing - agreed.
Multiple emails due to multiple branches - unfortunately won't, b/c each push is against separate
branch and when processing that I don't know anything about related pushes.


> Also, I just noticed that the date is not set on the messages.

Good point, will fix.


Zach and Berker thanks for pointers, greatly appreciated!

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue611>
_______________________________________________________