[Tracker-discuss] [issue654] Add triager icon

[Berker Peksag]

New submission from Berker Peksag <berker.peksag at gmail.com>:

Here's patch that implements Ezio's suggestion in msg3197.

----------
files: add_triager_icon.diff
messages: 3461
nosy: berker.peksag, ezio.melotti, r.david.murray
priority: feature
status: unread
title: Add triager icon

_______________________________________________________
PSF Meta Tracker <metatracker at psf.upfronthosting.co.za>
<http://psf.upfronthosting.co.za/roundup/meta/issue654>
_______________________________________________________
-------------- next part --------------
diff --git a/extensions/pydevutils.py b/extensions/pydevutils.py
--- a/extensions/pydevutils.py
+++ b/extensions/pydevutils.py
@@ -16,16 +16,20 @@ def is_history_ok(request):
     # currently not used
     return True
 
 def is_coordinator(request):
     user = request.client.userid
     db = request.client.db
     return 'Coordinator' in db.user.get(user, 'roles')
 
+def is_triager(request, userid):
+    db = request.client.db
+    return 'Developer' in db.user.get(userid, 'roles')
+
 def clean_ok_message(ok_message):
     """Remove nosy_count and message_count from the ok_message."""
     pattern = '\s*(?:nosy|message)_count,|,\s*(?:nosy|message)_count(?= edited)'
     return ''.join(re.sub(pattern, '', line) for line in ok_message) + '<br>'
 
 
 def issueid_and_action_from_class(cls):
     """
@@ -86,13 +90,14 @@ class RandomIssueAction(Action):
         random.seed()
         url = self.db.config.TRACKER_WEB + 'issue' + random.choice(issue_ids)
         raise Redirect(url)
 
 
 def init(instance):
     instance.registerUtil('is_history_ok', is_history_ok)
     instance.registerUtil('is_coordinator', is_coordinator)
+    instance.registerUtil('is_triager', is_triager)
     instance.registerUtil('clean_ok_message', clean_ok_message)
     instance.registerUtil('issueid_and_action_from_class',
                           issueid_and_action_from_class)
     instance.registerUtil('clas_as_json', clas_as_json)
     instance.registerAction('random', RandomIssueAction)
diff --git a/html/issue.item.html b/html/issue.item.html
--- a/html/issue.item.html
+++ b/html/issue.item.html
@@ -358,16 +358,19 @@
                     replace="author_name" />
        </tal:block>
        (<a tal:condition="python:utils.is_coordinator(request)"
            tal:attributes="href python:'user%s' % msg.author.id"
            tal:content="msg/author"/><tal:x condition="python:not utils.is_coordinator(request)" content="msg/author"/>)
        <span tal:condition="msg/author/contrib_form" title="Contributor form received">*</span>
        <img tal:condition="msg/author/iscommitter" src="@@file/committer.png"
             title="Python committer" alt="(Python committer)"/>
+       <img tal:define="user_id python:msg.author.id; is_committer python:msg.author.iscommitter"
+            tal:condition="python:not is_committer and utils.is_triager(request, user_id)"
+            src="@@file/triager.png" title="Triager" alt="Triager"/>
    </th>
    <th i18n:translate="">Date: <tal:x replace="python:msg.date.pretty('%Y-%m-%d %H:%M')"
        i18n:name="date" /></th>
   </tr>
   <tr>
    <td colspan="4" class="content">
     <p class="error-message"
        tal:condition="python:utils.sb_is_spam(msg)">
diff --git a/html/triager.png b/html/triager.png
new file mode 100644
index 0000000000000000000000000000000000000000..0bcdca6e48e75017037e837b0d6fba8662769fd6
GIT binary patch
literal 477
zc$@*<0V4j1P)<h;3K|Lk000e1NJLTq000mG000mO1ONa4wfZ;e00001b5ch_0Itp)
z=>Px#0%A)?L;(MXkIcUS000SaNLh0L01FcU01FcV0GgZ_00007bV*G`2jT_<7CIt-
z7&3tX00Ci1L_t(2&sC8zOB`VkhM(PAxz8gu2ZEPiW0 at k5CZ)wex)fRn<_BmKB&{|U
zCLw|RfdmUvNK#mcl{OM9kqd_=ogkXn92N)SNp^0(nQv3<-Wg}Qd7gKsn2568Y-iI}
z_he)u>l-Tw1`rPfn^~(X9wRuGn8X$Hp`a|I7>WmIP%GvMyj#^NAIYX9Qt^z;<p5PG
zrSN{=nt=dRs1l*&#`BJs{>LXD;?PuzHnhaDi&ui<6%P~p4|^b&{`YU6Th9$8)M+Gx
z{OxZ0>#u8+ob2H7gV%;(Fq&kdPPy6ovUxV|W`ncgF++tY*58V8ymP)#dwCxl=?}8F
z|H+H;^V+>Akd at GY(>;0-js}nDU$zY8YAeqR1^%2Y9&r&7Q>8|J(Y;G6&zjtlazi&E
zkdlIz;EL5xX$d(Ux+psQMQ={pnHb99Y5OgnzodBbXdvJiXM!<C2=wT1g#i2mV};G2
TXf-kn00000NkvXXu0mjfG10^%