[Tutor] duplication in unit tests

Serdar Tumgoren zstumgoren at gmail.com
Wed Dec 9 04:11:56 CET 2009

Hi Kent and Lie,

First, thanks to you both for the help. I reworked the tests and then
the main code according to your suggestions (I really was muddling
these TDD concepts!).

The reworked code and tests are below. In the tests, I hard-coded the
source data and the expected results; in the main program code, I
eliminated the FileCleaner class and converted its methods to
stand-alone functions. I'm planning to group them into a single,
larger "process" function as you all suggested.

Meantime, I'd be grateful if you could critique whether I've properly
followed your advice. And of course, feel free to suggest other tests
that might be appropriate. For instance, would it make sense to test
convertEmDashes for non-unicode input?

Thanks again!

#### test_cleaner.py ####
from cleaner import convertEmDashes, splitLines

class TestCleanerMethods(unittest.TestCase):
    def test_convertEmDashes(self):
        """convertEmDashes to minus signs"""
        srce = u"""This    line   has an em\u2014dash.\nSo   does this
        expected = u"""This    line   has an em-dash.\nSo   does this  -.\n"""
        result = convertEmDashes(srce)
        self.assertEqual(result, expected)

    def test_splitLines(self):
        """splitLines should create a list of cleaned lines"""
        srce = u"""This    line   has an em\u2014dash.\nSo   does this
        expected = [u'This    line   has an em\u2014dash.', u'So
does this  \u2014.']
        result = splitLines(srce)
        self.assertEqual(result, expected)

#### cleaner.py ####
def convertEmDashes(datastring):
    """Convert unicode emdashes to minus signs"""
    datastring = datastring.replace(u'\u2014','-')
    return datastring

def splitLines(datastring):
    """Generate list of cleaned lines"""
    data = [x.strip() for x in datastring.strip().split('\n') if x.strip()]
    return data

More information about the Tutor mailing list