[Tutor] General Feedback, Script Structure

Alan Gauld alan.gauld at btinternet.com
Sun Feb 15 20:00:39 CET 2009


"Damon Timm" <damontimm at gmail.com> wrote

> It works fine -- seems to do what I need -- but, to be very frank, I
> don't think it is very *pretty* !  But, I am not sure what the

> http://python.pastebin.com/m4e1694d5
>
> Would be interested in any feedback (obviously, I should add some 
> doc strings!).

It doesn't look too bad to me, I'd probably do the dictionary
assignments as a single statement rather than all the separate
assignment lines and I'd also move it out of the function as a module
level variable.

Other than that it's not too bad IMHO

Alan G 




More information about the Tutor mailing list