[Tutor] Code review, plase

Wayne Werner waynejwerner at gmail.com
Tue Sep 7 23:07:45 CEST 2010


On Tue, Sep 7, 2010 at 3:39 PM, Alex <metallourlante at gmail.com> wrote:

> Hi all.
>
> Could someone review my code? It's the first time I develop a reusable
> module and I would like to have some feedback.
> If you think it's good enough I will package it for pypi.
>
> I put the code on pastebin: http://pastebin.com/Tz367gAM
>
> Thanks in advance.
>
> Alex


I mostly just glanced through it and didn't notice any gross errors. Your
comments should be standardized - I think I got them all here:
http://pastebin.com/BZSTRVWd Also, I changed line 83 to say what I think you
meant to say. I could be wrong, but I don't think something like "Job 342
exist" is what you meant.

HTH,
-Wayne
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/tutor/attachments/20100907/14da43ce/attachment.html>


More information about the Tutor mailing list