[XML-SIG] xml-package comments

[Fred L. Drake]

  Ok, I've finally had time to take a quick look at the "combined" xml 
package, and have a few comments.
  The install target places all the Python modules directly in
site-packages/xml/, which seems like a bug to me.  (Solaris 2.6
patched, current Python, using the Python supplied installer script.)
I've appended a patch to the Makefile.pre.in to fix this.
  The C modules are added to the site-packages/ directory; is there
any reason for this?  It seems that they should go into appropriate
places in the tree.  I remember ni didn't handle DLL modules off the
standard path, but the built-in packages seem to handle it quite fine
(I've been using that feature for a while now, at least).  pyexpat and 
sgmlop should be more appropriately installed, and __init__.py files
added where needed.
  Otherwise the build/install was very clean!


  -Fred

--
Fred L. Drake, Jr.	     <fdrake@acm.org>
Corporation for National Research Initiatives
1895 Preston White Dr.	    Reston, VA  20191


*** Makefile.pre.in.orig	Tue Jun  9 10:09:40 1998
--- Makefile.pre.in	Fri Jun 19 17:45:56 1998
***************
*** 357,367 ****
  		fi; done
  	for i in `find *.py $(LIBSUBDIRS) -name '*.py' -print` ; do \
  		if test -x $$i; then \
! 			$(INSTALL_PROGRAM) $$i $(LIBXML); \
! 			echo $(INSTALL_PROGRAM) $$i $(LIBXML); \
  		else \
! 			$(INSTALL_DATA) $$i $(LIBXML); \
! 			echo $(INSTALL_DATA) $$i $(LIBXML); \
  		fi; \
          done
  	PYTHONPATH=$(LIBXML) \
--- 357,367 ----
  		fi; done
  	for i in `find *.py $(LIBSUBDIRS) -name '*.py' -print` ; do \
  		if test -x $$i; then \
! 			$(INSTALL_PROGRAM) $$i $(LIBXML)/$$i; \
! 			echo $(INSTALL_PROGRAM) $$i $(LIBXML)/$$i; \
  		else \
! 			$(INSTALL_DATA) $$i $(LIBXML)/$$i; \
! 			echo $(INSTALL_DATA) $$i $(LIBXML)/$$i; \
  		fi; \
          done
  	PYTHONPATH=$(LIBXML) \