[Mailman-Users] Error when list Moderator deals with pendingrequests

[Mark Sapiro]

Mark Ryan wrote:
>
>We're running Mailman 2.1.12 on a Ubuntu server, version 9.0.4. We've run
>into an issue when a list moderator takes care of pending requests.what
>happens is when the moderator takes an action for the request and hits the
>Submit Data button, it throws the "we hit a bug" message. I looked through
>the error logs and found this entry which I've copied and pasted below. I'm
>the owner for all of our lists and I don't encounter this when I take care
>of the pending requests, it only happens to the moderators. Can anyone give
>me some insight as to what may be going on?


Yes. This is a Python 2.6 incompatibility in 2.1.12. It only occurs
when the moderators do the approval because only the moderators are
checking the 'Preserve messages for the site administrator' checkbox
when handling messages. (You might want to check Mailman's spam/
directory to see how many preserved messages are there.)

Here is a patch to fix the incompatibility.


--- Mailman/ListAdmin.py        2008-09-21 18:59:44 +0000
+++ Mailman/ListAdmin.py        2009-08-01 00:40:36 +0000
@@ -1,4 +1,4 @@
-# Copyright (C) 1998-2008 by the Free Software Foundation, Inc.
+# Copyright (C) 1998-2009 by the Free Software Foundation, Inc.
 #
 # This program is free software; you can redistribute it and/or
 # modify it under the terms of the GNU General Public License
@@ -202,7 +202,7 @@
                     cPickle.dump(msg, fp, 1)
                 else:
                     g = Generator(fp)
-                    g(msg, 1)
+                    g.flatten(msg, 1)
                 fp.flush()
                 os.fsync(fp.fileno())
             finally:
@@ -251,7 +251,7 @@
             outfp = open(outpath, 'w')
             try:
                 g = Generator(outfp)
-                g(msg, 1)
+                g.flatten(msg, 1)
             finally:
                 outfp.close()
         # Now handle updates to the database


-- 
Mark Sapiro <mark at msapiro.net>        The highway is for gamblers,
San Francisco Bay Area, California    better use your sense - B. Dylan