I have created a new PR, have removed one irrelevant version check. https://github.com/numpy/numpy/pull/3304/files On Fri, May 3, 2013 at 11:29 PM, Arink Verma <arinkverma@iitrpr.ac.in>wrote:
I hardly found, any thing to improve and correct.. not even typo in docs? Where we need to avoid the version checks?
On Fri, May 3, 2013 at 10:52 PM, Charles R Harris < charlesr.harris@gmail.com> wrote:
On Thu, May 2, 2013 at 6:47 PM, <josef.pktd@gmail.com> wrote:
On Thu, May 2, 2013 at 6:30 PM, Ralf Gommers <ralf.gommers@gmail.com> wrote:
On Fri, May 3, 2013 at 12:29 AM, Ralf Gommers <ralf.gommers@gmail.com> wrote:
On Thu, May 2, 2013 at 9:54 PM, Charles R Harris <charlesr.harris@gmail.com> wrote:
On Thu, May 2, 2013 at 11:49 AM, Ralf Gommers <
ralf.gommers@gmail.com>
wrote: > > > > > On Thu, May 2, 2013 at 6:45 PM, Pauli Virtanen <pav@iki.fi> wrote: >> >> Charles R Harris <charlesr.harris <at> gmail.com> writes: >> [clip] >> > * Did you notice this line on the requirements page? "Having your >> > first pull request merged before the GSoC application deadline (May >> > 3) >> > is required for your application to be accepted." >> > >> > Where is that last requirement? It seems out of line to me. >> > Arink now has a pull request, but it looks intrusive enough >> > and needs enough work that I don't think we can just put it in. >> >> Well, we wrote so here: >> >> http://projects.scipy.org/scipy/wiki/SummerofCodeIdeas >> >> but that's maybe just a mistake -- PSF states exactly the opposite: >> >> http://wiki.python.org/moin/SummerOfCode/ApplicationTemplate2013 > > > It wasn't a mistake - the part of a PR process that is most interesting > in the context of evaluating GSoC applications is the dialogue and how the > submitter deals with feedback. > > I forgot to add on that page (although I think it was in one of my > emails) that the patch shouldn't be completely trivial - fixing a typo > doesn't really tell us all that much. But in this case Chuck's suggestion on > the PR of how to get something merged looks fine. >
My feeling is that learning to work with the community is part of the process after acceptance and one of the reasons there are mentors. You might get some bad choices skipping the submission/acceptance bit, but you might also close the door on people who are new to the whole thing. Ideally, the applicants would already have involved themselves with the community, practically that may often not be ths case.
You may be right in all of that, but since there's a good chance that there are more applicants than slots I'd rather not make those bad choices if they're acceptable.
acceptable --> avoidable
Right now we have three solid proposals, from Arink, Blake and Surya.
If
we're lucky we'll get three slots, but if not then we'll have a tough choice to make.
The application deadline is tomorrow, so now is the time for final tweaks to the proposals. After that of course the plan can still be worked out more, but it can't be edited on Melange anymore.
Terri can still make it editable on Melange if necessary.
Arink, you still have work to do for a PR.
Chuck.
_______________________________________________ NumPy-Discussion mailing list NumPy-Discussion@scipy.org http://mail.scipy.org/mailman/listinfo/numpy-discussion
-- Arink Computer Science and Engineering Indian Institute of Technology Ropar www.arinkverma.in
-- Arink Computer Science and Engineering Indian Institute of Technology Ropar www.arinkverma.in