Mailman 3 December 2003 - Python-checkins

python/dist/src/Misc NEWS,1.831.4.80,1.831.4.81
by tim_one＠users.sourceforge.net Dec. 1, 2003

Dec. 1, 2003

Update of /cvsroot/python/python/dist/src/Misc In directory sc8-pr-cvs1:/tmp/cvs-serv8447/Misc Modified Files: Tag: release23-maint NEWS Log Message: Py_Finalize(): disabled the second call of cyclic gc, and added extensive comments about why both calls to cyclic gc here can cause problems. Already fixed on the trunk. Since the calls were introduced in 2.3, that's the end of it. Index: NEWS =================================================================== RCS file: /cvsroot/python/python/dist/src/Misc/NEWS,v retrieving revision 1.831.4.80 retrieving revision 1.831.4.81 diff -C2 -d -r1.831.4.80 -r1.831.4.81 *** NEWS 1 Dec 2003 21:04:02 -0000 1.831.4.80 --- NEWS 1 Dec 2003 22:13:11 -0000 1.831.4.81 *************** *** 34,37 **** --- 34,47 ---- This has been repaired. + - At Python shutdown time (Py_Finalize()), 2.3 called cyclic garbage + collection twice, both before and after tearing down modules. The + call after tearing down modules has been disabled, because too much + of Python has been torn down then for __del__ methods and weakref + callbacks to execute sanely. The most common symptom was a sequence + of uninformative messages on stderr when Python shut down, produced + by threads trying to raise exceptions, but unable to report the nature + of their problems because too much of the sys module had already been + destroyed. + - Patch #820195: object.__contains__() now returns True or False instead of 1 or 0.

1 0

python/dist/src/Python pythonrun.c, 2.195.6.3, 2.195.6.4
by tim_one＠users.sourceforge.net Dec. 1, 2003

Dec. 1, 2003

Update of /cvsroot/python/python/dist/src/Python In directory sc8-pr-cvs1:/tmp/cvs-serv8447/Python Modified Files: Tag: release23-maint pythonrun.c Log Message: Py_Finalize(): disabled the second call of cyclic gc, and added extensive comments about why both calls to cyclic gc here can cause problems. Already fixed on the trunk. Since the calls were introduced in 2.3, that's the end of it. Index: pythonrun.c =================================================================== RCS file: /cvsroot/python/python/dist/src/Python/pythonrun.c,v retrieving revision 2.195.6.3 retrieving revision 2.195.6.4 diff -C2 -d -r2.195.6.3 -r2.195.6.4 *** pythonrun.c 13 Nov 2003 07:42:13 -0000 2.195.6.3 --- pythonrun.c 1 Dec 2003 22:13:12 -0000 2.195.6.4 *************** *** 333,337 **** /* Collect garbage. This may call finalizers; it's nice to call these ! before all modules are destroyed. */ PyGC_Collect(); --- 333,347 ---- /* Collect garbage. This may call finalizers; it's nice to call these ! * before all modules are destroyed. ! * XXX If a __del__ or weakref callback is triggered here, and tries to ! * XXX import a module, bad things can happen, because Python no ! * XXX longer believes it's initialized. ! * XXX Fatal Python error: Interpreter not initialized (version mismatch?) ! * XXX is easy to provoke that way. I've also seen, e.g., ! * XXX Exception exceptions.ImportError: 'No module named sha' ! * XXX in <function callback at 0x008F5718> ignored ! * XXX but I'm unclear on exactly how that one happens. In any case, ! * XXX I haven't seen a real-life report of either of these. ! */ PyGC_Collect(); *************** *** 340,345 **** /* Collect final garbage. This disposes of cycles created by ! new-style class definitions, for example. */ PyGC_Collect(); /* Destroy the database used by _PyImport_{Fixup,Find}Extension */ --- 350,370 ---- /* Collect final garbage. This disposes of cycles created by ! * new-style class definitions, for example. ! * XXX This is disabled because it caused too many problems. If ! * XXX a __del__ or weakref callback triggers here, Python code has ! * XXX a hard time running, because even the sys module has been ! * XXX cleared out (sys.stdout is gone, sys.excepthook is gone, etc). ! * XXX One symptom is a sequence of information-free messages ! * XXX coming from threads (if a __del__ or callback is invoked, ! * XXX other threads can execute too, and any exception they encounter ! * XXX triggers a comedy of errors as subsystem after subsystem ! * XXX fails to find what it *expects* to find in sys to help report ! * XXX the exception and consequent unexpected failures). I've also ! * XXX seen segfaults then, after adding print statements to the ! * XXX Python code getting called. ! */ ! #if 0 PyGC_Collect(); + #endif /* Destroy the database used by _PyImport_{Fixup,Find}Extension */

1 0

python/dist/src/Python pythonrun.c,2.201,2.202
by tim_one＠users.sourceforge.net Dec. 1, 2003

Dec. 1, 2003

Update of /cvsroot/python/python/dist/src/Python In directory sc8-pr-cvs1:/tmp/cvs-serv32594/Python Modified Files: pythonrun.c Log Message: Py_Finalize(): disabled the second call of cyclic gc, and added extensive comments about why both calls to cyclic gc here can cause problems. I'll backport to 2.3 maint. Since the calls were introduced in 2.3, that will be the end of it. Index: pythonrun.c =================================================================== RCS file: /cvsroot/python/python/dist/src/Python/pythonrun.c,v retrieving revision 2.201 retrieving revision 2.202 diff -C2 -d -r2.201 -r2.202 *** pythonrun.c 20 Nov 2003 01:44:58 -0000 2.201 --- pythonrun.c 1 Dec 2003 21:35:27 -0000 2.202 *************** *** 330,334 **** /* Collect garbage. This may call finalizers; it's nice to call these ! before all modules are destroyed. */ PyGC_Collect(); --- 330,344 ---- /* Collect garbage. This may call finalizers; it's nice to call these ! * before all modules are destroyed. ! * XXX If a __del__ or weakref callback is triggered here, and tries to ! * XXX import a module, bad things can happen, because Python no ! * XXX longer believes it's initialized. ! * XXX Fatal Python error: Interpreter not initialized (version mismatch?) ! * XXX is easy to provoke that way. I've also seen, e.g., ! * XXX Exception exceptions.ImportError: 'No module named sha' ! * XXX in <function callback at 0x008F5718> ignored ! * XXX but I'm unclear on exactly how that one happens. In any case, ! * XXX I haven't seen a real-life report of either of these. ! */ PyGC_Collect(); *************** *** 337,342 **** /* Collect final garbage. This disposes of cycles created by ! new-style class definitions, for example. */ PyGC_Collect(); /* Destroy the database used by _PyImport_{Fixup,Find}Extension */ --- 347,367 ---- /* Collect final garbage. This disposes of cycles created by ! * new-style class definitions, for example. ! * XXX This is disabled because it caused too many problems. If ! * XXX a __del__ or weakref callback triggers here, Python code has ! * XXX a hard time running, because even the sys module has been ! * XXX cleared out (sys.stdout is gone, sys.excepthook is gone, etc). ! * XXX One symptom is a sequence of information-free messages ! * XXX coming from threads (if a __del__ or callback is invoked, ! * XXX other threads can execute too, and any exception they encounter ! * XXX triggers a comedy of errors as subsystem after subsystem ! * XXX fails to find what it *expects* to find in sys to help report ! * XXX the exception and consequent unexpected failures). I've also ! * XXX seen segfaults then, after adding print statements to the ! * XXX Python code getting called. ! */ ! #if 0 PyGC_Collect(); + #endif /* Destroy the database used by _PyImport_{Fixup,Find}Extension */

1 0

python/dist/src/Misc NEWS,1.904,1.905
by tim_one＠users.sourceforge.net Dec. 1, 2003

Dec. 1, 2003

Update of /cvsroot/python/python/dist/src/Misc In directory sc8-pr-cvs1:/tmp/cvs-serv32594/Misc Modified Files: NEWS Log Message: Py_Finalize(): disabled the second call of cyclic gc, and added extensive comments about why both calls to cyclic gc here can cause problems. I'll backport to 2.3 maint. Since the calls were introduced in 2.3, that will be the end of it. Index: NEWS =================================================================== RCS file: /cvsroot/python/python/dist/src/Misc/NEWS,v retrieving revision 1.904 retrieving revision 1.905 diff -C2 -d -r1.904 -r1.905 *** NEWS 1 Dec 2003 13:18:38 -0000 1.904 --- NEWS 1 Dec 2003 21:35:25 -0000 1.905 *************** *** 13,16 **** --- 13,26 ---- ----------------- + - At Python shutdown time (Py_Finalize()), 2.3 called cyclic garbage + collection twice, both before and after tearing down modules. The + call after tearing down modules has been disabled, because too much + of Python has been torn down then for __del__ methods and weakref + callbacks to execute sanely. The most common symptom was a sequence + of uninformative messages on stderr when Python shut down, produced + by threads trying to raise exceptions, but unable to report the nature + of their problems because too much of the sys module had already been + destroyed. + - Removed FutureWarnings related to hex/oct literals and conversions and left shifts. (Thanks to Kalle Svensson for SF patch 849227.)

1 0

python/dist/src/Lib/lib-tk tkFileDialog.py, 1.11, 1.12
by loewis＠users.sourceforge.net Dec. 1, 2003

Dec. 1, 2003

Update of /cvsroot/python/python/dist/src/Lib/lib-tk In directory sc8-pr-cvs1:/tmp/cvs-serv27027/Lib/lib-tk Modified Files: tkFileDialog.py Log Message: Convert path objects to strings in askdirectory. Fixes #852314. Backported to 2.3. Index: tkFileDialog.py =================================================================== RCS file: /cvsroot/python/python/dist/src/Lib/lib-tk/tkFileDialog.py,v retrieving revision 1.11 retrieving revision 1.12 diff -C2 -d -r1.11 -r1.12 *** tkFileDialog.py 15 Jun 2003 19:08:57 -0000 1.11 --- tkFileDialog.py 1 Dec 2003 21:04:22 -0000 1.12 *************** *** 106,109 **** --- 106,115 ---- def _fixresult(self, widget, result): if result: + # convert Tcl path objects to strings + try: + result = result.string + except AttributeError: + # it already is a string + pass # keep directory until next time self.options["initialdir"] = result

1 0

python/dist/src/Misc NEWS,1.831.4.79,1.831.4.80
by loewis＠users.sourceforge.net Dec. 1, 2003

Dec. 1, 2003

Update of /cvsroot/python/python/dist/src/Misc In directory sc8-pr-cvs1:/tmp/cvs-serv26885/Misc Modified Files: Tag: release23-maint NEWS Log Message: Convert path objects to strings in askdirectory. Fixes #852314. Index: NEWS =================================================================== RCS file: /cvsroot/python/python/dist/src/Misc/NEWS,v retrieving revision 1.831.4.79 retrieving revision 1.831.4.80 diff -C2 -d -r1.831.4.79 -r1.831.4.80 *** NEWS 30 Nov 2003 22:10:54 -0000 1.831.4.79 --- NEWS 1 Dec 2003 21:04:02 -0000 1.831.4.80 *************** *** 40,43 **** --- 40,45 ---- ----------------- + - Bug #852314: Fix return type of tkFileDialog.askdirectory on Unix. + - Bug #834676: Fix crashes when normalizing Hangul syllables.

1 0

python/dist/src/Lib/lib-tk tkFileDialog.py, 1.11, 1.11.8.1
by loewis＠users.sourceforge.net Dec. 1, 2003

Dec. 1, 2003

Update of /cvsroot/python/python/dist/src/Lib/lib-tk In directory sc8-pr-cvs1:/tmp/cvs-serv26885/Lib/lib-tk Modified Files: Tag: release23-maint tkFileDialog.py Log Message: Convert path objects to strings in askdirectory. Fixes #852314. Index: tkFileDialog.py =================================================================== RCS file: /cvsroot/python/python/dist/src/Lib/lib-tk/tkFileDialog.py,v retrieving revision 1.11 retrieving revision 1.11.8.1 diff -C2 -d -r1.11 -r1.11.8.1 *** tkFileDialog.py 15 Jun 2003 19:08:57 -0000 1.11 --- tkFileDialog.py 1 Dec 2003 21:04:01 -0000 1.11.8.1 *************** *** 106,109 **** --- 106,115 ---- def _fixresult(self, widget, result): if result: + # convert Tcl path objects to strings + try: + result = result.string + except AttributeError: + # it already is a string + pass # keep directory until next time self.options["initialdir"] = result

1 0

python/dist/src/Lib pyclbr.py, 1.30, 1.31 inspect.py, 1.48, 1.49
by rhettinger＠users.sourceforge.net Dec. 1, 2003

Dec. 1, 2003

Update of /cvsroot/python/python/dist/src/Lib In directory sc8-pr-cvs1:/tmp/cvs-serv15634 Modified Files: pyclbr.py inspect.py Log Message: Apply extract functions instead of lambda. Index: pyclbr.py =================================================================== RCS file: /cvsroot/python/python/dist/src/Lib/pyclbr.py,v retrieving revision 1.30 retrieving revision 1.31 diff -C2 -d -r1.30 -r1.31 *** pyclbr.py 3 Dec 2002 08:14:35 -0000 1.30 --- pyclbr.py 1 Dec 2003 20:12:14 -0000 1.31 *************** *** 44,47 **** --- 44,48 ---- import tokenize # Python tokenizer from token import NAME, DEDENT, NEWLINE + from operator import itemgetter __all__ = ["readmodule", "readmodule_ex", "Class", "Function"] *************** *** 327,332 **** if isinstance(obj, Class): print "class", obj.name, obj.super, obj.lineno ! methods = obj.methods.items() ! methods.sort(lambda a, b: cmp(a[1], b[1])) for name, lineno in methods: if name != "__path__": --- 328,332 ---- if isinstance(obj, Class): print "class", obj.name, obj.super, obj.lineno ! methods = list.sorted(obj.methods.iteritems(), key=itemgetter(1)) for name, lineno in methods: if name != "__path__": Index: inspect.py =================================================================== RCS file: /cvsroot/python/python/dist/src/Lib/inspect.py,v retrieving revision 1.48 retrieving revision 1.49 diff -C2 -d -r1.48 -r1.49 *** inspect.py 16 Oct 2003 05:53:16 -0000 1.48 --- inspect.py 1 Dec 2003 20:12:15 -0000 1.49 *************** *** 30,33 **** --- 30,34 ---- import sys, os, types, string, re, dis, imp, tokenize, linecache + from operator import attrgetter # ----------------------------------------------------------- type-checking *************** *** 554,558 **** """Recursive helper function for getclasstree().""" results = [] ! classes.sort(key=lambda c: c.__name__) for c in classes: results.append((c, c.__bases__)) --- 555,559 ---- """Recursive helper function for getclasstree().""" results = [] ! classes.sort(key=attrgetter('__name__')) for c in classes: results.append((c, c.__bases__))

1 0

python/dist/src/Lib/encodings bz2_codec.py, 1.3, 1.4
by rhettinger＠users.sourceforge.net Dec. 1, 2003

Dec. 1, 2003

Update of /cvsroot/python/python/dist/src/Lib/encodings In directory sc8-pr-cvs1:/tmp/cvs-serv30883 Modified Files: bz2_codec.py Log Message: Revert previous change. MAL preferred the old version. Index: bz2_codec.py =================================================================== RCS file: /cvsroot/python/python/dist/src/Lib/encodings/bz2_codec.py,v retrieving revision 1.3 retrieving revision 1.4 diff -C2 -d -r1.3 -r1.4 *** bz2_codec.py 1 Dec 2003 10:41:02 -0000 1.3 --- bz2_codec.py 1 Dec 2003 13:26:46 -0000 1.4 *************** *** 9,27 **** """ import codecs ! import bz2 ! def encode(input, errors='strict'): assert errors == 'strict' output = bz2.compress(input) return (output, len(input)) ! def decode(input, errors='strict'): assert errors == 'strict' output = bz2.decompress(input) return (output, len(input)) ### encodings module API def getregentry(): ! return (encode, decode, codecs.StreamReader, codecs.StreamWriter) --- 9,64 ---- """ import codecs ! import bz2 # this codec needs the optional bz2 module ! ! ### Codec APIs ! ! def bz2_encode(input,errors='strict'): ! ! """ Encodes the object input and returns a tuple (output ! object, length consumed). ! ! errors defines the error handling to apply. It defaults to ! 'strict' handling which is the only currently supported ! error handling for this codec. ! ! """ assert errors == 'strict' output = bz2.compress(input) return (output, len(input)) ! def bz2_decode(input,errors='strict'): ! ! """ Decodes the object input and returns a tuple (output ! object, length consumed). ! ! input must be an object which provides the bf_getreadbuf ! buffer slot. Python strings, buffer objects and memory ! mapped files are examples of objects providing this slot. ! ! errors defines the error handling to apply. It defaults to ! 'strict' handling which is the only currently supported ! error handling for this codec. ! ! """ assert errors == 'strict' output = bz2.decompress(input) return (output, len(input)) + class Codec(codecs.Codec): + + def encode(self, input, errors='strict'): + return bz2_encode(input, errors) + def decode(self, input, errors='strict'): + return bz2_decode(input, errors) + + class StreamWriter(Codec,codecs.StreamWriter): + pass + + class StreamReader(Codec,codecs.StreamReader): + pass + ### encodings module API def getregentry(): ! return (bz2_encode,bz2_decode,StreamReader,StreamWriter)

1 0

python/dist/src/Lib/test test_operator.py, 1.11, 1.12
by rhettinger＠users.sourceforge.net Dec. 1, 2003

Dec. 1, 2003

Update of /cvsroot/python/python/dist/src/Lib/test In directory sc8-pr-cvs1:/tmp/cvs-serv29352/Lib/test Modified Files: test_operator.py Log Message: As discussed on python-dev, added two extractor functions to the operator module. Index: test_operator.py =================================================================== RCS file: /cvsroot/python/python/dist/src/Lib/test/test_operator.py,v retrieving revision 1.11 retrieving revision 1.12 diff -C2 -d -r1.11 -r1.12 *** test_operator.py 18 Jan 2003 23:22:20 -0000 1.11 --- test_operator.py 1 Dec 2003 13:18:39 -0000 1.12 *************** *** 228,231 **** --- 228,270 ---- self.failUnless(operator.is_not(a,c)) + def test_attrgetter(self): + class A: + pass + a = A() + a.name = 'arthur' + f = operator.attrgetter('name') + self.assertEqual(f(a), 'arthur') + f = operator.attrgetter('rank') + self.assertRaises(AttributeError, f, a) + f = operator.attrgetter(2) + self.assertRaises(TypeError, f, a) + self.assertRaises(TypeError, operator.attrgetter) + self.assertRaises(TypeError, operator.attrgetter, 1, 2) + + def test_itemgetter(self): + a = 'ABCDE' + f = operator.itemgetter(2) + self.assertEqual(f(a), 'C') + f = operator.itemgetter(10) + self.assertRaises(IndexError, f, a) + + f = operator.itemgetter('name') + self.assertRaises(TypeError, f, a) + self.assertRaises(TypeError, operator.itemgetter) + self.assertRaises(TypeError, operator.itemgetter, 1, 2) + + d = dict(key='val') + f = operator.itemgetter('key') + self.assertEqual(f(d), 'val') + f = operator.itemgetter('nonkey') + self.assertRaises(KeyError, f, d) + + # example used in the docs + inventory = [('apple', 3), ('banana', 2), ('pear', 5), ('orange', 1)] + getcount = operator.itemgetter(1) + self.assertEqual(map(getcount, inventory), [3, 2, 5, 1]) + self.assertEqual(list.sorted(inventory, key=getcount), + [('orange', 1), ('banana', 2), ('apple', 3), ('pear', 5)]) + def test_main(): test_support.run_unittest(OperatorTestCase)

1 0