Mailman 3 September 2003 - Python-checkins

python/dist/src/Objects unicodeobject.c, 2.197, 2.198
by tim_one＠users.sourceforge.net 16 Sep '03

16 Sep '03

Update of /cvsroot/python/python/dist/src/Objects In directory sc8-pr-cvs1:/tmp/cvs-serv17421/Objects Modified Files: unicodeobject.c Log Message: On c.l.py, Martin v. Löwis said that Py_UNICODE could be of a signed type, so fiddle Jeremy's fix to live with that. Also added more comments. Bugfix candidate (this bug is in all versions of Python, at least since 2.1). Index: unicodeobject.c =================================================================== RCS file: /cvsroot/python/python/dist/src/Objects/unicodeobject.c,v retrieving revision 2.197 retrieving revision 2.198 diff -C2 -d -r2.197 -r2.198 *** unicodeobject.c 16 Sep 2003 19:41:39 -0000 2.197 --- unicodeobject.c 16 Sep 2003 20:30:58 -0000 2.198 *************** *** 1,3 **** ! /* Unicode implementation based on original code by Fredrik Lundh, --- 1,3 ---- ! /* Unicode implementation based on original code by Fredrik Lundh, *************** *** 54,58 **** The implementation will keep allocated Unicode memory intact for [...1534 lines suppressed...] } --- 6333,6337 ---- if (dict == NULL) { PyErr_SetString(PyExc_TypeError, ! "format requires a mapping"); goto onError; } *************** *** 6571,6575 **** "unsupported format character '%c' (0x%x) " "at index %i", ! (31<=c && c<=126) ? (char)c : '?', (int)c, (int)(fmt -1 - PyUnicode_AS_UNICODE(uformat))); --- 6579,6583 ---- "unsupported format character '%c' (0x%x) " "at index %i", ! (31<=c && c<=126) ? (char)c : '?', (int)c, (int)(fmt -1 - PyUnicode_AS_UNICODE(uformat)));

1 0

python/dist/src/Misc NEWS,1.831.4.43,1.831.4.44
by jhylton＠users.sourceforge.net 16 Sep '03

16 Sep '03

Update of /cvsroot/python/python/dist/src/Misc In directory sc8-pr-cvs1:/tmp/cvs-serv17511/Misc Modified Files: Tag: release23-maint NEWS Log Message: Backport: Double-fix of crash in Unicode freelist handling. Index: NEWS =================================================================== RCS file: /cvsroot/python/python/dist/src/Misc/NEWS,v retrieving revision 1.831.4.43 retrieving revision 1.831.4.44 diff -C2 -d -r1.831.4.43 -r1.831.4.44 *** NEWS 16 Sep 2003 07:13:56 -0000 1.831.4.43 --- NEWS 16 Sep 2003 20:30:01 -0000 1.831.4.44 *************** *** 13,16 **** --- 13,21 ---- ----------------- + - Fixed a bug in the cache of length-one Unicode strings that could + lead to a seg fault. The specific problem occurred when an earlier, + non-fatal error left an uninitialized Unicode object in the + freelist. + - Fixed a leak in class objects defining a comparison but not a hash function.

1 0

[Python-checkins] python/dist/src/Objects unicodeobject.c, 2.190.6.5, 2.190.6.6
by jhylton＠users.sourceforge.net 16 Sep '03

16 Sep '03

Update of /cvsroot/python/python/dist/src/Objects In directory sc8-pr-cvs1:/tmp/cvs-serv17511/Objects Modified Files: Tag: release23-maint unicodeobject.c Log Message: Backport: Double-fix of crash in Unicode freelist handling. Index: unicodeobject.c =================================================================== RCS file: /cvsroot/python/python/dist/src/Objects/unicodeobject.c,v retrieving revision 2.190.6.5 retrieving revision 2.190.6.6 diff -C2 -d -r2.190.6.5 -r2.190.6.6 *** unicodeobject.c 27 Aug 2003 05:08:19 -0000 2.190.6.5 --- unicodeobject.c 16 Sep 2003 20:30:03 -0000 2.190.6.6 *************** *** 133,137 **** if (unicode == unicode_empty || (unicode->length == 1 && ! unicode->str[0] < 256 && unicode_latin1[unicode->str[0]] == unicode)) { PyErr_SetString(PyExc_SystemError, --- 133,137 ---- if (unicode == unicode_empty || (unicode->length == 1 && ! unicode->str[0] < 256U && unicode_latin1[unicode->str[0]] == unicode)) { PyErr_SetString(PyExc_SystemError, *************** *** 212,215 **** --- 212,216 ---- goto onError; } + unicode->str[0] = 0; unicode->str[length] = 0; unicode->length = length;

1 0

python/dist/src/Objects unicodeobject.c, 2.196, 2.197
by jhylton＠users.sourceforge.net 16 Sep '03

16 Sep '03

Update of /cvsroot/python/python/dist/src/Objects In directory sc8-pr-cvs1:/tmp/cvs-serv22624/Objects Modified Files: unicodeobject.c Log Message: Double-fix of crash in Unicode freelist handling. If a length-1 Unicode string was in the freelist and it was uninitialized or pointed to a very large (magnitude) negative number, the check unicode_latin1[unicode->str[0]] == unicode could cause a segmentation violation, e.g. unicode->str[0] is 0xcbcbcbcb. Fix this in two ways: 1. Change guard befor unicode_latin1[] to test against 256U. If I understand correctly, the unsigned long used to store UCS4 on my box was getting converted to a signed long to compare with the signed constant 256. 2. Change _PyUnicode_New() to make sure the first element of str is always initialized to zero. There are several places in the code where the caller can exit with an error before initializing any of str, which would leave junk in str[0]. Also, silence a compiler warning on pointer vs. int arithmetic. Bug fix candidate. Index: unicodeobject.c =================================================================== RCS file: /cvsroot/python/python/dist/src/Objects/unicodeobject.c,v retrieving revision 2.196 retrieving revision 2.197 diff -C2 -d -r2.196 -r2.197 *** unicodeobject.c 16 Sep 2003 03:41:45 -0000 2.196 --- unicodeobject.c 16 Sep 2003 19:41:39 -0000 2.197 *************** *** 133,137 **** if (unicode == unicode_empty || (unicode->length == 1 && ! unicode->str[0] < 256 && unicode_latin1[unicode->str[0]] == unicode)) { PyErr_SetString(PyExc_SystemError, --- 133,138 ---- if (unicode == unicode_empty || (unicode->length == 1 && ! /* XXX Is unicode->str[] always unsigned? */ ! unicode->str[0] < 256U && unicode_latin1[unicode->str[0]] == unicode)) { PyErr_SetString(PyExc_SystemError, *************** *** 212,215 **** --- 213,220 ---- goto onError; } + /* Initialize the first element to guard against cases where + the caller fails before initializing str. + */ + unicode->str[0] = 0; unicode->str[length] = 0; unicode->length = length; *************** *** 2528,2532 **** startinpos = s-starts; endinpos = startinpos + 1; ! outpos = p-PyUnicode_AS_UNICODE(v); if (unicode_decode_call_errorhandler( errors, &errorHandler, --- 2533,2537 ---- startinpos = s-starts; endinpos = startinpos + 1; ! outpos = p - (Py_UNICODE *)PyUnicode_AS_UNICODE(v); if (unicode_decode_call_errorhandler( errors, &errorHandler,

1 0

python/dist/src/Misc NEWS,1.855,1.856
by jhylton＠users.sourceforge.net 16 Sep '03

16 Sep '03

Update of /cvsroot/python/python/dist/src/Misc In directory sc8-pr-cvs1:/tmp/cvs-serv22624/Misc Modified Files: NEWS Log Message: Double-fix of crash in Unicode freelist handling. If a length-1 Unicode string was in the freelist and it was uninitialized or pointed to a very large (magnitude) negative number, the check unicode_latin1[unicode->str[0]] == unicode could cause a segmentation violation, e.g. unicode->str[0] is 0xcbcbcbcb. Fix this in two ways: 1. Change guard befor unicode_latin1[] to test against 256U. If I understand correctly, the unsigned long used to store UCS4 on my box was getting converted to a signed long to compare with the signed constant 256. 2. Change _PyUnicode_New() to make sure the first element of str is always initialized to zero. There are several places in the code where the caller can exit with an error before initializing any of str, which would leave junk in str[0]. Also, silence a compiler warning on pointer vs. int arithmetic. Bug fix candidate. Index: NEWS =================================================================== RCS file: /cvsroot/python/python/dist/src/Misc/NEWS,v retrieving revision 1.855 retrieving revision 1.856 diff -C2 -d -r1.855 -r1.856 *** NEWS 12 Sep 2003 06:33:36 -0000 1.855 --- NEWS 16 Sep 2003 19:41:38 -0000 1.856 *************** *** 13,16 **** --- 13,21 ---- ----------------- + - Fixed a bug in the cache of length-one Unicode strings that could + lead to a seg fault. The specific problem occurred when an earlier, + non-fatal error left an uninitialized Unicode object in the + freelist. + - The % formatting operator now supports '%F' which is equivalent to '%f'. This has always been documented but never implemented.

1 0

python/nondist/peps pep-0321.txt, NONE, 1.1 pep-0000.txt, 1.251, 1.252
by akuchling＠users.sourceforge.net 16 Sep '03

16 Sep '03

Update of /cvsroot/python/python/nondist/peps In directory sc8-pr-cvs1:/tmp/cvs-serv7859 Modified Files: pep-0000.txt Added Files: pep-0321.txt Log Message: Add PEP 321: Date/time parsing --- NEW FILE: pep-0321.txt --- PEP: 321 Title: Date/Time Parsing and Formatting Version: $Revision: 1.1 $ Last-Modified: $Date: 2003/09/16 12:07:56 $ Author: A.M. Kuchling <amk(a)amk.ca> Status: Draft Type: Standards Track Content-Type: text/x-rst Python-Version: 2.4 Created: 16-Sep-2003 Post-History: Abstract ======== Python 2.3 added a number of simple date and time types in the ``datetime`` module. There's no support for parsing strings in various formats and returning a corresponding instance of one of the types. This PEP proposes adding a family of predefined parsing function for several commonly used date and time formats, and a facility for generic parsing. The types provided by the ``datetime`` module all have ``.isoformat()`` and ``.ctime()`` methods that return string representations of a time, and the ``.strftime()`` method can be used to construct new formats. There are a number of additional commonly-used formats that would be useful to have as part of the standard library; this PEP also suggests how to add them. Input Formats ======================= Useful formats to support include `ISO8601`_, `RFC2822`_, `ctime`_, and some that are commonly written by humans such as the American "MM/DD/YYYY", the European "YYYY/MM/DD", and variants such as "DD-Month-YYYY". XXX The Perl `ParseDate.pm`_ module supports many different input formats, both absolute and relative. Should we try to support them all? Options: 1) Add functions to the ``datetime`` module:: import datetime d = datetime.parse_iso8601("2003-09-15T10:34:54") 2) Add class methods to the various types. There are already various class methods such as ``.now()``, so this would be pretty natural.:: import datetime d = datetime.date.parse_iso8601("2003-09-15T10:34:54") 3) Add a separate module (possible names: date, date_parse, parse_date) or subpackage (possible names: datetime.parser) containing parsing functions:: import datetime d = datetime.parser.parse_iso8601("2003-09-15T10:34:54") Unresolved questions: * Naming convention to use. * What exception to raise on errors? ValueError, or a specialized exception? * Should you know what type you're expecting, or should the parsing figure it out? (e.g. ``parse_iso8601("yyyy-mm-dd")`` returns a ``date`` instance, but parsing "yyyy-mm-ddThh:mm:ss" returns a ``datetime``.) Should there be an option to signal an error if a time is provided where none is expected, or if no time is provided? * Anything special required for I18N? For time zones? Generic Input Parsing ======================= Is a strptime() implementation that returns ``datetime`` types sufficient? XXX if yes, describe strptime here. Can the existing pure-Python implementation be easily retargeted? Output Formats ======================= Not all input formats need to be supported as output formats, because it's pretty trivial to get the ``strftime()`` argument right for simple things such as YYYY/MM/DD. Only complicated formats need to be supported; RFC2822 is currently the only one I can think of. Options: 1) Provide predefined format strings, so you could write this:: import datetime d = datetime.datetime(...) print d.strftime(d.RFC2822_FORMAT) # or datetime.RFC2822_FORMAT? 2) Provide new methods on all the objects:: d = datetime.datetime(...) print d.rfc822_time() References ========== .. _RFC2822: http://rfc2822.x42.com .. _ISO8601: http://www.cl.cam.ac.uk/~mgk25/iso-time.html .. _ParseDate.pm: http://search.cpan.org/author/MUIR/Time-modules-2003.0211/lib/Time/ParseDat… .. _ctime: http://www.opengroup.org/onlinepubs/007908799/xsh/asctime.html Other useful links: http://www.egenix.com/files/python/mxDateTime.html http://ringmaster.arc.nasa.gov/tools/time_formats.html http://www.thinkage.ca/english/gcos/expl/b/lib/0tosec.html Copyright ========= This document has been placed in the public domain. .. Local Variables: mode: indented-text indent-tabs-mode: nil sentence-end-double-space: t fill-column: 70 End: Index: pep-0000.txt =================================================================== RCS file: /cvsroot/python/python/nondist/peps/pep-0000.txt,v retrieving revision 1.251 retrieving revision 1.252 diff -C2 -d -r1.251 -r1.252 *** pep-0000.txt 7 Sep 2003 13:56:12 -0000 1.251 --- pep-0000.txt 16 Sep 2003 12:07:56 -0000 1.252 *************** *** 117,120 **** --- 117,121 ---- S 318 Function/Method Decorator Syntax Smith S 319 Python Synchronize/Asynchronize Block Pelletier + S 321 Date/Time Parsing and Formatting Kuchling S 754 IEEE 754 Floating Point Special Values Warnes *************** *** 334,337 **** --- 335,339 ---- S 319 Python Synchronize/Asynchronize Block Pelletier I 320 Python 2.4 Release Schedule Warsaw + S 321 Date/Time Parsing and Formatting Kuchling SR 666 Reject Foolish Indentation Creighton S 754 IEEE 754 Floating Point Special Values Warnes

1 0

python/dist/src/Misc NEWS,1.831.4.42,1.831.4.43
by rhettinger＠users.sourceforge.net 16 Sep '03

16 Sep '03

Update of /cvsroot/python/python/dist/src/Misc In directory sc8-pr-cvs1:/tmp/cvs-serv18632/Misc Modified Files: Tag: release23-maint NEWS Log Message: Fix leak in classobject.c. The leak surfaced on the error exit when hashing a class that does not define __hash__ but does define a comparison. Index: NEWS =================================================================== RCS file: /cvsroot/python/python/dist/src/Misc/NEWS,v retrieving revision 1.831.4.42 retrieving revision 1.831.4.43 diff -C2 -d -r1.831.4.42 -r1.831.4.43 *** NEWS 16 Sep 2003 05:29:50 -0000 1.831.4.42 --- NEWS 16 Sep 2003 07:13:56 -0000 1.831.4.43 *************** *** 13,16 **** --- 13,19 ---- ----------------- + - Fixed a leak in class objects defining a comparison but not a hash + function. + - Bug #789402, fixed memory leak when opening a file object.

1 0

python/dist/src/Objects classobject.c, 2.170, 2.170.10.1
by rhettinger＠users.sourceforge.net 16 Sep '03

16 Sep '03

Update of /cvsroot/python/python/dist/src/Objects In directory sc8-pr-cvs1:/tmp/cvs-serv18632/Objects Modified Files: Tag: release23-maint classobject.c Log Message: Fix leak in classobject.c. The leak surfaced on the error exit when hashing a class that does not define __hash__ but does define a comparison. Index: classobject.c =================================================================== RCS file: /cvsroot/python/python/dist/src/Objects/classobject.c,v retrieving revision 2.170 retrieving revision 2.170.10.1 diff -C2 -d -r2.170 -r2.170.10.1 *** classobject.c 9 Apr 2003 19:35:08 -0000 2.170 --- classobject.c 16 Sep 2003 07:13:56 -0000 2.170.10.1 *************** *** 954,957 **** --- 954,958 ---- } } + Py_XDECREF(func); PyErr_SetString(PyExc_TypeError, "unhashable instance"); return -1;

1 0

python/dist/src/Objects classobject.c, 2.170, 2.171
by rhettinger＠users.sourceforge.net 16 Sep '03

16 Sep '03

Update of /cvsroot/python/python/dist/src/Objects In directory sc8-pr-cvs1:/tmp/cvs-serv17931 Modified Files: classobject.c Log Message: Fix leak in classobject.c. The leak surfaced on the error exit when hashing a class that does not define __hash__ but does define a comparison. Index: classobject.c =================================================================== RCS file: /cvsroot/python/python/dist/src/Objects/classobject.c,v retrieving revision 2.170 retrieving revision 2.171 diff -C2 -d -r2.170 -r2.171 *** classobject.c 9 Apr 2003 19:35:08 -0000 2.170 --- classobject.c 16 Sep 2003 07:11:46 -0000 2.171 *************** *** 954,957 **** --- 954,958 ---- } } + Py_XDECREF(func); PyErr_SetString(PyExc_TypeError, "unhashable instance"); return -1;

1 0

python/dist/src/Misc NEWS,1.831.4.41,1.831.4.42
by rhettinger＠users.sourceforge.net 16 Sep '03

16 Sep '03

Update of /cvsroot/python/python/dist/src/Misc In directory sc8-pr-cvs1:/tmp/cvs-serv592/Misc Modified Files: Tag: release23-maint NEWS Log Message: Backport Neal's fix for bug #789402 -- a memory leak in fileobject.c Index: NEWS =================================================================== RCS file: /cvsroot/python/python/dist/src/Misc/NEWS,v retrieving revision 1.831.4.41 retrieving revision 1.831.4.42 diff -C2 -d -r1.831.4.41 -r1.831.4.42 *** NEWS 16 Sep 2003 04:36:32 -0000 1.831.4.41 --- NEWS 16 Sep 2003 05:29:50 -0000 1.831.4.42 *************** *** 13,16 **** --- 13,18 ---- ----------------- + - Bug #789402, fixed memory leak when opening a file object. + - Fixed a leak when new code objects are instantiated.

1 0