Mailman 3 November 2008 - Python-checkins

buildbot failure in sparc solaris10 gcc 3.0
by buildbot＠python.org 28 Nov '08

28 Nov '08

The Buildbot has detected a new failure of sparc solaris10 gcc 3.0. Full details are available at: http://www.python.org/dev/buildbot/all/sparc%20solaris10%20gcc%203.0/builds… Buildbot URL: http://www.python.org/dev/buildbot/all/ Buildslave for this Build: loewis-sun Build Reason: Build Source Stamp: [branch branches/py3k] HEAD Blamelist: amaury.forgeotdarc,benjamin.peterson BUILD FAILED: failed test Excerpt from the test logfile: 2 tests failed: test_distutils test_posix ====================================================================== FAIL: test_get_python_inc (distutils.tests.test_sysconfig.SysconfigTestCase) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home2/buildbot/slave/3.0.loewis-sun/build/Lib/distutils/tests/test_sysconfig.py", line 43, in test_get_python_inc self.assert_(os.path.isdir(inc_dir), inc_dir) AssertionError: /home2/buildbot/slave/3.0.loewis-sun/build/(a)test.getcwd/Include ====================================================================== ERROR: test_getcwd_long_pathnames (test.test_posix.PosixTester) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home2/buildbot/slave/3.0.loewis-sun/build/Lib/test/test_posix.py", line 252, in test_getcwd_long_pathnames support.rmtree(base_path) File "/home2/buildbot/slave/3.0.loewis-sun/build/Lib/test/support.py", line 98, in rmtree shutil.rmtree(path) File "/home2/buildbot/slave/3.0.loewis-sun/build/Lib/shutil.py", line 225, in rmtree onerror(os.rmdir, path, sys.exc_info()) File "/home2/buildbot/slave/3.0.loewis-sun/build/Lib/shutil.py", line 223, in rmtree os.rmdir(path) OSError: [Errno 22] Invalid argument: '/home2/buildbot/slave/3.0.loewis-sun/build/@test.getcwd/@test.getcwd' sincerely, -The Buildbot

1 0

buildbot failure in ppc Debian unstable trunk
by buildbot＠python.org 28 Nov '08

28 Nov '08

The Buildbot has detected a new failure of ppc Debian unstable trunk. Full details are available at: http://www.python.org/dev/buildbot/all/ppc%20Debian%20unstable%20trunk/buil… Buildbot URL: http://www.python.org/dev/buildbot/all/ Buildslave for this Build: klose-debian-ppc Build Reason: Build Source Stamp: [branch trunk] HEAD Blamelist: jeremy.hylton BUILD FAILED: failed test Excerpt from the test logfile: 1 test failed: test_pickletools make: *** [buildbottest] Error 1 sincerely, -The Buildbot

1 0

r67442 - in python/trunk/Lib: httplib.py xmlrpclib.py
by jeremy.hylton 28 Nov '08

28 Nov '08

Author: jeremy.hylton Date: Sat Nov 29 02:09:35 2008 New Revision: 67442 Log: Send HTTP headers and message body in a single send() call. This change addresses part of issue 4336. Change endheaders() to take an optional message_body argument that is sent along with the headers. Change xmlrpclib and httplib's other methods to use this new interface. It is more efficient to make a single send() call, which should get the entire client request into one packet (assuming it is smaller than the MTU) and will avoid the long pause for delayed ack following timeout. Also: - Add a comment about the buffer size for makefile(). - Extract _set_content_length() method and fix whitespace issues there. Modified: python/trunk/Lib/httplib.py python/trunk/Lib/xmlrpclib.py Modified: python/trunk/Lib/httplib.py ============================================================================== --- python/trunk/Lib/httplib.py (original) +++ python/trunk/Lib/httplib.py Sat Nov 29 02:09:35 2008 @@ -326,6 +326,11 @@ # See RFC 2616 sec 19.6 and RFC 1945 sec 6 for details. def __init__(self, sock, debuglevel=0, strict=0, method=None): + # The buffer size is specified as zero, because the headers of + # the response are read with readline(). If the reads were + # buffered the readline() calls could consume some of the + # response, which make be read via a recv() on the underlying + # socket. self.fp = sock.makefile('rb', 0) self.debuglevel = debuglevel self.strict = strict @@ -729,7 +734,7 @@ """ self._buffer.append(s) - def _send_output(self): + def _send_output(self, message_body=None): """Send the currently buffered request and clear the buffer. Appends an extra \\r\\n to the buffer. @@ -737,6 +742,11 @@ self._buffer.extend(("", "")) msg = "\r\n".join(self._buffer) del self._buffer[:] + # If msg and message_body are sent in a single send() call, + # it will avoid performance problems caused by the interaction + # between delayed ack and the Nagle algorithim. + if message_body is not None: + msg += message_body self.send(msg) def putrequest(self, method, url, skip_host=0, skip_accept_encoding=0): @@ -857,15 +867,20 @@ str = '%s: %s' % (header, '\r\n\t'.join(values)) self._output(str) - def endheaders(self): - """Indicate that the last header line has been sent to the server.""" + def endheaders(self, message_body=None): + """Indicate that the last header line has been sent to the server. + This method sends the request to the server. The optional + message_body argument can be used to pass message body + associated with the request. The message body will be sent in + the same packet as the message headers if possible. The + message_body should be a string. + """ if self.__state == _CS_REQ_STARTED: self.__state = _CS_REQ_SENT else: raise CannotSendHeader() - - self._send_output() + self._send_output(message_body) def request(self, method, url, body=None, headers={}): """Send a complete request to the server.""" @@ -879,6 +894,24 @@ # try one more time self._send_request(method, url, body, headers) + def _set_content_length(self, body): + # Set the content-length based on the body. + thelen = None + try: + thelen = str(len(body)) + except TypeError, te: + # If this is a file-like object, try to + # fstat its file descriptor + import os + try: + thelen = str(os.fstat(body.fileno()).st_size) + except (AttributeError, OSError): + # Don't send a length if this failed + if self.debuglevel > 0: print "Cannot stat!!" + + if thelen is not None: + self.putheader('Content-Length', thelen) + def _send_request(self, method, url, body, headers): # honour explicitly requested Host: and Accept-Encoding headers header_names = dict.fromkeys([k.lower() for k in headers]) @@ -891,27 +924,15 @@ self.putrequest(method, url, **skips) if body and ('content-length' not in header_names): - thelen=None - try: - thelen=str(len(body)) - except TypeError, te: - # If this is a file-like object, try to - # fstat its file descriptor - import os - try: - thelen = str(os.fstat(body.fileno()).st_size) - except (AttributeError, OSError): - # Don't send a length if this failed - if self.debuglevel > 0: print "Cannot stat!!" - - if thelen is not None: - self.putheader('Content-Length',thelen) + self._set_content_length(body) for hdr, value in headers.iteritems(): self.putheader(hdr, value) - self.endheaders() - - if body: - self.send(body) + if isinstance(body, str): + self.endheaders(body) + else: + self.endheaders() + if body: # when body is a file rather than a string + self.send(body) def getresponse(self): "Get the response from the server." Modified: python/trunk/Lib/xmlrpclib.py ============================================================================== --- python/trunk/Lib/xmlrpclib.py (original) +++ python/trunk/Lib/xmlrpclib.py Sat Nov 29 02:09:35 2008 @@ -1346,9 +1346,7 @@ def send_content(self, connection, request_body): connection.putheader("Content-Type", "text/xml") connection.putheader("Content-Length", str(len(request_body))) - connection.endheaders() - if request_body: - connection.send(request_body) + connection.endheaders(request_body) ## # Parse response.

1 0

buildbot failure in x86 W2k8 trunk
by buildbot＠python.org 28 Nov '08

28 Nov '08

The Buildbot has detected a new failure of x86 W2k8 trunk. Full details are available at: http://www.python.org/dev/buildbot/all/x86%20W2k8%20trunk/builds/340 Buildbot URL: http://www.python.org/dev/buildbot/all/ Buildslave for this Build: nelson-windows Build Reason: Build Source Stamp: [branch trunk] HEAD Blamelist: jeremy.hylton BUILD FAILED: failed test Excerpt from the test logfile: 1 test failed: test_bsddb3 sincerely, -The Buildbot

1 0

buildbot failure in x86 osx.5 trunk
by buildbot＠python.org 28 Nov '08

28 Nov '08

The Buildbot has detected a new failure of x86 osx.5 trunk. Full details are available at: http://www.python.org/dev/buildbot/all/x86%20osx.5%20trunk/builds/350 Buildbot URL: http://www.python.org/dev/buildbot/all/ Buildslave for this Build: heller-x86-osx5 Build Reason: Build Source Stamp: [branch trunk] HEAD Blamelist: jeremy.hylton BUILD FAILED: failed test Excerpt from the test logfile: 1 test failed: test_socket ====================================================================== ERROR: testShutdown (test.test_socket.BasicTCPTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Users/buildbot/buildarea/trunk.heller-x86-osx5/build/Lib/test/test_socket.py", line 120, in _tearDown self.fail(msg) AssertionError: [Errno 57] Socket is not connected make: *** [buildbottest] Error 1 sincerely, -The Buildbot

1 0

r67441 - python/trunk/Lib/test/test_httplib.py
by jeremy.hylton 28 Nov '08

28 Nov '08

Author: jeremy.hylton Date: Sat Nov 29 01:09:16 2008 New Revision: 67441 Log: Reflow long lines. Modified: python/trunk/Lib/test/test_httplib.py Modified: python/trunk/Lib/test/test_httplib.py ============================================================================== --- python/trunk/Lib/test/test_httplib.py (original) +++ python/trunk/Lib/test/test_httplib.py Sat Nov 29 01:09:16 2008 @@ -107,19 +107,23 @@ for hp in ("www.python.org:abc", "www.python.org:"): self.assertRaises(httplib.InvalidURL, httplib.HTTP, hp) - for hp, h, p in (("[fe80::207:e9ff:fe9b]:8000", "fe80::207:e9ff:fe9b", 8000), + for hp, h, p in (("[fe80::207:e9ff:fe9b]:8000", "fe80::207:e9ff:fe9b", + 8000), ("www.python.org:80", "www.python.org", 80), ("www.python.org", "www.python.org", 80), ("[fe80::207:e9ff:fe9b]", "fe80::207:e9ff:fe9b", 80)): http = httplib.HTTP(hp) c = http._conn - if h != c.host: self.fail("Host incorrectly parsed: %s != %s" % (h, c.host)) - if p != c.port: self.fail("Port incorrectly parsed: %s != %s" % (p, c.host)) + if h != c.host: + self.fail("Host incorrectly parsed: %s != %s" % (h, c.host)) + if p != c.port: + self.fail("Port incorrectly parsed: %s != %s" % (p, c.host)) def test_response_headers(self): # test response with multiple message headers with the same field name. text = ('HTTP/1.1 200 OK\r\n' - 'Set-Cookie: Customer="WILE_E_COYOTE"; Version="1"; Path="/acme"\r\n' + 'Set-Cookie: Customer="WILE_E_COYOTE";' + ' Version="1"; Path="/acme"\r\n' 'Set-Cookie: Part_Number="Rocket_Launcher_0001"; Version="1";' ' Path="/acme"\r\n' '\r\n' @@ -187,7 +191,8 @@ resp.close() def test_negative_content_length(self): - sock = FakeSocket('HTTP/1.1 200 OK\r\nContent-Length: -1\r\n\r\nHello\r\n') + sock = FakeSocket('HTTP/1.1 200 OK\r\n' + 'Content-Length: -1\r\n\r\nHello\r\n') resp = httplib.HTTPResponse(sock, method="GET") resp.begin() self.assertEquals(resp.read(), 'Hello\r\n')

1 0

r67440 - python/trunk/Modules/_multiprocessing/semaphore.c
by jeremy.hylton 28 Nov '08

28 Nov '08

Author: jeremy.hylton Date: Sat Nov 29 00:42:59 2008 New Revision: 67440 Log: Move definition int sval into branch of ifdef where it is used. Otherwise, you get a warning about an undefined variable. Modified: python/trunk/Modules/_multiprocessing/semaphore.c Modified: python/trunk/Modules/_multiprocessing/semaphore.c ============================================================================== --- python/trunk/Modules/_multiprocessing/semaphore.c (original) +++ python/trunk/Modules/_multiprocessing/semaphore.c Sat Nov 29 00:42:59 2008 @@ -512,7 +512,6 @@ static PyObject * semlock_iszero(SemLockObject *self) { - int sval; #if HAVE_BROKEN_SEM_GETVALUE if (sem_trywait(self->handle) < 0) { if (errno == EAGAIN) @@ -524,6 +523,7 @@ Py_RETURN_FALSE; } #else + int sval; if (SEM_GETVALUE(self->handle, &sval) < 0) return mp_SetError(NULL, MP_STANDARD_ERROR); return PyBool_FromLong((long)sval == 0);

1 0

r67439 - sandbox/trunk/2to3/README
by benjamin.peterson 28 Nov '08

28 Nov '08

Author: benjamin.peterson Date: Sat Nov 29 00:32:14 2008 New Revision: 67439 Log: how I'm licensing Modified: sandbox/trunk/2to3/README Modified: sandbox/trunk/2to3/README ============================================================================== --- sandbox/trunk/2to3/README (original) +++ sandbox/trunk/2to3/README Sat Nov 29 00:32:14 2008 @@ -249,3 +249,8 @@ licensed to the PSF under a contributor agreement. --Collin Winter + +All of my contributions are copyrighted to me and licensed to PSF under the +Python contributor agreement. + +--Benjamin Peterson

1 0

r67438 - sandbox/trunk/2to3/HACKING
by benjamin.peterson 28 Nov '08

28 Nov '08

Author: benjamin.peterson Date: Sat Nov 29 00:29:28 2008 New Revision: 67438 Log: we really need docs for fixers Modified: sandbox/trunk/2to3/HACKING Modified: sandbox/trunk/2to3/HACKING ============================================================================== --- sandbox/trunk/2to3/HACKING (original) +++ sandbox/trunk/2to3/HACKING Sat Nov 29 00:29:28 2008 @@ -30,6 +30,8 @@ * Refactor common code out of fixes/fix_*.py into fixer_util (on-going). + * Document how to write fixers. + Complex: ########

1 0

r67437 - sandbox/trunk/2to3/README
by benjamin.peterson 28 Nov '08

28 Nov '08

Author: benjamin.peterson Date: Sat Nov 29 00:28:51 2008 New Revision: 67437 Log: README updates Modified: sandbox/trunk/2to3/README Modified: sandbox/trunk/2to3/README ============================================================================== --- sandbox/trunk/2to3/README (original) +++ sandbox/trunk/2to3/README Sat Nov 29 00:28:51 2008 @@ -3,17 +3,17 @@ A refactoring tool for converting Python 2.x code to 3.0. -This is a work in progress! Bugs should be reported to -http://bugs.python.org/ under the "2to3" category. +This is a work in progress! Bugs should be reported to http://bugs.python.org/ +under the "2to3" category. General usage ============= -Run ``./2to3`` to convert stdin (``-``), files or directories given -as arguments. By default, the tool outputs a unified diff-formatted patch -on standard output and a "what was changed" summary on standard error, -but the ``-w`` option can be given to write back converted files, creating +Run ``./2to3`` to convert stdin (``-``), files or directories given as +arguments. By default, the tool outputs a unified diff-formatted patch on +standard output and a "what was changed" summary on standard error, but the +``-w`` option can be given to write back converted files, creating ``.bak``-named backup files. 2to3 must be run with at least Python 2.5. The intended path for migrating to @@ -32,10 +32,10 @@ lib2to3/pygram.py - code specific to the Python grammar example.py - example input for play.py and fix_*.py find_pattern.py - script to help determine the PATTERN for a new fix -lib2to3/Grammar.txt - Python grammar input (a copy of Python 2.5's Grammar/Grammar) +lib2to3/Grammar.txt - Python grammar input (accepts 2.x and 3.x syntax) lib2to3/Grammar.pickle - pickled grammar tables (generated file, not in subversion) lib2to3/PatternGrammar.txt - grammar for the pattern language used by patcomp.py -lib2to3PatternGrammar.pickle - pickled pattern grammar tables (generated file) +lib2to3/PatternGrammar.pickle - pickled pattern grammar tables (generated file) lib2to3/pgen2/ - Parser generator and driver ([1]_, [2]_) lib2to3/fixes/ - Individual transformations lib2to3tests/ - Test files for pytree, fixers, grammar, etc @@ -217,8 +217,8 @@ ===== .. [#1] I modified tokenize.py to yield a NL pseudo-token for backslash - continuations, so the original source can be reproduced exactly. - The modified version can be found at pgen2/tokenize.py. + continuations, so the original source can be reproduced exactly. The + modified version can be found at lib2to3/pgen2/tokenize.py. .. [#2] I developed pgen2 while I was at Elemental Security. I modified it while at Google to suit the needs of this refactoring tool. @@ -227,8 +227,8 @@ Development =========== -The HACKING file has a list of TODOs -- some simple, some complex -- that -would make good introductions for anyone new to 2to3. +The HACKING file has a list of TODOs -- some simple, some complex -- that would +make good introductions for anyone new to 2to3. Licensing

1 0