Python-checkins

Download

python-checkins@python.org

March 2015

5 participants
611 discussions

cpython: Use unsigned division and modulo for item assignment as well.
by raymond.hettinger March 1, 2015

March 1, 2015

https://hg.python.org/cpython/rev/1d25edcbb477 changeset: 94791:1d25edcbb477 user: Raymond Hettinger <python(a)rcn.com> date: Sat Feb 28 17:49:47 2015 -0800 summary: Use unsigned division and modulo for item assignment as well. files: Modules/_collectionsmodule.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/Modules/_collectionsmodule.c b/Modules/_collectionsmodule.c --- a/Modules/_collectionsmodule.c +++ b/Modules/_collectionsmodule.c @@ -780,7 +780,6 @@ b = deque->rightblock; } else { i += deque->leftindex; - assert(i >= 0); n = (Py_ssize_t)((unsigned) i / BLOCKLEN); i = (Py_ssize_t)((unsigned) i % BLOCKLEN); if (index < (Py_SIZE(deque) >> 1)) { @@ -840,14 +839,16 @@ return deque_del_item(deque, i); i += deque->leftindex; - n = i / BLOCKLEN; - i %= BLOCKLEN; + n = (Py_ssize_t)((unsigned) i / BLOCKLEN); + i = (Py_ssize_t)((unsigned) i % BLOCKLEN); if (index <= halflen) { b = deque->leftblock; while (n--) b = b->rightlink; } else { - n = (deque->leftindex + len - 1) / BLOCKLEN - n; + n = (Py_ssize_t)( + ((unsigned)(deque->leftindex + Py_SIZE(deque) - 1)) + / BLOCKLEN - n); b = deque->rightblock; while (n--) b = b->leftlink; -- Repository URL: https://hg.python.org/cpython

1 0

Jump to page: