Mailman 3 August 2018 - Python-checkins

bpo-34007: Skip traceback tests if the Program Counter is not available. (GH-9018)
by Miss Islington (bot) 31 Aug '18

31 Aug '18

https://github.com/python/cpython/commit/4da71814b327cb2ad47a01710360cd21ba… commit: 4da71814b327cb2ad47a01710360cd21ba636352 branch: 3.7 author: Miss Islington (bot) <31488909+miss-islington(a)users.noreply.github.com> committer: GitHub <noreply(a)github.com> date: 2018-08-31T18:47:20-04:00 summary: bpo-34007: Skip traceback tests if the Program Counter is not available. (GH-9018) Sometimes some versions of the shared libraries that are part of the traceback are compiled in optimised mode and the Program Counter (PC) is not present, not allowing gdb to walk the frames back. When this happens, the Python bindings of gdb raise an exception, making the test impossible to succeed. (cherry picked from commit f2ef51f8bec525b21e52988880c8a029642795ed) Co-authored-by: Pablo Galindo <Pablogsal(a)gmail.com> files: M Lib/test/test_gdb.py diff --git a/Lib/test/test_gdb.py b/Lib/test/test_gdb.py index 9e0eaea8c8f6..c2ca57a4a04f 100644 --- a/Lib/test/test_gdb.py +++ b/Lib/test/test_gdb.py @@ -206,6 +206,15 @@ def get_stack_trace(self, source=None, script=None, for line in errlines: if not line: continue + # bpo34007: Sometimes some versions of the shared libraries that + # are part of the traceback are compiled in optimised mode and the + # Program Counter (PC) is not present, not allowing gdb to walk the + # frames back. When this happens, the Python bindings of gdb raise + # an exception, making the test impossible to succeed. + if "PC not saved" in line: + raise unittest.SkipTest("gdb cannot walk the frame object" + " because the Program Counter is" + " not present") if not line.startswith(ignore_patterns): unexpected_errlines.append(line)

1 0

bpo-34007: Skip traceback tests if the Program Counter is not available. (GH-9018)
by Miss Islington (bot) 31 Aug '18

31 Aug '18

https://github.com/python/cpython/commit/5d594f3106aff6cea00234c88051427ae5… commit: 5d594f3106aff6cea00234c88051427ae511cdd8 branch: 2.7 author: Miss Islington (bot) <31488909+miss-islington(a)users.noreply.github.com> committer: GitHub <noreply(a)github.com> date: 2018-08-31T18:43:24-04:00 summary: bpo-34007: Skip traceback tests if the Program Counter is not available. (GH-9018) Sometimes some versions of the shared libraries that are part of the traceback are compiled in optimised mode and the Program Counter (PC) is not present, not allowing gdb to walk the frames back. When this happens, the Python bindings of gdb raise an exception, making the test impossible to succeed. (cherry picked from commit f2ef51f8bec525b21e52988880c8a029642795ed) Co-authored-by: Pablo Galindo <Pablogsal(a)gmail.com> files: M Lib/test/test_gdb.py diff --git a/Lib/test/test_gdb.py b/Lib/test/test_gdb.py index d49769e44edf..c45fd45735cd 100644 --- a/Lib/test/test_gdb.py +++ b/Lib/test/test_gdb.py @@ -215,6 +215,15 @@ def get_stack_trace(self, source=None, script=None, for line in errlines: if not line: continue + # bpo34007: Sometimes some versions of the shared libraries that + # are part of the traceback are compiled in optimised mode and the + # Program Counter (PC) is not present, not allowing gdb to walk the + # frames back. When this happens, the Python bindings of gdb raise + # an exception, making the test impossible to succeed. + if "PC not saved" in line: + raise unittest.SkipTest("gdb cannot walk the frame object" + " because the Program Counter is" + " not present") if not line.startswith(ignore_patterns): unexpected_errlines.append(line)

1 0

bpo-34007: Skip traceback tests if the Program Counter is not available. (GH-9018)
by Pablo Galindo 31 Aug '18

31 Aug '18

https://github.com/python/cpython/commit/f2ef51f8bec525b21e52988880c8a02964… commit: f2ef51f8bec525b21e52988880c8a029642795ed branch: master author: Pablo Galindo <Pablogsal(a)gmail.com> committer: GitHub <noreply(a)github.com> date: 2018-08-31T23:04:47+01:00 summary: bpo-34007: Skip traceback tests if the Program Counter is not available. (GH-9018) Sometimes some versions of the shared libraries that are part of the traceback are compiled in optimised mode and the Program Counter (PC) is not present, not allowing gdb to walk the frames back. When this happens, the Python bindings of gdb raise an exception, making the test impossible to succeed. files: M Lib/test/test_gdb.py diff --git a/Lib/test/test_gdb.py b/Lib/test/test_gdb.py index 9e0eaea8c8f6..c2ca57a4a04f 100644 --- a/Lib/test/test_gdb.py +++ b/Lib/test/test_gdb.py @@ -206,6 +206,15 @@ def get_stack_trace(self, source=None, script=None, for line in errlines: if not line: continue + # bpo34007: Sometimes some versions of the shared libraries that + # are part of the traceback are compiled in optimised mode and the + # Program Counter (PC) is not present, not allowing gdb to walk the + # frames back. When this happens, the Python bindings of gdb raise + # an exception, making the test impossible to succeed. + if "PC not saved" in line: + raise unittest.SkipTest("gdb cannot walk the frame object" + " because the Program Counter is" + " not present") if not line.startswith(ignore_patterns): unexpected_errlines.append(line)

1 0

bpo-34408: Prevent a null pointer dereference and resource leakage in `PyInterpreterState_New()` (GH-8767)
by Pablo Galindo 31 Aug '18

31 Aug '18

https://github.com/python/cpython/commit/95d630e2213fb0ffc197ec440efa3ae3db… commit: 95d630e2213fb0ffc197ec440efa3ae3dbb74f8d branch: master author: Pablo Galindo <Pablogsal(a)gmail.com> committer: GitHub <noreply(a)github.com> date: 2018-08-31T22:49:29+01:00 summary: bpo-34408: Prevent a null pointer dereference and resource leakage in `PyInterpreterState_New()` (GH-8767) * A pointer in `PyInterpreterState_New()` could have been `NULL` when being dereferenced. * Memory was leaked in `PyInterpreterState_New()` when taking some error-handling code path. files: A Misc/NEWS.d/next/Core and Builtins/2018-08-14-22-35-19.bpo-34408.aomWYW.rst M Python/pystate.c diff --git a/Misc/NEWS.d/next/Core and Builtins/2018-08-14-22-35-19.bpo-34408.aomWYW.rst b/Misc/NEWS.d/next/Core and Builtins/2018-08-14-22-35-19.bpo-34408.aomWYW.rst new file mode 100644 index 000000000000..aacafd0d4c27 --- /dev/null +++ b/Misc/NEWS.d/next/Core and Builtins/2018-08-14-22-35-19.bpo-34408.aomWYW.rst @@ -0,0 +1 @@ +Prevent a null pointer dereference and resource leakage in ``PyInterpreterState_New()``. diff --git a/Python/pystate.c b/Python/pystate.c index 7a4cd48077f3..7d63f4febb93 100644 --- a/Python/pystate.c +++ b/Python/pystate.c @@ -172,23 +172,27 @@ PyInterpreterState_New(void) interp->pyexitmodule = NULL; HEAD_LOCK(); - interp->next = _PyRuntime.interpreters.head; - if (_PyRuntime.interpreters.main == NULL) { - _PyRuntime.interpreters.main = interp; - } - _PyRuntime.interpreters.head = interp; if (_PyRuntime.interpreters.next_id < 0) { /* overflow or Py_Initialize() not called! */ PyErr_SetString(PyExc_RuntimeError, "failed to get an interpreter ID"); - /* XXX deallocate! */ + PyMem_RawFree(interp); interp = NULL; } else { interp->id = _PyRuntime.interpreters.next_id; _PyRuntime.interpreters.next_id += 1; + interp->next = _PyRuntime.interpreters.head; + if (_PyRuntime.interpreters.main == NULL) { + _PyRuntime.interpreters.main = interp; + } + _PyRuntime.interpreters.head = interp; } HEAD_UNLOCK(); + if (interp == NULL) { + return NULL; + } + interp->tstate_next_unique_id = 0; return interp;

1 0

Simplify vector_norm() by eliminating special cases in the main loop (GH-9006)
by Raymond Hettinger 31 Aug '18

31 Aug '18

https://github.com/python/cpython/commit/745c0f3980c56e88db6a57311fb20ea110… commit: 745c0f3980c56e88db6a57311fb20ea11005565b branch: master author: Raymond Hettinger <rhettinger(a)users.noreply.github.com> committer: GitHub <noreply(a)github.com> date: 2018-08-31T11:22:13-07:00 summary: Simplify vector_norm() by eliminating special cases in the main loop (GH-9006) The *max* value is no longer treated as a special case in the main loop. Besides making the main loop simpler and branchless, this also lets us relax the input restriction of *vec* to contain only non-negative values. files: M Modules/mathmodule.c diff --git a/Modules/mathmodule.c b/Modules/mathmodule.c index 37934f60e9c4..8015a95d2aa7 100644 --- a/Modules/mathmodule.c +++ b/Modules/mathmodule.c @@ -2032,14 +2032,14 @@ math_fmod_impl(PyObject *module, double x, double y) } /* -Given an *n* length *vec* of non-negative values -where *max* is the largest value in the vector, compute: +Given an *n* length *vec* of values and a value *max*, compute: max * sqrt(sum((x / max) ** 2 for x in vec)) -The value of the *max* variable must be present in *vec* -or should equal to 0.0 when n==0. Likewise, *max* will -be INF if an infinity is present in the vec. +The value of the *max* variable must be non-negative and +at least equal to the absolute value of the largest magnitude +entry in the vector. If n==0, then *max* should be 0.0. +If an infinity is present in the vec, *max* should be INF. The *found_nan* variable indicates whether some member of the *vec* is a NaN. @@ -2053,16 +2053,19 @@ The *csum* variable tracks the cumulative sum and *frac* tracks the cumulative fractional errors at each step. Since this variant assumes that |csum| >= |x| at each step, we establish the precondition by starting the accumulation from 1.0 which -represents an entry equal to *max*. This also provides a nice -side benefit in that it lets us skip over a *max* entry (which -is swapped into *last*) saving us one iteration through the loop. +represents the largest possible value of (x/max)**2. + +After the loop is finished, the initial 1.0 is subtracted out +for a net zero effect on the final sum. Since *csum* will be +greater than 1.0, the subtraction of 1.0 will not cause +fractional digits to be dropped from *csum*. */ static inline double vector_norm(Py_ssize_t n, double *vec, double max, int found_nan) { - double x, csum = 1.0, oldcsum, frac = 0.0, last; + double x, csum = 1.0, oldcsum, frac = 0.0; Py_ssize_t i; if (Py_IS_INFINITY(max)) { @@ -2071,27 +2074,20 @@ vector_norm(Py_ssize_t n, double *vec, double max, int found_nan) if (found_nan) { return Py_NAN; } - if (max == 0.0) { - return 0.0; + if (max == 0.0 || n == 1) { + return max; } - assert(n > 0); - last = vec[n-1]; - for (i=0 ; i < n-1 ; i++) { + for (i=0 ; i < n ; i++) { x = vec[i]; - assert(Py_IS_FINITE(x) && x >= 0.0 && x <= max); - if (x == max) { - x = last; - last = max; - } + assert(Py_IS_FINITE(x) && fabs(x) <= max); x /= max; x = x*x; - assert(csum >= x); oldcsum = csum; csum += x; + assert(csum >= x); frac += (oldcsum - csum) + x; } - assert(last == max); - return max * sqrt(csum + frac); + return max * sqrt(csum - 1.0 + frac); } #define NUM_STACK_ELEMS 16

1 0

bpo-34062: Add missing launcher argument and make behavior consistent between short and long arguments (GH-8827)
by Miss Islington (bot) 31 Aug '18

31 Aug '18

https://github.com/python/cpython/commit/5df3658f2db1585607d41c25093a2a7d2a… commit: 5df3658f2db1585607d41c25093a2a7d2a4de347 branch: 3.7 author: Miss Islington (bot) <31488909+miss-islington(a)users.noreply.github.com> committer: GitHub <noreply(a)github.com> date: 2018-08-31T11:32:22-04:00 summary: bpo-34062: Add missing launcher argument and make behavior consistent between short and long arguments (GH-8827) Added previously missing "--list" argument. Made "--list" and "--list-paths" behavior consistent with the corresponding "-0" and "-0p" arguments. (cherry picked from commit aada63b20ec64bbfc4f2fb0718fc563eedbdd36a) Co-authored-by: Brendan Gerrity <brerrity(a)gmail.com> files: A Misc/NEWS.d/next/Windows/2018-08-21-19-28-23.bpo-34062.3gxsA3.rst M PC/launcher.c diff --git a/Misc/NEWS.d/next/Windows/2018-08-21-19-28-23.bpo-34062.3gxsA3.rst b/Misc/NEWS.d/next/Windows/2018-08-21-19-28-23.bpo-34062.3gxsA3.rst new file mode 100644 index 000000000000..ca71945d8797 --- /dev/null +++ b/Misc/NEWS.d/next/Windows/2018-08-21-19-28-23.bpo-34062.3gxsA3.rst @@ -0,0 +1 @@ +Fixed the '--list' and '--list-paths' arguments for the py.exe launcher diff --git a/PC/launcher.c b/PC/launcher.c index 417dca7cf032..4a61975b3ccf 100644 --- a/PC/launcher.c +++ b/PC/launcher.c @@ -1465,7 +1465,6 @@ process(int argc, wchar_t ** argv) wchar_t * p; int rc = 0; size_t plen; - size_t slen; INSTALLED_PYTHON * ip; BOOL valid; DWORD size, attrs; @@ -1601,10 +1600,11 @@ process(int argc, wchar_t ** argv) else { p = argv[1]; plen = wcslen(p); - if (argc == 2) { - slen = wcslen(L"-0"); - if(!wcsncmp(p, L"-0", slen)) /* Starts with -0 */ - valid = show_python_list(argv); /* Check for -0 FIRST */ + if ((argc == 2) && + (!wcsncmp(p, L"-0", wcslen(L"-0")) || /* Starts with -0 or --list */ + !wcsncmp(p, L"--list", wcslen(L"--list")))) + { + valid = show_python_list(argv); /* Check for -0 or --list FIRST */ } valid = valid && (*p == L'-') && validate_version(&p[1]); if (valid) { @@ -1637,10 +1637,13 @@ installed, use -0 for available pythons", &p[1]); if (!valid) { if ((argc == 2) && (!_wcsicmp(p, L"-h") || !_wcsicmp(p, L"--help"))) show_help_text(argv); - if ((argc == 2) && (!_wcsicmp(p, L"-0") || !_wcsicmp(p, L"-0p"))) - executable = NULL; /* Info call only */ - else + if ((argc == 2) && + (!_wcsicmp(p, L"-0") || !_wcsicmp(p, L"--list") || + !_wcsicmp(p, L"-0p") || !_wcsicmp(p, L"--list-paths"))) { + executable = NULL; /* Info call only */ + } + else { /* Look for an active virtualenv */ executable = find_python_by_venv();

1 0

Add VSTS status badge to readme (GH-8958)
by Steve Dower 31 Aug '18

31 Aug '18

https://github.com/python/cpython/commit/8926707ecee0c1634935c86d366895289d… commit: 8926707ecee0c1634935c86d366895289dba4948 branch: 3.6 author: Steve Dower <steve.dower(a)microsoft.com> committer: GitHub <noreply(a)github.com> date: 2018-08-31T08:18:12-07:00 summary: Add VSTS status badge to readme (GH-8958) files: M .vsts/linux-pr.yml M README.rst diff --git a/.vsts/linux-pr.yml b/.vsts/linux-pr.yml index c8e7fd03e849..922fa81bc414 100644 --- a/.vsts/linux-pr.yml +++ b/.vsts/linux-pr.yml @@ -62,6 +62,7 @@ steps: uuid-dev xvfb displayName: 'Install dependencies' + condition: and(succeeded(), ne(variables['DocOnly'], 'true')) - script: ./configure --with-pydebug diff --git a/README.rst b/README.rst index 978b32627bb4..c9b518bcf2cb 100644 --- a/README.rst +++ b/README.rst @@ -9,6 +9,18 @@ This is Python version 3.6.6+ :alt: CPython build status on Appveyor :target: https://ci.appveyor.com/project/python/cpython/branch/3.6 +.. image:: https://python.visualstudio.com/cpython/_apis/build/status/Linux-Buildbot?b… + :alt: CPython build status on VSTS (Linux) + :target: https://python.visualstudio.com/cpython/_build/latest?definitionId=6&branch… + +.. image:: https://python.visualstudio.com/cpython/_apis/build/status/macOS-Buildbot?b… + :alt: CPython build status on VSTS (macOS) + :target: https://python.visualstudio.com/cpython/_build/latest?definitionId=5&branch… + +.. image:: https://python.visualstudio.com/cpython/_apis/build/status/Windows-Buildbot… + :alt: CPython build status on VSTS (Windows) + :target: https://python.visualstudio.com/cpython/_build/latest?definitionId=4&branch… + .. image:: https://codecov.io/gh/python/cpython/branch/3.6/graph/badge.svg :alt: CPython code coverage on Codecov :target: https://codecov.io/gh/python/cpython

1 0

Add VSTS status badge to readme (GH-8958)
by Steve Dower 31 Aug '18

31 Aug '18

https://github.com/python/cpython/commit/9668d4e6af184b6c120b37c1a3c2f74999… commit: 9668d4e6af184b6c120b37c1a3c2f74999a2c98d branch: 3.7 author: Steve Dower <steve.dower(a)microsoft.com> committer: GitHub <noreply(a)github.com> date: 2018-08-31T08:17:36-07:00 summary: Add VSTS status badge to readme (GH-8958) files: M README.rst diff --git a/README.rst b/README.rst index d4fe666519b9..b330b41abdb3 100644 --- a/README.rst +++ b/README.rst @@ -9,6 +9,18 @@ This is Python version 3.7.0+ :alt: CPython build status on Appveyor :target: https://ci.appveyor.com/project/python/cpython/branch/master +.. image:: https://python.visualstudio.com/cpython/_apis/build/status/Linux-Buildbot?b… + :alt: CPython build status on VSTS (Linux) + :target: https://python.visualstudio.com/cpython/_build/latest?definitionId=6&branch… + +.. image:: https://python.visualstudio.com/cpython/_apis/build/status/macOS-Buildbot?b… + :alt: CPython build status on VSTS (macOS) + :target: https://python.visualstudio.com/cpython/_build/latest?definitionId=5&branch… + +.. image:: https://python.visualstudio.com/cpython/_apis/build/status/Windows-Buildbot… + :alt: CPython build status on VSTS (Windows) + :target: https://python.visualstudio.com/cpython/_build/latest?definitionId=4&branch… + .. image:: https://codecov.io/gh/python/cpython/branch/master/graph/badge.svg :alt: CPython code coverage on Codecov :target: https://codecov.io/gh/python/cpython

1 0

bpo-34062: Add missing launcher argument and make behavior consistent between short and long arguments (GH-8827)
by Steve Dower 31 Aug '18

31 Aug '18

https://github.com/python/cpython/commit/aada63b20ec64bbfc4f2fb0718fc563eed… commit: aada63b20ec64bbfc4f2fb0718fc563eedbdd36a branch: master author: Brendan Gerrity <brerrity(a)gmail.com> committer: Steve Dower <steve.dower(a)microsoft.com> date: 2018-08-31T08:15:42-07:00 summary: bpo-34062: Add missing launcher argument and make behavior consistent between short and long arguments (GH-8827) Added previously missing "--list" argument. Made "--list" and "--list-paths" behavior consistent with the corresponding "-0" and "-0p" arguments. files: A Misc/NEWS.d/next/Windows/2018-08-21-19-28-23.bpo-34062.3gxsA3.rst M PC/launcher.c diff --git a/Misc/NEWS.d/next/Windows/2018-08-21-19-28-23.bpo-34062.3gxsA3.rst b/Misc/NEWS.d/next/Windows/2018-08-21-19-28-23.bpo-34062.3gxsA3.rst new file mode 100644 index 000000000000..ca71945d8797 --- /dev/null +++ b/Misc/NEWS.d/next/Windows/2018-08-21-19-28-23.bpo-34062.3gxsA3.rst @@ -0,0 +1 @@ +Fixed the '--list' and '--list-paths' arguments for the py.exe launcher diff --git a/PC/launcher.c b/PC/launcher.c index 455f42b617c0..fcc3abb63de6 100644 --- a/PC/launcher.c +++ b/PC/launcher.c @@ -1466,7 +1466,6 @@ process(int argc, wchar_t ** argv) wchar_t * p; int rc = 0; size_t plen; - size_t slen; INSTALLED_PYTHON * ip; BOOL valid; DWORD size, attrs; @@ -1602,10 +1601,11 @@ process(int argc, wchar_t ** argv) else { p = argv[1]; plen = wcslen(p); - if (argc == 2) { - slen = wcslen(L"-0"); - if(!wcsncmp(p, L"-0", slen)) /* Starts with -0 */ - valid = show_python_list(argv); /* Check for -0 FIRST */ + if ((argc == 2) && + (!wcsncmp(p, L"-0", wcslen(L"-0")) || /* Starts with -0 or --list */ + !wcsncmp(p, L"--list", wcslen(L"--list")))) + { + valid = show_python_list(argv); /* Check for -0 or --list FIRST */ } valid = valid && (*p == L'-') && validate_version(&p[1]); if (valid) { @@ -1638,10 +1638,13 @@ installed, use -0 for available pythons", &p[1]); if (!valid) { if ((argc == 2) && (!_wcsicmp(p, L"-h") || !_wcsicmp(p, L"--help"))) show_help_text(argv); - if ((argc == 2) && (!_wcsicmp(p, L"-0") || !_wcsicmp(p, L"-0p"))) - executable = NULL; /* Info call only */ - else + if ((argc == 2) && + (!_wcsicmp(p, L"-0") || !_wcsicmp(p, L"--list") || + !_wcsicmp(p, L"-0p") || !_wcsicmp(p, L"--list-paths"))) { + executable = NULL; /* Info call only */ + } + else { /* Look for an active virtualenv */ executable = find_python_by_venv();

1 0

Add VSTS status badge to readme (GH-8958)
by Steve Dower 31 Aug '18

31 Aug '18

https://github.com/python/cpython/commit/757b73cf92f5141396a9faf9e57a86765d… commit: 757b73cf92f5141396a9faf9e57a86765d7dac15 branch: master author: Steve Dower <steve.dower(a)microsoft.com> committer: GitHub <noreply(a)github.com> date: 2018-08-31T08:11:35-07:00 summary: Add VSTS status badge to readme (GH-8958) files: M README.rst diff --git a/README.rst b/README.rst index 90c8f5c35472..6047e7aef2cb 100644 --- a/README.rst +++ b/README.rst @@ -9,6 +9,18 @@ This is Python version 3.8.0 alpha 0 :alt: CPython build status on Appveyor :target: https://ci.appveyor.com/project/python/cpython/branch/master +.. image:: https://python.visualstudio.com/cpython/_apis/build/status/Linux-Buildbot?b… + :alt: CPython build status on VSTS (Linux) + :target: https://python.visualstudio.com/cpython/_build/latest?definitionId=6&branch… + +.. image:: https://python.visualstudio.com/cpython/_apis/build/status/macOS-Buildbot?b… + :alt: CPython build status on VSTS (macOS) + :target: https://python.visualstudio.com/cpython/_build/latest?definitionId=5&branch… + +.. image:: https://python.visualstudio.com/cpython/_apis/build/status/Windows-Buildbot… + :alt: CPython build status on VSTS (Windows) + :target: https://python.visualstudio.com/cpython/_build/latest?definitionId=4&branch… + .. image:: https://codecov.io/gh/python/cpython/branch/master/graph/badge.svg :alt: CPython code coverage on Codecov :target: https://codecov.io/gh/python/cpython @@ -16,7 +28,7 @@ This is Python version 3.8.0 alpha 0 .. image:: https://img.shields.io/badge/zulip-join_chat-brightgreen.svg :alt: Python Zulip chat :target: https://python.zulipchat.com - + Copyright (c) 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013, 2014, 2015, 2016, 2017, 2018 Python Software Foundation. All rights

1 0