Mailman 3 February 2020 - Python-checkins

bpo-1635741: Port _codecs extension module to multiphase initialization (PEP 489) (GH-18065)
by Hai Shi Feb. 11, 2020

Feb. 11, 2020

https://github.com/python/cpython/commit/1ea45ae257971ee7b648e3b031603a31fc… commit: 1ea45ae257971ee7b648e3b031603a31fc059f81 branch: master author: Hai Shi <shihai1992(a)gmail.com> committer: GitHub <noreply(a)github.com> date: 2020-02-11T03:16:38-08:00 summary: bpo-1635741: Port _codecs extension module to multiphase initialization (PEP 489) (GH-18065) https://bugs.python.org/issue1635741 files: A Misc/NEWS.d/next/Core and Builtins/2020-01-19-11-06-30.bpo-1635741.0mjsfm.rst M Modules/_codecsmodule.c diff --git a/Misc/NEWS.d/next/Core and Builtins/2020-01-19-11-06-30.bpo-1635741.0mjsfm.rst b/Misc/NEWS.d/next/Core and Builtins/2020-01-19-11-06-30.bpo-1635741.0mjsfm.rst new file mode 100644 index 0000000000000..10fc23bcfa117 --- /dev/null +++ b/Misc/NEWS.d/next/Core and Builtins/2020-01-19-11-06-30.bpo-1635741.0mjsfm.rst @@ -0,0 +1 @@ +Port _codecs extension module to multiphase initialization (:pep:`489`). \ No newline at end of file diff --git a/Modules/_codecsmodule.c b/Modules/_codecsmodule.c index a8ffb699557ab..952072102d5d8 100644 --- a/Modules/_codecsmodule.c +++ b/Modules/_codecsmodule.c @@ -1039,13 +1039,17 @@ static PyMethodDef _codecs_functions[] = { {NULL, NULL} /* sentinel */ }; +static PyModuleDef_Slot _codecs_slots[] = { + {0, NULL} +}; + static struct PyModuleDef codecsmodule = { PyModuleDef_HEAD_INIT, "_codecs", NULL, - -1, + 0, _codecs_functions, - NULL, + _codecs_slots, NULL, NULL, NULL @@ -1054,5 +1058,5 @@ static struct PyModuleDef codecsmodule = { PyMODINIT_FUNC PyInit__codecs(void) { - return PyModule_Create(&codecsmodule); + return PyModuleDef_Init(&codecsmodule); }

1 0

bpo-38374: Remove weakref.ReferenceError from docs (GH-18452)
by Miss Islington (bot) Feb. 10, 2020

Feb. 10, 2020

https://github.com/python/cpython/commit/3f8d181446aa9d87e3773896c2695161ea… commit: 3f8d181446aa9d87e3773896c2695161ea8f6e42 branch: 3.8 author: Miss Islington (bot) <31488909+miss-islington(a)users.noreply.github.com> committer: GitHub <noreply(a)github.com> date: 2020-02-10T23:02:01-08:00 summary: bpo-38374: Remove weakref.ReferenceError from docs (GH-18452) Reflecting changes to the code, removed weakref.ReferenceError from weakref.rst and exceptions.rst. Issue submitter provided evidence that the `weakref.ReferenceError` alias for `ReferenceError` was removed from the code in 2007. Working with @gvanrossum at PyCascades CPython sprint we looked at the code and confirmed that `weakref.ReferenceError` was no longer in `weakref.py`. Based on that analysis I removed references `weakref.ReferenceError` from the two documents where it was still being referenced: `weakref.rst` and `exceptions.rst`. https://bugs.python.org/issue38374 (cherry picked from commit 4eb9f4313cfaea6a9611221024a1c54f5662cc37) Co-authored-by: Roger Hurwitz <rogerhurwitz(a)gmail.com> files: M Doc/c-api/exceptions.rst M Doc/library/weakref.rst diff --git a/Doc/c-api/exceptions.rst b/Doc/c-api/exceptions.rst index c7ba74cc8d587..7300c802e0817 100644 --- a/Doc/c-api/exceptions.rst +++ b/Doc/c-api/exceptions.rst @@ -971,9 +971,6 @@ Notes: This is a base class for other standard exceptions. (2) - This is the same as :exc:`weakref.ReferenceError`. - -(3) Only defined on Windows; protect code that uses this by testing that the preprocessor macro ``MS_WINDOWS`` is defined. diff --git a/Doc/library/weakref.rst b/Doc/library/weakref.rst index b3c8e35455331..2dbe5e33bd011 100644 --- a/Doc/library/weakref.rst +++ b/Doc/library/weakref.rst @@ -327,12 +327,6 @@ objects. types. -.. exception:: ReferenceError - - Exception raised when a proxy object is used but the underlying object has been - collected. This is the same as the standard :exc:`ReferenceError` exception. - - .. seealso:: :pep:`205` - Weak References

1 0

bpo-38374: Remove weakref.ReferenceError from docs (GH-18452)
by Miss Islington (bot) Feb. 10, 2020

Feb. 10, 2020

https://github.com/python/cpython/commit/fcfc3c8fbe3942e8deef15acc25bfa371d… commit: fcfc3c8fbe3942e8deef15acc25bfa371db7766a branch: 3.7 author: Miss Islington (bot) <31488909+miss-islington(a)users.noreply.github.com> committer: GitHub <noreply(a)github.com> date: 2020-02-10T23:01:23-08:00 summary: bpo-38374: Remove weakref.ReferenceError from docs (GH-18452) Reflecting changes to the code, removed weakref.ReferenceError from weakref.rst and exceptions.rst. Issue submitter provided evidence that the `weakref.ReferenceError` alias for `ReferenceError` was removed from the code in 2007. Working with @gvanrossum at PyCascades CPython sprint we looked at the code and confirmed that `weakref.ReferenceError` was no longer in `weakref.py`. Based on that analysis I removed references `weakref.ReferenceError` from the two documents where it was still being referenced: `weakref.rst` and `exceptions.rst`. https://bugs.python.org/issue38374 (cherry picked from commit 4eb9f4313cfaea6a9611221024a1c54f5662cc37) Co-authored-by: Roger Hurwitz <rogerhurwitz(a)gmail.com> files: M Doc/c-api/exceptions.rst M Doc/library/weakref.rst diff --git a/Doc/c-api/exceptions.rst b/Doc/c-api/exceptions.rst index a53c49a211036..2f58149c6cd14 100644 --- a/Doc/c-api/exceptions.rst +++ b/Doc/c-api/exceptions.rst @@ -968,9 +968,6 @@ Notes: This is a base class for other standard exceptions. (2) - This is the same as :exc:`weakref.ReferenceError`. - -(3) Only defined on Windows; protect code that uses this by testing that the preprocessor macro ``MS_WINDOWS`` is defined. diff --git a/Doc/library/weakref.rst b/Doc/library/weakref.rst index 8d8a0b5df2687..93efcef1501b4 100644 --- a/Doc/library/weakref.rst +++ b/Doc/library/weakref.rst @@ -323,12 +323,6 @@ objects. types. -.. exception:: ReferenceError - - Exception raised when a proxy object is used but the underlying object has been - collected. This is the same as the standard :exc:`ReferenceError` exception. - - .. seealso:: :pep:`205` - Weak References

1 0

bpo-38374: Remove weakref.ReferenceError from docs (GH-18452)
by Roger Hurwitz Feb. 10, 2020

Feb. 10, 2020

https://github.com/python/cpython/commit/4eb9f4313cfaea6a9611221024a1c54f56… commit: 4eb9f4313cfaea6a9611221024a1c54f5662cc37 branch: master author: Roger Hurwitz <rogerhurwitz(a)gmail.com> committer: GitHub <noreply(a)github.com> date: 2020-02-10T22:56:02-08:00 summary: bpo-38374: Remove weakref.ReferenceError from docs (GH-18452) Reflecting changes to the code, removed weakref.ReferenceError from weakref.rst and exceptions.rst. Issue submitter provided evidence that the `weakref.ReferenceError` alias for `ReferenceError` was removed from the code in 2007. Working with @gvanrossum at PyCascades CPython sprint we looked at the code and confirmed that `weakref.ReferenceError` was no longer in `weakref.py`. Based on that analysis I removed references `weakref.ReferenceError` from the two documents where it was still being referenced: `weakref.rst` and `exceptions.rst`. https://bugs.python.org/issue38374 files: M Doc/c-api/exceptions.rst M Doc/library/weakref.rst diff --git a/Doc/c-api/exceptions.rst b/Doc/c-api/exceptions.rst index 2edcbf788d2ad..b7175166a6f00 100644 --- a/Doc/c-api/exceptions.rst +++ b/Doc/c-api/exceptions.rst @@ -983,9 +983,6 @@ Notes: This is a base class for other standard exceptions. (2) - This is the same as :exc:`weakref.ReferenceError`. - -(3) Only defined on Windows; protect code that uses this by testing that the preprocessor macro ``MS_WINDOWS`` is defined. diff --git a/Doc/library/weakref.rst b/Doc/library/weakref.rst index c3519e45beb6b..8636e76c52a42 100644 --- a/Doc/library/weakref.rst +++ b/Doc/library/weakref.rst @@ -327,12 +327,6 @@ objects. types. -.. exception:: ReferenceError - - Exception raised when a proxy object is used but the underlying object has been - collected. This is the same as the standard :exc:`ReferenceError` exception. - - .. seealso:: :pep:`205` - Weak References

1 0

bpo-39600: Adjust code, add idlelib/NEWS item (GH-18449)
by Miss Islington (bot) Feb. 10, 2020

Feb. 10, 2020

https://github.com/python/cpython/commit/32c88407d24a700946e1a6429cd5ca616c… commit: 32c88407d24a700946e1a6429cd5ca616cb3a810 branch: 3.7 author: Miss Islington (bot) <31488909+miss-islington(a)users.noreply.github.com> committer: GitHub <noreply(a)github.com> date: 2020-02-10T17:28:03-08:00 summary: bpo-39600: Adjust code, add idlelib/NEWS item (GH-18449) Complete previous patch. (cherry picked from commit 96ce22706735779cf8cc46eaaa5ac61359364b5a) Co-authored-by: Terry Jan Reedy <tjreedy(a)udel.edu> files: M Lib/idlelib/NEWS.txt M Lib/idlelib/configdialog.py diff --git a/Lib/idlelib/NEWS.txt b/Lib/idlelib/NEWS.txt index 2afbe82277ee9..3b1168693c4b5 100644 --- a/Lib/idlelib/NEWS.txt +++ b/Lib/idlelib/NEWS.txt @@ -3,6 +3,8 @@ Released on 2019-12-16? ====================================== +bpo-39600: Remove duplicate font names from configuration list. + bpo-38792: Close a shell calltip if a :exc:`KeyboardInterrupt` or shell restart occurs. Patch by Zackery Spytz. diff --git a/Lib/idlelib/configdialog.py b/Lib/idlelib/configdialog.py index 7b844f00e7736..9d5c2cde04b24 100644 --- a/Lib/idlelib/configdialog.py +++ b/Lib/idlelib/configdialog.py @@ -606,10 +606,8 @@ def load_font_cfg(self): font_size = configured_font[1] font_bold = configured_font[2]=='bold' - # Set editor font selection list and font_name. - fonts = tkFont.families(self) - # remove duplicated names and sort - fonts = sorted(set(fonts)) + # Set sorted no-duplicate editor font selection list and font_name. + fonts = sorted(set(tkFont.families(self))) for font in fonts: self.fontlist.insert(END, font) self.font_name.set(font_name)

1 0

bpo-39600: Adjust code, add idlelib/NEWS item (GH-18449)
by Miss Islington (bot) Feb. 10, 2020

Feb. 10, 2020

https://github.com/python/cpython/commit/c372f9b9e758a22608b8df33423b7413d2… commit: c372f9b9e758a22608b8df33423b7413d224fdad branch: 3.8 author: Miss Islington (bot) <31488909+miss-islington(a)users.noreply.github.com> committer: GitHub <noreply(a)github.com> date: 2020-02-10T17:27:31-08:00 summary: bpo-39600: Adjust code, add idlelib/NEWS item (GH-18449) Complete previous patch. (cherry picked from commit 96ce22706735779cf8cc46eaaa5ac61359364b5a) Co-authored-by: Terry Jan Reedy <tjreedy(a)udel.edu> files: M Lib/idlelib/NEWS.txt M Lib/idlelib/configdialog.py diff --git a/Lib/idlelib/NEWS.txt b/Lib/idlelib/NEWS.txt index 1fc9e0f3090f6..9cf563401259d 100644 --- a/Lib/idlelib/NEWS.txt +++ b/Lib/idlelib/NEWS.txt @@ -3,6 +3,8 @@ Released on 2019-12-16? ====================================== +bpo-39600: Remove duplicate font names from configuration list. + bpo-38792: Close a shell calltip if a :exc:`KeyboardInterrupt` or shell restart occurs. Patch by Zackery Spytz. diff --git a/Lib/idlelib/configdialog.py b/Lib/idlelib/configdialog.py index 7b844f00e7736..9d5c2cde04b24 100644 --- a/Lib/idlelib/configdialog.py +++ b/Lib/idlelib/configdialog.py @@ -606,10 +606,8 @@ def load_font_cfg(self): font_size = configured_font[1] font_bold = configured_font[2]=='bold' - # Set editor font selection list and font_name. - fonts = tkFont.families(self) - # remove duplicated names and sort - fonts = sorted(set(fonts)) + # Set sorted no-duplicate editor font selection list and font_name. + fonts = sorted(set(tkFont.families(self))) for font in fonts: self.fontlist.insert(END, font) self.font_name.set(font_name)

1 0

bpo-39600: Adjust code, add idlelib/NEWS item (GH-18449)
by Terry Jan Reedy Feb. 10, 2020

Feb. 10, 2020

https://github.com/python/cpython/commit/96ce22706735779cf8cc46eaaa5ac61359… commit: 96ce22706735779cf8cc46eaaa5ac61359364b5a branch: master author: Terry Jan Reedy <tjreedy(a)udel.edu> committer: GitHub <noreply(a)github.com> date: 2020-02-10T20:08:58-05:00 summary: bpo-39600: Adjust code, add idlelib/NEWS item (GH-18449) Complete previous patch. files: M Lib/idlelib/NEWS.txt M Lib/idlelib/configdialog.py diff --git a/Lib/idlelib/NEWS.txt b/Lib/idlelib/NEWS.txt index d57ba7e6bac90..838120964b2d8 100644 --- a/Lib/idlelib/NEWS.txt +++ b/Lib/idlelib/NEWS.txt @@ -3,6 +3,8 @@ Released on 2020-10-05? ====================================== +bpo-39600: Remove duplicate font names from configuration list. + bpo-38792: Close a shell calltip if a :exc:`KeyboardInterrupt` or shell restart occurs. Patch by Zackery Spytz. diff --git a/Lib/idlelib/configdialog.py b/Lib/idlelib/configdialog.py index 7b844f00e7736..9d5c2cde04b24 100644 --- a/Lib/idlelib/configdialog.py +++ b/Lib/idlelib/configdialog.py @@ -606,10 +606,8 @@ def load_font_cfg(self): font_size = configured_font[1] font_bold = configured_font[2]=='bold' - # Set editor font selection list and font_name. - fonts = tkFont.families(self) - # remove duplicated names and sort - fonts = sorted(set(fonts)) + # Set sorted no-duplicate editor font selection list and font_name. + fonts = sorted(set(tkFont.families(self))) for font in fonts: self.fontlist.insert(END, font) self.font_name.set(font_name)

1 0

bpo-38325: Skip non-BMP tests of test_winconsoleio (GH-18448)
by Victor Stinner Feb. 10, 2020

Feb. 10, 2020

https://github.com/python/cpython/commit/038770edc4680e9a3dc39bacb35a835803… commit: 038770edc4680e9a3dc39bacb35a8358034fb901 branch: master author: Victor Stinner <vstinner(a)python.org> committer: GitHub <noreply(a)github.com> date: 2020-02-11T00:58:23+01:00 summary: bpo-38325: Skip non-BMP tests of test_winconsoleio (GH-18448) Skip tests on non-BMP characters of test_winconsoleio. files: A Misc/NEWS.d/next/Tests/2020-02-11-00-38-32.bpo-38325.HgmfoE.rst M Lib/test/test_winconsoleio.py diff --git a/Lib/test/test_winconsoleio.py b/Lib/test/test_winconsoleio.py index 9a61e48881d90..a44f7bbd27b70 100644 --- a/Lib/test/test_winconsoleio.py +++ b/Lib/test/test_winconsoleio.py @@ -144,6 +144,10 @@ def test_input(self): self.assertStdinRoundTrip('ϼўТλФЙ') # Combining characters self.assertStdinRoundTrip('A͏B ﬖ̳AA̝') + + # bpo-38325 + @unittest.skipIf(True, "Handling Non-BMP characters is broken") + def test_input_nonbmp(self): # Non-BMP self.assertStdinRoundTrip('\U00100000\U0010ffff\U0010fffd') @@ -163,6 +167,8 @@ def test_partial_reads(self): self.assertEqual(actual, expected, 'stdin.read({})'.format(read_count)) + # bpo-38325 + @unittest.skipIf(True, "Handling Non-BMP characters is broken") def test_partial_surrogate_reads(self): # Test that reading less than 1 full character works when stdin # contains surrogate pairs that cannot be decoded to UTF-8 without diff --git a/Misc/NEWS.d/next/Tests/2020-02-11-00-38-32.bpo-38325.HgmfoE.rst b/Misc/NEWS.d/next/Tests/2020-02-11-00-38-32.bpo-38325.HgmfoE.rst new file mode 100644 index 0000000000000..7503379915260 --- /dev/null +++ b/Misc/NEWS.d/next/Tests/2020-02-11-00-38-32.bpo-38325.HgmfoE.rst @@ -0,0 +1 @@ +Skip tests on non-BMP characters of test_winconsoleio.

1 0

bpo-39417: Fix broken link to guide to building venvs (GH-18432)
by Ogi Moore Feb. 10, 2020

Feb. 10, 2020

https://github.com/python/cpython/commit/c4a65ed7fe342bd18b5a5b0eea3470dc4f… commit: c4a65ed7fe342bd18b5a5b0eea3470dc4fc31160 branch: master author: Ogi Moore <ognyan.moore(a)jacobs.ucsd.edu> committer: GitHub <noreply(a)github.com> date: 2020-02-10T15:51:01-08:00 summary: bpo-39417: Fix broken link to guide to building venvs (GH-18432) files: M Doc/library/venv.rst diff --git a/Doc/library/venv.rst b/Doc/library/venv.rst index d778486b0a5d9..8abadc4df3cac 100644 --- a/Doc/library/venv.rst +++ b/Doc/library/venv.rst @@ -27,7 +27,7 @@ See :pep:`405` for more information about Python virtual environments. .. seealso:: `Python Packaging User Guide: Creating and using virtual environments - <https://packaging.python.org/installing/#creating-virtual-environments>`__ + <https://packaging.python.org/guides/installing-using-pip-and-virtual-enviro…>`__ Creating virtual environments

1 0

Correct the documented default encoding (GH-18429)
by Eric Wieser Feb. 10, 2020

Feb. 10, 2020

https://github.com/python/cpython/commit/bf15d5b775c31e65584926998ff141edc7… commit: bf15d5b775c31e65584926998ff141edc75226d4 branch: master author: Eric Wieser <wieser.eric(a)gmail.com> committer: GitHub <noreply(a)github.com> date: 2020-02-10T15:32:18-08:00 summary: Correct the documented default encoding (GH-18429) >From the source for `PyUnicode_Decode`, the implementation is: ``` if (encoding == NULL) { return PyUnicode_DecodeUTF8Stateful(s, size, errors, NULL); } ``` which is pretty clearly not defaulting to ASCII. --- I assume this needs neither a news entry nor bpo link. files: M Doc/c-api/unicode.rst diff --git a/Doc/c-api/unicode.rst b/Doc/c-api/unicode.rst index 77f123cf1f2c0..96d77c4084132 100644 --- a/Doc/c-api/unicode.rst +++ b/Doc/c-api/unicode.rst @@ -978,7 +978,7 @@ have the same semantics as the ones of the built-in :func:`str` string object constructor. Setting encoding to ``NULL`` causes the default encoding to be used -which is ASCII. The file system calls should use +which is UTF-8. The file system calls should use :c:func:`PyUnicode_FSConverter` for encoding file names. This uses the variable :c:data:`Py_FileSystemDefaultEncoding` internally. This variable should be treated as read-only: on some systems, it will be a

1 0