Mailman 3 March 2020 - Python-checkins

bpo-40019: Skip test_gdb if Python was optimized (GH-19081)
by Miss Islington (bot) March 31, 2020

March 31, 2020

https://github.com/python/cpython/commit/4ced9a7611ddfd923bd8f72aa61121d0e5… commit: 4ced9a7611ddfd923bd8f72aa61121d0e5aeb8fc branch: 3.8 author: Miss Islington (bot) <31488909+miss-islington(a)users.noreply.github.com> committer: GitHub <noreply(a)github.com> date: 2020-03-31T10:27:41-07:00 summary: bpo-40019: Skip test_gdb if Python was optimized (GH-19081) test_gdb now skips tests if it detects that gdb failed to read debug information because the Python binary is optimized. (cherry picked from commit 7bf069b6110278102c8f4719975a5eb5a5af25f9) Co-authored-by: Victor Stinner <vstinner(a)python.org> files: A Misc/NEWS.d/next/Tests/2020-03-20-00-30-36.bpo-40019.zOqHpQ.rst M Lib/test/test_gdb.py M Tools/gdb/libpython.py diff --git a/Lib/test/test_gdb.py b/Lib/test/test_gdb.py index e1060330550e3..bd9a5cbe9c0a8 100644 --- a/Lib/test/test_gdb.py +++ b/Lib/test/test_gdb.py @@ -230,6 +230,15 @@ def get_stack_trace(self, source=None, script=None, " because the Program Counter is" " not present") + # bpo-40019: Skip the test if gdb failed to read debug information + # because the Python binary is optimized. + for pattern in ( + '(frame information optimized out)', + 'Unable to read information on python frame', + ): + if pattern in out: + raise unittest.SkipTest(f"{pattern!r} found in gdb output") + return out def get_gdb_repr(self, source, diff --git a/Misc/NEWS.d/next/Tests/2020-03-20-00-30-36.bpo-40019.zOqHpQ.rst b/Misc/NEWS.d/next/Tests/2020-03-20-00-30-36.bpo-40019.zOqHpQ.rst new file mode 100644 index 0000000000000..a9d0b3970ae53 --- /dev/null +++ b/Misc/NEWS.d/next/Tests/2020-03-20-00-30-36.bpo-40019.zOqHpQ.rst @@ -0,0 +1,2 @@ +test_gdb now skips tests if it detects that gdb failed to read debug +information because the Python binary is optimized. diff --git a/Tools/gdb/libpython.py b/Tools/gdb/libpython.py index 9496ff2e0d8d2..ffb1813720e45 100755 --- a/Tools/gdb/libpython.py +++ b/Tools/gdb/libpython.py @@ -99,6 +99,8 @@ def _sizeof_void_p(): ENCODING = locale.getpreferredencoding() +FRAME_INFO_OPTIMIZED_OUT = '(frame information optimized out)' +UNABLE_READ_INFO_PYTHON_FRAME = 'Unable to read information on python frame' EVALFRAME = '_PyEval_EvalFrameDefault' class NullPyObjectPtr(RuntimeError): @@ -918,7 +920,7 @@ def get_var_by_name(self, name): def filename(self): '''Get the path of the current Python source file, as a string''' if self.is_optimized_out(): - return '(frame information optimized out)' + return FRAME_INFO_OPTIMIZED_OUT return self.co_filename.proxyval(set()) def current_line_num(self): @@ -949,7 +951,7 @@ def current_line(self): '''Get the text of the current source line as a string, with a trailing newline character''' if self.is_optimized_out(): - return '(frame information optimized out)' + return FRAME_INFO_OPTIMIZED_OUT lineno = self.current_line_num() if lineno is None: @@ -970,7 +972,7 @@ def current_line(self): def write_repr(self, out, visited): if self.is_optimized_out(): - out.write('(frame information optimized out)') + out.write(FRAME_INFO_OPTIMIZED_OUT) return lineno = self.current_line_num() lineno = str(lineno) if lineno is not None else "?" @@ -993,7 +995,7 @@ def write_repr(self, out, visited): def print_traceback(self): if self.is_optimized_out(): - sys.stdout.write(' (frame information optimized out)\n') + sys.stdout.write(' %s\n' % FRAME_INFO_OPTIMIZED_OUT) return visited = set() lineno = self.current_line_num() @@ -1744,7 +1746,7 @@ def invoke(self, args, from_tty): pyop = frame.get_pyop() if not pyop or pyop.is_optimized_out(): - print('Unable to read information on python frame') + print(UNABLE_READ_INFO_PYTHON_FRAME) return filename = pyop.filename() @@ -1904,7 +1906,7 @@ def invoke(self, args, from_tty): pyop_frame = frame.get_pyop() if not pyop_frame: - print('Unable to read information on python frame') + print(UNABLE_READ_INFO_PYTHON_FRAME) return pyop_var, scope = pyop_frame.get_var_by_name(name) @@ -1938,7 +1940,7 @@ def invoke(self, args, from_tty): pyop_frame = frame.get_pyop() if not pyop_frame: - print('Unable to read information on python frame') + print(UNABLE_READ_INFO_PYTHON_FRAME) return for pyop_name, pyop_value in pyop_frame.iter_locals():

1 0

Document most common signals (GH-19245)
by Victor Stinner March 31, 2020

March 31, 2020

https://github.com/python/cpython/commit/400e1dbcad93061f1f7ab4735202daaa5e… commit: 400e1dbcad93061f1f7ab4735202daaa5e731507 branch: master author: Victor Stinner <vstinner(a)python.org> committer: GitHub <noreply(a)github.com> date: 2020-03-31T19:13:10+02:00 summary: Document most common signals (GH-19245) Document individual signals (only the most common signals): description, default action, availability. files: M Doc/library/signal.rst M Python/pylifecycle.c diff --git a/Doc/library/signal.rst b/Doc/library/signal.rst index 4353cc7cdf454..05b285ed110ec 100644 --- a/Doc/library/signal.rst +++ b/Doc/library/signal.rst @@ -91,6 +91,110 @@ The variables defined in the :mod:`signal` module are: signal. +.. data:: SIGABRT + + Abort signal from :manpage:`abort(3)`. + +.. data:: SIGALRM + + Timer signal from :manpage:`alarm(2)`. + + .. availability:: Unix. + +.. data:: SIGBREAK + + Interrupt from keyboard (CTRL + BREAK). + + .. availability:: Windows. + +.. data:: SIGBUS + + Bus error (bad memory access). + + .. availability:: Unix. + +.. data:: SIGCHLD + + Child process stopped or terminated. + + .. availability:: Windows. + +.. data:: SIGCLD + + Alias to :data:`SIGCHLD`. + +.. data:: SIGCONT + + Continue the process if it is currently stopped + + .. availability:: Unix. + +.. data:: SIGFPE + + Floating-point exception. For example, division by zero. + + .. seealso:: + :exc:`ZeroDivisionError` is raised when the second argument of a division + or modulo operation is zero. + +.. data:: SIGHUP + + Hangup detected on controlling terminal or death of controlling process. + + .. availability:: Unix. + +.. data:: SIGILL + + Illegal instruction. + +.. data:: SIGINT + + Interrupt from keyboard (CTRL + C). + + Default action is to raise :exc:`KeyboardInterrupt`. + +.. data:: SIGKILL + + Kill signal. + + It cannot be caught, blocked, or ignored. + + .. availability:: Unix. + +.. data:: SIGPIPE + + Broken pipe: write to pipe with no readers. + + Default action is to ignore the signal. + + .. availability:: Unix. + +.. data:: SIGSEGV + + Segmentation fault: invalid memory reference. + +.. data:: SIGTERM + + Termination signal. + +.. data:: SIGUSR1 + + User-defined signal 1. + + .. availability:: Unix. + +.. data:: SIGUSR2 + + User-defined signal 2. + + .. availability:: Unix. + +.. data:: SIGWINCH + + Window resize signal. + + .. availability:: Unix. + .. data:: SIG* All the signal numbers are defined symbolically. For example, the hangup signal @@ -310,6 +414,8 @@ The :mod:`signal` module defines the following functions: For example, ``signal.pthread_sigmask(signal.SIG_BLOCK, [])`` reads the signal mask of the calling thread. + :data:`SIGKILL` and :data:`SIGSTOP` cannot be blocked. + .. availability:: Unix. See the man page :manpage:`sigprocmask(3)` and :manpage:`pthread_sigmask(3)` for further information. diff --git a/Python/pylifecycle.c b/Python/pylifecycle.c index 4c27738693a6f..2d5cb0ff78f57 100644 --- a/Python/pylifecycle.c +++ b/Python/pylifecycle.c @@ -2433,7 +2433,7 @@ init_signals(PyThreadState *tstate) #ifdef SIGXFSZ PyOS_setsig(SIGXFSZ, SIG_IGN); #endif - PyOS_InitInterrupts(); /* May imply initsignal() */ + PyOS_InitInterrupts(); /* May imply init_signals() */ if (_PyErr_Occurred(tstate)) { return _PyStatus_ERR("can't import signal"); }

1 0

closes bpo-40125: Update multissltests.py to use OpenSSL 1.1.1f. (GH-19248)
by Miss Islington (bot) March 31, 2020

March 31, 2020

https://github.com/python/cpython/commit/fb6e04b5f10086194bcc77d571f77cb308… commit: fb6e04b5f10086194bcc77d571f77cb30873998b branch: 3.8 author: Miss Islington (bot) <31488909+miss-islington(a)users.noreply.github.com> committer: GitHub <noreply(a)github.com> date: 2020-03-31T09:08:49-07:00 summary: closes bpo-40125: Update multissltests.py to use OpenSSL 1.1.1f. (GH-19248) (cherry picked from commit cd16661f903153ecac55f190ed682e576c5deb24) Co-authored-by: Benjamin Peterson <benjamin(a)python.org> files: M Tools/ssl/multissltests.py diff --git a/Tools/ssl/multissltests.py b/Tools/ssl/multissltests.py index d816810d57078..05d6d7de296db 100755 --- a/Tools/ssl/multissltests.py +++ b/Tools/ssl/multissltests.py @@ -47,7 +47,7 @@ OPENSSL_RECENT_VERSIONS = [ "1.0.2t", "1.1.0l", - "1.1.1d", + "1.1.1f", ] LIBRESSL_OLD_VERSIONS = [

1 0

closes bpo-40125: Update multissltests.py to use OpenSSL 1.1.1f. (GH-19248)
by Miss Islington (bot) March 31, 2020

March 31, 2020

https://github.com/python/cpython/commit/9073f9272475be620c09b2852c094788b2… commit: 9073f9272475be620c09b2852c094788b2b7096a branch: 3.7 author: Miss Islington (bot) <31488909+miss-islington(a)users.noreply.github.com> committer: GitHub <noreply(a)github.com> date: 2020-03-31T09:07:23-07:00 summary: closes bpo-40125: Update multissltests.py to use OpenSSL 1.1.1f. (GH-19248) (cherry picked from commit cd16661f903153ecac55f190ed682e576c5deb24) Co-authored-by: Benjamin Peterson <benjamin(a)python.org> files: M Tools/ssl/multissltests.py diff --git a/Tools/ssl/multissltests.py b/Tools/ssl/multissltests.py index d816810d57078..05d6d7de296db 100755 --- a/Tools/ssl/multissltests.py +++ b/Tools/ssl/multissltests.py @@ -47,7 +47,7 @@ OPENSSL_RECENT_VERSIONS = [ "1.0.2t", "1.1.0l", - "1.1.1d", + "1.1.1f", ] LIBRESSL_OLD_VERSIONS = [

1 0

closes bpo-40125: Update multissltests.py to use OpenSSL 1.1.1f. (GH-19248)
by Benjamin Peterson March 31, 2020

March 31, 2020

https://github.com/python/cpython/commit/cd16661f903153ecac55f190ed682e576c… commit: cd16661f903153ecac55f190ed682e576c5deb24 branch: master author: Benjamin Peterson <benjamin(a)python.org> committer: GitHub <noreply(a)github.com> date: 2020-03-31T10:49:56-05:00 summary: closes bpo-40125: Update multissltests.py to use OpenSSL 1.1.1f. (GH-19248) files: M Tools/ssl/multissltests.py diff --git a/Tools/ssl/multissltests.py b/Tools/ssl/multissltests.py index d816810d57078..05d6d7de296db 100755 --- a/Tools/ssl/multissltests.py +++ b/Tools/ssl/multissltests.py @@ -47,7 +47,7 @@ OPENSSL_RECENT_VERSIONS = [ "1.0.2t", "1.1.0l", - "1.1.1d", + "1.1.1f", ] LIBRESSL_OLD_VERSIONS = [

1 0

bpo-40003: test.bisect_cmd copies Python options (GH-19246)
by Victor Stinner March 31, 2020

March 31, 2020

https://github.com/python/cpython/commit/01e743d704aeefd1c1825a6a96d0c766c5… commit: 01e743d704aeefd1c1825a6a96d0c766c5516fb1 branch: master author: Victor Stinner <vstinner(a)python.org> committer: GitHub <noreply(a)github.com> date: 2020-03-31T17:25:56+02:00 summary: bpo-40003: test.bisect_cmd copies Python options (GH-19246) test.bisect_cmd now copies Python command line options like -O or -W. Moreover, emit a warning if test.bisect_cmd is used with -w/--verbose2 option. files: A Misc/NEWS.d/next/Tests/2020-03-31-16-07-15.bpo-40003.SOruLY.rst M Lib/test/bisect_cmd.py diff --git a/Lib/test/bisect_cmd.py b/Lib/test/bisect_cmd.py index cb06480e7c91f..0bdd7a43c03f7 100755 --- a/Lib/test/bisect_cmd.py +++ b/Lib/test/bisect_cmd.py @@ -47,8 +47,16 @@ def format_shell_args(args): return ' '.join(args) +def python_cmd(): + cmd = [sys.executable] + cmd.extend(subprocess._args_from_interpreter_flags()) + cmd.extend(subprocess._optim_args_from_interpreter_flags()) + return cmd + + def list_cases(args): - cmd = [sys.executable, '-m', 'test', '--list-cases'] + cmd = python_cmd() + cmd.extend(['-m', 'test', '--list-cases']) cmd.extend(args.test_args) proc = subprocess.run(cmd, stdout=subprocess.PIPE, @@ -68,7 +76,8 @@ def run_tests(args, tests, huntrleaks=None): try: write_tests(tmp, tests) - cmd = [sys.executable, '-m', 'test', '--matchfile', tmp] + cmd = python_cmd() + cmd.extend(['-m', 'test', '--matchfile', tmp]) cmd.extend(args.test_args) print("+ %s" % format_shell_args(cmd)) proc = subprocess.run(cmd) @@ -100,6 +109,9 @@ def parse_args(): def main(): args = parse_args() + if '-w' in args.test_args or '--verbose2' in args.test_args: + print("WARNING: -w/--verbose2 option should not be used to bisect!") + print() if args.input: with open(args.input) as fp: diff --git a/Misc/NEWS.d/next/Tests/2020-03-31-16-07-15.bpo-40003.SOruLY.rst b/Misc/NEWS.d/next/Tests/2020-03-31-16-07-15.bpo-40003.SOruLY.rst new file mode 100644 index 0000000000000..7ddb90121d894 --- /dev/null +++ b/Misc/NEWS.d/next/Tests/2020-03-31-16-07-15.bpo-40003.SOruLY.rst @@ -0,0 +1,3 @@ +``test.bisect_cmd`` now copies Python command line options like ``-O`` or +``-W``. Moreover, emit a warning if ``test.bisect_cmd`` is used with +``-w``/``--verbose2`` option.

1 0

bpo-32591: _PyErr_WarnUnawaitedCoroutine() sets source (GH-19247)
by Victor Stinner March 31, 2020

March 31, 2020

https://github.com/python/cpython/commit/8d84adcd736619c2ce510dff1e7ffd3ab0… commit: 8d84adcd736619c2ce510dff1e7ffd3ab08df06a branch: master author: Victor Stinner <vstinner(a)python.org> committer: GitHub <noreply(a)github.com> date: 2020-03-31T17:25:12+02:00 summary: bpo-32591: _PyErr_WarnUnawaitedCoroutine() sets source (GH-19247) The _PyErr_WarnUnawaitedCoroutine() fallback now also sets the coroutine object as the source of the warning, as done by the Python implementation warnings._warn_unawaited_coroutine(). Moreover, don't truncate the coroutine name: Python supports arbitrary string length to format the message. files: M Python/_warnings.c diff --git a/Python/_warnings.c b/Python/_warnings.c index 834ceb1845946..fd3ca60e5da2f 100644 --- a/Python/_warnings.c +++ b/Python/_warnings.c @@ -1129,6 +1129,23 @@ PyErr_WarnFormat(PyObject *category, Py_ssize_t stack_level, return res; } +static int +_PyErr_WarnFormat(PyObject *source, PyObject *category, Py_ssize_t stack_level, + const char *format, ...) +{ + int res; + va_list vargs; + +#ifdef HAVE_STDARG_PROTOTYPES + va_start(vargs, format); +#else + va_start(vargs); +#endif + res = _PyErr_WarnFormatV(source, category, stack_level, format, vargs); + va_end(vargs); + return res; +} + int PyErr_ResourceWarning(PyObject *source, Py_ssize_t stack_level, const char *format, ...) @@ -1297,9 +1314,9 @@ _PyErr_WarnUnawaitedCoroutine(PyObject *coro) PyErr_WriteUnraisable(coro); } if (!warned) { - if (PyErr_WarnFormat(PyExc_RuntimeWarning, 1, - "coroutine '%.50S' was never awaited", - ((PyCoroObject *)coro)->cr_qualname) < 0) + if (_PyErr_WarnFormat(coro, PyExc_RuntimeWarning, 1, + "coroutine '%S' was never awaited", + ((PyCoroObject *)coro)->cr_qualname) < 0) { PyErr_WriteUnraisable(coro); }

1 0

bpo-1635741: Port math module to multiphase initialization (GH-19243)
by Dong-hee Na March 31, 2020

March 31, 2020

https://github.com/python/cpython/commit/5be8241392453751beea21d2e32096c15a… commit: 5be8241392453751beea21d2e32096c15a8d47db branch: master author: Dong-hee Na <donghee.na92(a)gmail.com> committer: GitHub <noreply(a)github.com> date: 2020-03-31T16:33:22+02:00 summary: bpo-1635741: Port math module to multiphase initialization (GH-19243) files: A Misc/NEWS.d/next/Core and Builtins/2020-03-31-22-15-04.bpo-1635741.8Ir1a0.rst M Modules/mathmodule.c diff --git a/Misc/NEWS.d/next/Core and Builtins/2020-03-31-22-15-04.bpo-1635741.8Ir1a0.rst b/Misc/NEWS.d/next/Core and Builtins/2020-03-31-22-15-04.bpo-1635741.8Ir1a0.rst new file mode 100644 index 0000000000000..e1c5a29916b1c --- /dev/null +++ b/Misc/NEWS.d/next/Core and Builtins/2020-03-31-22-15-04.bpo-1635741.8Ir1a0.rst @@ -0,0 +1 @@ +Port :mod:`math` to multiphase initialization (:pep:`489`). diff --git a/Modules/mathmodule.c b/Modules/mathmodule.c index 2a73a983f56d2..f1d59c09e6272 100644 --- a/Modules/mathmodule.c +++ b/Modules/mathmodule.c @@ -3421,6 +3421,29 @@ math_ulp_impl(PyObject *module, double x) return x2 - x; } +static int +math_exec(PyObject *module) +{ + if (PyModule_AddObject(module, "pi", PyFloat_FromDouble(Py_MATH_PI)) < 0) { + return -1; + } + if (PyModule_AddObject(module, "e", PyFloat_FromDouble(Py_MATH_E)) < 0) { + return -1; + } + // 2pi + if (PyModule_AddObject(module, "tau", PyFloat_FromDouble(Py_MATH_TAU)) < 0) { + return -1; + } + if (PyModule_AddObject(module, "inf", PyFloat_FromDouble(m_inf())) < 0) { + return -1; + } +#if !defined(PY_NO_SHORT_FLOAT_REPR) || defined(Py_NAN) + if (PyModule_AddObject(module, "nan", PyFloat_FromDouble(m_nan())) < 0) { + return -1; + } +#endif + return 0; +} static PyMethodDef math_methods[] = { {"acos", math_acos, METH_O, math_acos_doc}, @@ -3479,41 +3502,26 @@ static PyMethodDef math_methods[] = { {NULL, NULL} /* sentinel */ }; +static PyModuleDef_Slot math_slots[] = { + {Py_mod_exec, math_exec}, + {0, NULL} +}; PyDoc_STRVAR(module_doc, "This module provides access to the mathematical functions\n" "defined by the C standard."); - static struct PyModuleDef mathmodule = { PyModuleDef_HEAD_INIT, - "math", - module_doc, - -1, - math_methods, - NULL, - NULL, - NULL, - NULL + .m_name = "math", + .m_doc = module_doc, + .m_size = 0, + .m_methods = math_methods, + .m_slots = math_slots, }; PyMODINIT_FUNC PyInit_math(void) { - PyObject *m; - - m = PyModule_Create(&mathmodule); - if (m == NULL) - goto finally; - - PyModule_AddObject(m, "pi", PyFloat_FromDouble(Py_MATH_PI)); - PyModule_AddObject(m, "e", PyFloat_FromDouble(Py_MATH_E)); - PyModule_AddObject(m, "tau", PyFloat_FromDouble(Py_MATH_TAU)); /* 2pi */ - PyModule_AddObject(m, "inf", PyFloat_FromDouble(m_inf())); -#if !defined(PY_NO_SHORT_FLOAT_REPR) || defined(Py_NAN) - PyModule_AddObject(m, "nan", PyFloat_FromDouble(m_nan())); -#endif - - finally: - return m; + return PyModuleDef_Init(&mathmodule); }

1 0

bpo-1635741: Port _uuid module to multiphase initialization (GH-19242)
by Dong-hee Na March 31, 2020

March 31, 2020

https://github.com/python/cpython/commit/1cb763b8808745b9a368c1158fda19d329… commit: 1cb763b8808745b9a368c1158fda19d329f63f6f branch: master author: Dong-hee Na <donghee.na92(a)gmail.com> committer: GitHub <noreply(a)github.com> date: 2020-03-31T14:43:47+02:00 summary: bpo-1635741: Port _uuid module to multiphase initialization (GH-19242) files: A Misc/NEWS.d/next/Core and Builtins/2020-03-31-21-12-27.bpo-1635741.S2nkF3.rst M Modules/_uuidmodule.c diff --git a/Misc/NEWS.d/next/Core and Builtins/2020-03-31-21-12-27.bpo-1635741.S2nkF3.rst b/Misc/NEWS.d/next/Core and Builtins/2020-03-31-21-12-27.bpo-1635741.S2nkF3.rst new file mode 100644 index 0000000000000..7d5a8ca21d26f --- /dev/null +++ b/Misc/NEWS.d/next/Core and Builtins/2020-03-31-21-12-27.bpo-1635741.S2nkF3.rst @@ -0,0 +1 @@ +Port _uuid module to multiphase initialization (:pep:`489`). diff --git a/Modules/_uuidmodule.c b/Modules/_uuidmodule.c index 0b7aa72e91a1c..3be6c848ad645 100644 --- a/Modules/_uuidmodule.c +++ b/Modules/_uuidmodule.c @@ -38,38 +38,41 @@ py_uuid_generate_time_safe(PyObject *Py_UNUSED(context), #endif } +static int +uuid_exec(PyObject *module) { + assert(sizeof(uuid_t) == 16); +#ifdef HAVE_UUID_GENERATE_TIME_SAFE + int has_uuid_generate_time_safe = 1; +#else + int has_uuid_generate_time_safe = 0; +#endif + if (PyModule_AddIntConstant(module, "has_uuid_generate_time_safe", + has_uuid_generate_time_safe) < 0) { + return -1; + } + return 0; +} static PyMethodDef uuid_methods[] = { {"generate_time_safe", py_uuid_generate_time_safe, METH_NOARGS, NULL}, {NULL, NULL, 0, NULL} /* sentinel */ }; +static PyModuleDef_Slot uuid_slots[] = { + {Py_mod_exec, uuid_exec}, + {0, NULL} +}; + static struct PyModuleDef uuidmodule = { PyModuleDef_HEAD_INIT, .m_name = "_uuid", - .m_size = -1, + .m_size = 0, .m_methods = uuid_methods, + .m_slots = uuid_slots, }; PyMODINIT_FUNC PyInit__uuid(void) { - PyObject *mod; - assert(sizeof(uuid_t) == 16); -#ifdef HAVE_UUID_GENERATE_TIME_SAFE - int has_uuid_generate_time_safe = 1; -#else - int has_uuid_generate_time_safe = 0; -#endif - mod = PyModule_Create(&uuidmodule); - if (mod == NULL) { - return NULL; - } - if (PyModule_AddIntConstant(mod, "has_uuid_generate_time_safe", - has_uuid_generate_time_safe) < 0) { - Py_DECREF(mod); - return NULL; - } - - return mod; + return PyModuleDef_Init(&uuidmodule); }

1 0

bpo-39689: Do not use native packing for format "?" with standard size (GH-18969)
by Miss Islington (bot) March 31, 2020

March 31, 2020

https://github.com/python/cpython/commit/572ef747692055a270a9fbf8eeaf5c4a15… commit: 572ef747692055a270a9fbf8eeaf5c4a15c8e332 branch: 3.8 author: Miss Islington (bot) <31488909+miss-islington(a)users.noreply.github.com> committer: GitHub <noreply(a)github.com> date: 2020-03-31T05:26:05-07:00 summary: bpo-39689: Do not use native packing for format "?" with standard size (GH-18969) (cherry picked from commit 472fc843ca816d65c12f9508ac762ca492165c45) Co-authored-by: Stefan Krah <skrah(a)bytereef.org> files: M Modules/_struct.c diff --git a/Modules/_struct.c b/Modules/_struct.c index 9281c6803f3a6..1c917b7513f46 100644 --- a/Modules/_struct.c +++ b/Modules/_struct.c @@ -2365,6 +2365,9 @@ PyInit__struct(void) "unknown" float format */ if (ptr->format == 'd' || ptr->format == 'f') break; + /* Skip _Bool, semantics are different for standard size */ + if (ptr->format == '?') + break; ptr->pack = native->pack; ptr->unpack = native->unpack; break;

1 0