Mailman 3 August 2020 - Python-checkins

bpo-41513: Save unnecessary steps in the hypot() calculation (#21994)
by Raymond Hettinger Aug. 29, 2020

Aug. 29, 2020

https://github.com/python/cpython/commit/27de28607a248e5ffb8838162fca466a58… commit: 27de28607a248e5ffb8838162fca466a58c2e284 branch: master author: Raymond Hettinger <rhettinger(a)users.noreply.github.com> committer: GitHub <noreply(a)github.com> date: 2020-08-29T09:11:04-07:00 summary: bpo-41513: Save unnecessary steps in the hypot() calculation (#21994) files: M Modules/mathmodule.c diff --git a/Modules/mathmodule.c b/Modules/mathmodule.c index 1704d8efd31c3..4ff2a069a76c7 … [View More]

1 0

bpo-19521: Fix parallel build race condition on AIX (GH-21997)
by Stefan Krah Aug. 29, 2020

Aug. 29, 2020

https://github.com/python/cpython/commit/e6dcd371b2c54a94584dd124e8c592a496… commit: e6dcd371b2c54a94584dd124e8c592a496d46a47 branch: master author: Stefan Krah <skrah(a)bytereef.org> committer: GitHub <noreply(a)github.com> date: 2020-08-29T17:00:08+02:00 summary: bpo-19521: Fix parallel build race condition on AIX (GH-21997) Patch by Michael Haubenwallner. files: M Makefile.pre.in M configure M configure.ac diff --git a/Makefile.pre.in b/Makefile.pre.in index … [View More]0a19313ea9939..5d3ac705a3625 100644 --- a/Makefile.pre.in +++ b/Makefile.pre.in @@ -161,6 +161,10 @@ BLDSHARED= @BLDSHARED@ $(PY_CORE_LDFLAGS) LDCXXSHARED= @LDCXXSHARED@ DESTSHARED= $(BINLIBDEST)/lib-dynload +# List of exported symbols for AIX +EXPORTSYMS= @EXPORTSYMS@ +EXPORTSFROM= @EXPORTSFROM@ + # Executable suffix (.exe on Windows and Mac OS X) EXE= @EXEEXT@ BUILDEXE= @BUILDEXEEXT@ @@ -571,7 +575,7 @@ clinic: check-clean-src $(srcdir)/Modules/_blake2/blake2s_impl.c $(PYTHON_FOR_REGEN) $(srcdir)/Tools/clinic/clinic.py --make --srcdir $(srcdir) # Build the interpreter -$(BUILDPYTHON): Programs/python.o $(LIBRARY) $(LDLIBRARY) $(PY3LIBRARY) +$(BUILDPYTHON): Programs/python.o $(LIBRARY) $(LDLIBRARY) $(PY3LIBRARY) $(EXPORTSYMS) $(LINKCC) $(PY_CORE_LDFLAGS) $(LINKFORSHARED) -o $@ Programs/python.o $(BLDLIBRARY) $(LIBS) $(MODLIBS) $(SYSLIBS) platform: $(BUILDPYTHON) pybuilddir.txt @@ -643,6 +647,10 @@ libpython$(LDVERSION).dylib: $(LIBRARY_OBJS) libpython$(VERSION).sl: $(LIBRARY_OBJS) $(LDSHARED) -o $@ $(LIBRARY_OBJS) $(MODLIBS) $(SHLIBS) $(LIBC) $(LIBM) +# List of exported symbols for AIX +Modules/python.exp: $(LIBRARY) + $(srcdir)/Modules/makexp_aix $@ "$(EXPORTSFROM)" $? + # Copy up the gdb python hooks into a position where they can be automatically # loaded by gdb during Lib/test/test_gdb.py # @@ -702,7 +710,7 @@ Makefile Modules/config.c: Makefile.pre \ @echo "The Makefile was updated, you may need to re-run make." -Programs/_testembed: Programs/_testembed.o $(LIBRARY) $(LDLIBRARY) $(PY3LIBRARY) +Programs/_testembed: Programs/_testembed.o $(LIBRARY) $(LDLIBRARY) $(PY3LIBRARY) $(EXPORTSYMS) $(LINKCC) $(PY_CORE_LDFLAGS) $(LINKFORSHARED) -o $@ Programs/_testembed.o $(BLDLIBRARY) $(LIBS) $(MODLIBS) $(SYSLIBS) ############################################################################ diff --git a/configure b/configure index 69e975a4e8ef3..4c18ae7e364ca 100755 --- a/configure +++ b/configure @@ -700,6 +700,8 @@ ARFLAGS ac_ct_AR AR GNULD +EXPORTSFROM +EXPORTSYMS LINKCC LDVERSION RUNSHARED @@ -5799,8 +5801,6 @@ LDVERSION="$VERSION" # If CXX is set, and if it is needed to link a main function that was # compiled with CXX, LINKCC is CXX instead. Always using CXX is undesirable: # python might then depend on the C++ runtime -# This is altered for AIX in order to build the export list before -# linking. { $as_echo "$as_me:${as_lineno-$LINENO}: checking LINKCC" >&5 $as_echo_n "checking LINKCC... " >&6; } @@ -5808,13 +5808,6 @@ if test -z "$LINKCC" then LINKCC='$(PURIFY) $(MAINCC)' case $ac_sys_system in - AIX*) - exp_extra="\"\"" - if test $ac_sys_release -ge 5 -o \ - $ac_sys_release -eq 4 -a `uname -r` -ge 2 ; then - exp_extra="." - fi - LINKCC="\$(srcdir)/Modules/makexp_aix Modules/python.exp $exp_extra \$(LIBRARY); $LINKCC";; QNX*) # qcc must be used because the other compilers do not # support -N. @@ -5824,6 +5817,26 @@ fi { $as_echo "$as_me:${as_lineno-$LINENO}: result: $LINKCC" >&5 $as_echo "$LINKCC" >&6; } +# EXPORTSYMS holds the list of exported symbols for AIX. +# EXPORTSFROM holds the module name exporting symbols on AIX. +EXPORTSYMS= +EXPORTSFROM= + + +{ $as_echo "$as_me:${as_lineno-$LINENO}: checking EXPORTSYMS" >&5 +$as_echo_n "checking EXPORTSYMS... " >&6; } +case $ac_sys_system in +AIX*) + EXPORTSYMS="Modules/python.exp" + if test $ac_sys_release -ge 5 -o \ + $ac_sys_release -eq 4 -a `uname -r` -ge 2 ; then + EXPORTSFROM=. # the main executable + fi + ;; +esac +{ $as_echo "$as_me:${as_lineno-$LINENO}: result: $EXPORTSYMS" >&5 +$as_echo "$EXPORTSYMS" >&6; } + # GNULD is set to "yes" if the GNU linker is used. If this goes wrong # make sure we default having it set to "no": this is used by # distutils.unixccompiler to know if it should add --enable-new-dtags diff --git a/configure.ac b/configure.ac index 07c0585432b06..3b40f39124dad 100644 --- a/configure.ac +++ b/configure.ac @@ -1024,21 +1024,12 @@ LDVERSION="$VERSION" # If CXX is set, and if it is needed to link a main function that was # compiled with CXX, LINKCC is CXX instead. Always using CXX is undesirable: # python might then depend on the C++ runtime -# This is altered for AIX in order to build the export list before -# linking. AC_SUBST(LINKCC) AC_MSG_CHECKING(LINKCC) if test -z "$LINKCC" then LINKCC='$(PURIFY) $(MAINCC)' case $ac_sys_system in - AIX*) - exp_extra="\"\"" - if test $ac_sys_release -ge 5 -o \ - $ac_sys_release -eq 4 -a `uname -r` -ge 2 ; then - exp_extra="." - fi - LINKCC="\$(srcdir)/Modules/makexp_aix Modules/python.exp $exp_extra \$(LIBRARY); $LINKCC";; QNX*) # qcc must be used because the other compilers do not # support -N. @@ -1047,6 +1038,24 @@ then fi AC_MSG_RESULT($LINKCC) +# EXPORTSYMS holds the list of exported symbols for AIX. +# EXPORTSFROM holds the module name exporting symbols on AIX. +EXPORTSYMS= +EXPORTSFROM= +AC_SUBST(EXPORTSYMS) +AC_SUBST(EXPORTSFROM) +AC_MSG_CHECKING(EXPORTSYMS) +case $ac_sys_system in +AIX*) + EXPORTSYMS="Modules/python.exp" + if test $ac_sys_release -ge 5 -o \ + $ac_sys_release -eq 4 -a `uname -r` -ge 2 ; then + EXPORTSFROM=. # the main executable + fi + ;; +esac +AC_MSG_RESULT($EXPORTSYMS) + # GNULD is set to "yes" if the GNU linker is used. If this goes wrong # make sure we default having it set to "no": this is used by # distutils.unixccompiler to know if it should add --enable-new-dtags [View Less]

1 0

Fix error in argparse documentation example (GH-17399)
by SarahPythonista Aug. 28, 2020

Aug. 28, 2020

https://github.com/python/cpython/commit/8784d3300ec4ffc58bc0e9ab3cff9a2418… commit: 8784d3300ec4ffc58bc0e9ab3cff9a24187dbe4c branch: master author: SarahPythonista <4283226+SarahPythonista(a)users.noreply.github.com> committer: GitHub <noreply(a)github.com> date: 2020-08-28T11:47:58-07:00 summary: Fix error in argparse documentation example (GH-17399) Automerge-Triggered-By: @rhettinger files: M Doc/library/argparse.rst diff --git a/Doc/library/argparse.rst b/Doc/library/… [View More]

1 0

[3.8] bpo-41624: fix documentation of typing.Coroutine (GH-21952). (#21983)
by Karthikeyan Singaravelan Aug. 28, 2020

Aug. 28, 2020

https://github.com/python/cpython/commit/838316db08a8e3174e4cf8db233ff69d38… commit: 838316db08a8e3174e4cf8db233ff69d388b3f5c branch: 3.8 author: Karthikeyan Singaravelan <tir.karthi(a)gmail.com> committer: GitHub <noreply(a)github.com> date: 2020-08-28T08:03:40-07:00 summary: [3.8] bpo-41624: fix documentation of typing.Coroutine (GH-21952). (#21983) (cherry picked from commit 8c58d2a216ca2b5965361df9b8d8944bc7d4854d) Co-authored-by: MingZhe Hu <humingzhework(a)163.com> … [View More]

1 0

bpo-38787: Clarify docs for PyType_GetModule and warn against common mistake (GH-20215)
by Petr Viktorin Aug. 27, 2020

Aug. 27, 2020

https://github.com/python/cpython/commit/d9a966ae08258da2ce2a432c943d819476… commit: d9a966ae08258da2ce2a432c943d8194760f09c4 branch: master author: Petr Viktorin <encukou(a)gmail.com> committer: GitHub <noreply(a)github.com> date: 2020-08-27T15:36:48+02:00 summary: bpo-38787: Clarify docs for PyType_GetModule and warn against common mistake (GH-20215) files: M Doc/c-api/type.rst diff --git a/Doc/c-api/type.rst b/Doc/c-api/type.rst index f387279d143ee..7309d7ee2cd39 100644 --- a/… [View More]

1 0

bpo-41634: Fix a typo in the curses documentation (GH-21958)
by Zackery Spytz Aug. 27, 2020

Aug. 27, 2020

https://github.com/python/cpython/commit/398575c210f79627830c5c470184f54ace… commit: 398575c210f79627830c5c470184f54ace950ac6 branch: master author: Zackery Spytz <zspytz(a)gmail.com> committer: GitHub <noreply(a)github.com> date: 2020-08-27T16:58:16+05:30 summary: bpo-41634: Fix a typo in the curses documentation (GH-21958) files: M Doc/library/curses.rst diff --git a/Doc/library/curses.rst b/Doc/library/curses.rst index 0b687db1bd2c4..3684d54d4ecad 100644 --- a/Doc/library/… [View More]

1 0

bpo-41524: fix pointer bug in PyOS_mystr{n}icmp (GH-21845)
by wmeehan Aug. 27, 2020

Aug. 27, 2020

https://github.com/python/cpython/commit/97eaf2b5e5c826b9abe59896a363853bef… commit: 97eaf2b5e5c826b9abe59896a363853bef55c5d9 branch: master author: wmeehan <wmeehan(a)users.noreply.github.com> committer: GitHub <noreply(a)github.com> date: 2020-08-27T14:45:25+09:00 summary: bpo-41524: fix pointer bug in PyOS_mystr{n}icmp (GH-21845) * bpo-41524: fix pointer bug in PyOS_mystr{n}icmp The existing implementations of PyOS_mystrnicmp and PyOS_mystricmp can increment pointers beyond … [View More]

1 0

bpo-41609: Fix output of pdb's whatis command for instance methods (GH-21935) (#21976)
by Miss Islington (bot) Aug. 27, 2020

Aug. 27, 2020

https://github.com/python/cpython/commit/641279e6e51b5d2e10d3fbffe6330e47c9… commit: 641279e6e51b5d2e10d3fbffe6330e47c94c4bb2 branch: 3.8 author: Miss Islington (bot) <31488909+miss-islington(a)users.noreply.github.com> committer: GitHub <noreply(a)github.com> date: 2020-08-27T03:17:05+02:00 summary: bpo-41609: Fix output of pdb's whatis command for instance methods (GH-21935) (#21976) (cherry picked from commit 022bc7572f061e1d1132a4db9d085b29707701e7) Co-authored-by: Irit … [View More]Katriel <iritkatriel(a)yahoo.com> files: A Misc/NEWS.d/next/Library/2020-08-21-15-51-15.bpo-41609.JmiUKG.rst M Lib/pdb.py M Lib/test/test_pdb.py diff --git a/Lib/pdb.py b/Lib/pdb.py index 081023526c0ea..d7d957159458b 100755 --- a/Lib/pdb.py +++ b/Lib/pdb.py @@ -1312,21 +1312,21 @@ def do_whatis(self, arg): # _getval() already printed the error return code = None - # Is it a function? + # Is it an instance method? try: - code = value.__code__ + code = value.__func__.__code__ except Exception: pass if code: - self.message('Function %s' % code.co_name) + self.message('Method %s' % code.co_name) return - # Is it an instance method? + # Is it a function? try: - code = value.__func__.__code__ + code = value.__code__ except Exception: pass if code: - self.message('Method %s' % code.co_name) + self.message('Function %s' % code.co_name) return # Is it a class? if value.__class__ is type: diff --git a/Lib/test/test_pdb.py b/Lib/test/test_pdb.py index 0e7ae1d86ed80..9c9471a8cc8df 100644 --- a/Lib/test/test_pdb.py +++ b/Lib/test/test_pdb.py @@ -425,6 +425,47 @@ def test_list_commands(): (Pdb) continue """ +def test_pdb_whatis_command(): + """Test the whatis command + + >>> myvar = (1,2) + >>> def myfunc(): + ... pass + + >>> class MyClass: + ... def mymethod(self): + ... pass + + >>> def test_function(): + ... import pdb; pdb.Pdb(nosigint=True, readrc=False).set_trace() + + >>> with PdbTestInput([ # doctest: +ELLIPSIS, +NORMALIZE_WHITESPACE + ... 'whatis myvar', + ... 'whatis myfunc', + ... 'whatis MyClass', + ... 'whatis MyClass()', + ... 'whatis MyClass.mymethod', + ... 'whatis MyClass().mymethod', + ... 'continue', + ... ]): + ... test_function() + --Return-- + > <doctest test.test_pdb.test_pdb_whatis_command[3]>(2)test_function()->None + -> import pdb; pdb.Pdb(nosigint=True, readrc=False).set_trace() + (Pdb) whatis myvar + <class 'tuple'> + (Pdb) whatis myfunc + Function myfunc + (Pdb) whatis MyClass + Class test.test_pdb.MyClass + (Pdb) whatis MyClass() + <class 'test.test_pdb.MyClass'> + (Pdb) whatis MyClass.mymethod + Function mymethod + (Pdb) whatis MyClass().mymethod + Method mymethod + (Pdb) continue + """ def test_post_mortem(): """Test post mortem traceback debugging. diff --git a/Misc/NEWS.d/next/Library/2020-08-21-15-51-15.bpo-41609.JmiUKG.rst b/Misc/NEWS.d/next/Library/2020-08-21-15-51-15.bpo-41609.JmiUKG.rst new file mode 100644 index 0000000000000..ecaf40eee7bab --- /dev/null +++ b/Misc/NEWS.d/next/Library/2020-08-21-15-51-15.bpo-41609.JmiUKG.rst @@ -0,0 +1 @@ +The pdb whatis command correctly reports instance methods as 'Method' rather than 'Function'. \ No newline at end of file [View Less]

1 0

bpo-41609: Fix output of pdb's whatis command for instance methods (GH-21935)
by Irit Katriel Aug. 27, 2020

Aug. 27, 2020

https://github.com/python/cpython/commit/022bc7572f061e1d1132a4db9d085b2970… commit: 022bc7572f061e1d1132a4db9d085b29707701e7 branch: master author: Irit Katriel <iritkatriel(a)yahoo.com> committer: GitHub <noreply(a)github.com> date: 2020-08-27T02:51:12+02:00 summary: bpo-41609: Fix output of pdb's whatis command for instance methods (GH-21935) files: A Misc/NEWS.d/next/Library/2020-08-21-15-51-15.bpo-41609.JmiUKG.rst M Lib/pdb.py M Lib/test/test_pdb.py diff --git a/Lib/pdb.py b/… [View More]Lib/pdb.py index 081023526c0ea..d7d957159458b 100755 --- a/Lib/pdb.py +++ b/Lib/pdb.py @@ -1312,21 +1312,21 @@ def do_whatis(self, arg): # _getval() already printed the error return code = None - # Is it a function? + # Is it an instance method? try: - code = value.__code__ + code = value.__func__.__code__ except Exception: pass if code: - self.message('Function %s' % code.co_name) + self.message('Method %s' % code.co_name) return - # Is it an instance method? + # Is it a function? try: - code = value.__func__.__code__ + code = value.__code__ except Exception: pass if code: - self.message('Method %s' % code.co_name) + self.message('Function %s' % code.co_name) return # Is it a class? if value.__class__ is type: diff --git a/Lib/test/test_pdb.py b/Lib/test/test_pdb.py index 1a2bbb382e864..e56451360d643 100644 --- a/Lib/test/test_pdb.py +++ b/Lib/test/test_pdb.py @@ -425,6 +425,47 @@ def test_list_commands(): (Pdb) continue """ +def test_pdb_whatis_command(): + """Test the whatis command + + >>> myvar = (1,2) + >>> def myfunc(): + ... pass + + >>> class MyClass: + ... def mymethod(self): + ... pass + + >>> def test_function(): + ... import pdb; pdb.Pdb(nosigint=True, readrc=False).set_trace() + + >>> with PdbTestInput([ # doctest: +ELLIPSIS, +NORMALIZE_WHITESPACE + ... 'whatis myvar', + ... 'whatis myfunc', + ... 'whatis MyClass', + ... 'whatis MyClass()', + ... 'whatis MyClass.mymethod', + ... 'whatis MyClass().mymethod', + ... 'continue', + ... ]): + ... test_function() + --Return-- + > <doctest test.test_pdb.test_pdb_whatis_command[3]>(2)test_function()->None + -> import pdb; pdb.Pdb(nosigint=True, readrc=False).set_trace() + (Pdb) whatis myvar + <class 'tuple'> + (Pdb) whatis myfunc + Function myfunc + (Pdb) whatis MyClass + Class test.test_pdb.MyClass + (Pdb) whatis MyClass() + <class 'test.test_pdb.MyClass'> + (Pdb) whatis MyClass.mymethod + Function mymethod + (Pdb) whatis MyClass().mymethod + Method mymethod + (Pdb) continue + """ def test_post_mortem(): """Test post mortem traceback debugging. diff --git a/Misc/NEWS.d/next/Library/2020-08-21-15-51-15.bpo-41609.JmiUKG.rst b/Misc/NEWS.d/next/Library/2020-08-21-15-51-15.bpo-41609.JmiUKG.rst new file mode 100644 index 0000000000000..ecaf40eee7bab --- /dev/null +++ b/Misc/NEWS.d/next/Library/2020-08-21-15-51-15.bpo-41609.JmiUKG.rst @@ -0,0 +1 @@ +The pdb whatis command correctly reports instance methods as 'Method' rather than 'Function'. \ No newline at end of file [View Less]

1 0

Add missing word (GH-21936)
by Mason Aug. 27, 2020

Aug. 27, 2020

https://github.com/python/cpython/commit/b260635b3db5715adf7a9a3df542c171fb… commit: b260635b3db5715adf7a9a3df542c171fb7296ef branch: master author: Mason <38963371+nosamproductions(a)users.noreply.github.com> committer: GitHub <noreply(a)github.com> date: 2020-08-27T02:49:14+02:00 summary: Add missing word (GH-21936) "data to lost" -> "data to be lost" files: M Doc/library/multiprocessing.rst diff --git a/Doc/library/multiprocessing.rst b/Doc/library/multiprocessing.rst … [View More]

1 0