What is github trying to tell me?
https://github.com/python/cpython/pull/28163 has two messages of:
@ericvsmith <https://github.com/ericvsmith>: Status check is done, and it's a failure ❌ .
Followed by the merge messages, followed by:
@ericvsmith <https://github.com/ericvsmith>: Status check is done, and it's a success ✅ .
What do the failure messages mean? Is it because I didn't wait for the checks to complete before merging?
(It's a documentation only change that I previously committed to main without incident, so I didn't feel the need to wait for all of the checks to run before merging.)
Thanks for any insight.
Eric
I see this all the time and just ignore it. I have a feeling it's due to the miss-islington bot being triggered by some event and checking in on the PR while it is still transitioning. Occasionally I see a very large string of these and assume she's just having a bad day. Also notice that in your PR there are actually two of those failure messages, the second one being suppressed by the GitHub UI.
But maybe Mariatta has a more reasoned explanation.
On Sat, Sep 4, 2021 at 1:47 PM Eric V. Smith <eric@trueblade.com> wrote:
https://github.com/python/cpython/pull/28163 has two messages of:
@ericvsmith <https://github.com/ericvsmith>: Status check is done, and it's a failure ❌ .
Followed by the merge messages, followed by:
@ericvsmith <https://github.com/ericvsmith>: Status check is done, and it's a success ✅ .
What do the failure messages mean? Is it because I didn't wait for the checks to complete before merging?
(It's a documentation only change that I previously committed to main without incident, so I didn't feel the need to wait for all of the checks to run before merging.)
Thanks for any insight.
Eric
python-committers mailing list -- python-committers@python.org To unsubscribe send an email to python-committers-leave@python.org https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/python-committers@python.org/message/U... Code of Conduct: https://www.python.org/psf/codeofconduct/
-- --Guido van Rossum (python.org/~guido) *Pronouns: he/him **(why is my pronoun here?)* <http://feministing.com/2015/02/03/how-using-they-as-a-singular-pronoun-can-c...>
I’ve had some pretty weird interactions with that bot too:
https://github.com/python/cpython/pull/27397
I’ve found in general that these messages are pretty noisy, and not very helpful. For example, backporting a PR to another branch usually results in me receiving around a dozen different emails (in three different threads: the main PR, the backport, and the BPO issue). I usually just ignore all of them.
I think it’s fine to expect the committer to check the status checks themselves before merging (just like with non-backport PRs). Removing those messages would cut down a lot of the noise.
Thanks. I'll continue to ignore them, unless I hear otherwise on this list.
Eric
On 9/4/2021 5:42 PM, Guido van Rossum wrote:
I see this all the time and just ignore it. I have a feeling it's due to the miss-islington bot being triggered by some event and checking in on the PR while it is still transitioning. Occasionally I see a very large string of these and assume she's just having a bad day. Also notice that in your PR there are actually two of those failure messages, the second one being suppressed by the GitHub UI.
But maybe Mariatta has a more reasoned explanation.
On Sat, Sep 4, 2021 at 1:47 PM Eric V. Smith <eric@trueblade.com <mailto:eric@trueblade.com>> wrote:
https://github.com/python/cpython/pull/28163 <https://github.com/python/cpython/pull/28163> has two messages of: @ericvsmith <https://github.com/ericvsmith>: Status check is done, and it's a failure ❌ . Followed by the merge messages, followed by: @ericvsmith <https://github.com/ericvsmith>: Status check is done, and it's a success ✅ . What do the failure messages mean? Is it because I didn't wait for the checks to complete before merging? (It's a documentation only change that I previously committed to main without incident, so I didn't feel the need to wait for all of the checks to run before merging.) Thanks for any insight. Eric _______________________________________________ python-committers mailing list -- python-committers@python.org <mailto:python-committers@python.org> To unsubscribe send an email to python-committers-leave@python.org <mailto:python-committers-leave@python.org> https://mail.python.org/mailman3/lists/python-committers.python.org/ <https://mail.python.org/mailman3/lists/python-committers.python.org/> Message archived at https://mail.python.org/archives/list/python-committers@python.org/message/U7A4R6TUGBD3KNAF3F2JJGNQ6V7B5G4D/ <https://mail.python.org/archives/list/python-committers@python.org/message/U7A4R6TUGBD3KNAF3F2JJGNQ6V7B5G4D/> Code of Conduct: https://www.python.org/psf/codeofconduct/ <https://www.python.org/psf/codeofconduct/>-- --Guido van Rossum (python.org/~guido <http://python.org/~guido>) /Pronouns: he/him //(why is my pronoun here?)/ <http://feministing.com/2015/02/03/how-using-they-as-a-singular-pronoun-can-c...>
Hi Eric,
The bot source code and bug tracker can be found at: https://github.com/python/miss-islington
Victor
I looked into this and it looks like there's a blindspot in the Github API reporting where it includes a bunch of checks that finished but doesn't list checks that haven't started yet at all. In this case the bot reports success because there are no pending checks.
Not sure how we can easily improve this since the event that triggers the bot simply doesn't contain the missing information. I'll dig further, maybe we can just list expected checks somehow in the config to avoid this.
- Ł
On 4 Sep 2021, at 23:42, Guido van Rossum <guido@python.org> wrote:
I see this all the time and just ignore it. I have a feeling it's due to the miss-islington bot being triggered by some event and checking in on the PR while it is still transitioning. Occasionally I see a very large string of these and assume she's just having a bad day. Also notice that in your PR there are actually two of those failure messages, the second one being suppressed by the GitHub UI.
But maybe Mariatta has a more reasoned explanation.
On Sat, Sep 4, 2021 at 1:47 PM Eric V. Smith <eric@trueblade.com <mailto:eric@trueblade.com>> wrote: https://github.com/python/cpython/pull/28163 <https://github.com/python/cpython/pull/28163> has two messages of:
@ericvsmith <https://github.com/ericvsmith>: Status check is done, and it's a failure ❌ .
Followed by the merge messages, followed by:
@ericvsmith <https://github.com/ericvsmith>: Status check is done, and it's a success ✅ .
What do the failure messages mean? Is it because I didn't wait for the checks to complete before merging?
(It's a documentation only change that I previously committed to main without incident, so I didn't feel the need to wait for all of the checks to run before merging.)
Thanks for any insight.
Eric
python-committers mailing list -- python-committers@python.org <mailto:python-committers@python.org> To unsubscribe send an email to python-committers-leave@python.org <mailto:python-committers-leave@python.org> https://mail.python.org/mailman3/lists/python-committers.python.org/ <https://mail.python.org/mailman3/lists/python-committers.python.org/> Message archived at https://mail.python.org/archives/list/python-committers@python.org/message/U... <https://mail.python.org/archives/list/python-committers@python.org/message/U...> Code of Conduct: https://www.python.org/psf/codeofconduct/ <https://www.python.org/psf/codeofconduct/>
-- --Guido van Rossum (python.org/~guido <http://python.org/~guido>) Pronouns: he/him (why is my pronoun here?) <http://feministing.com/2015/02/03/how-using-they-as-a-singular-pronoun-can-change-the-world/>_______________________________________________ python-committers mailing list -- python-committers@python.org To unsubscribe send an email to python-committers-leave@python.org https://mail.python.org/mailman3/lists/python-committers.python.org/ Message archived at https://mail.python.org/archives/list/python-committers@python.org/message/V... Code of Conduct: https://www.python.org/psf/codeofconduct/
On 4 Sep 2021, at 22:15, Eric V. Smith <eric@trueblade.com> wrote:
Is it because I didn't wait for the checks to complete before merging?
(It's a documentation only change that I previously committed to main without incident, so I didn't feel the need to wait for all of the checks to run before merging.)
While this is somewhat off-topic, I'd like to encourage you not to skip required checks on backport branches. We could turn them off if they weren't important, in fact quite a few checks are only running on the main branch. We leave the rest because backports can easily regress due to differences in untouched code. Documentation changes specifically can fail if references between branches change or doctests don't have necessary imports. You can also trip up a bug in Sphinx 2.4.4 (used by Python 3.9 and 3.8) that is already fixed by Sphinx 3.2.1 (used by the main branch and 3.10).
Don't get me wrong, I'm sure you'll use your best judgment. I don't intend to police anyone, just wanted to highlight that even innocently looking doc changes can break us every now and again.
I understand that you might not have much free time to monitor backports. It's fine for you to just leave them, the release managers will sweep them periodically.
Cheers!
- Ł
participants (5)
-
Brandt Bucher -
Eric V. Smith -
Guido van Rossum -
Victor Stinner -
Łukasz Langa