Three trivial PRs from first-timers in need of merging!
Hi everybody! I've found a handful of trivial PRs from new contributors that have gone un-core-reviewed since November. CLAs are signed, tests are passing, and I've verified the quality and correctness of each one. If anybody has a few spare minutes to merge these, I know that it would make the authors very happy! :) Clarify numeric padding behaviour in string formatting: - A helpful doc addition (just a few words). - https://github.com/python/cpython/pull/17036 argparse unittest tracebacks are confusing if an error is raised when not expected: - This just changes a "raise" to a "raise from None" in the argparse unit test machinery. - https://github.com/python/cpython/pull/17120 Reuse identifier of PREDICT macros as PREDICT_ID: - Unifies some shared naming logic in the ceval prediction macros (don't worry, it's simple). - https://github.com/python/cpython/pull/17155/files Thanks. Brandt
Thanks for bring attention to these PRs, Brandt! I think the second one should be particularly uncontroversial, seeing as it's just applying PEP 409 (raise from None) to an existing exception in an argparse unit test to clean up some unhelpful context clutter in the traceback. On Thu, Feb 20, 2020 at 11:41 PM Brandt Bucher <brandtbucher@gmail.com> wrote:
Hi everybody!
I've found a handful of trivial PRs from new contributors that have gone un-core-reviewed since November. CLAs are signed, tests are passing, and I've verified the quality and correctness of each one.
If anybody has a few spare minutes to merge these, I know that it would make the authors very happy! :)
Clarify numeric padding behaviour in string formatting: - A helpful doc addition (just a few words). - https://github.com/python/cpython/pull/17036
argparse unittest tracebacks are confusing if an error is raised when not expected: - This just changes a "raise" to a "raise from None" in the argparse unit test machinery. - https://github.com/python/cpython/pull/17120
Reuse identifier of PREDICT macros as PREDICT_ID: - Unifies some shared naming logic in the ceval prediction macros (don't worry, it's simple). - https://github.com/python/cpython/pull/17155/files
Thanks.
Brandt _______________________________________________ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-leave@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/46U2H5U2... Code of Conduct: http://python.org/psf/codeofconduct/
Thanks for bringing these to our attention Brandt! Mariatta merged the first PR a few hours ago, and I just merged the second PR now. The third PR looks good, but it would be good for someone with a bit more experience with our C code to take a quick glance before we merge it. - Tal Einat On Fri, Feb 21, 2020 at 8:49 AM Kyle Stanley <aeros167@gmail.com> wrote:
Thanks for bring attention to these PRs, Brandt! I think the second one should be particularly uncontroversial, seeing as it's just applying PEP 409 (raise from None) to an existing exception in an argparse unit test to clean up some unhelpful context clutter in the traceback.
On Thu, Feb 20, 2020 at 11:41 PM Brandt Bucher <brandtbucher@gmail.com> wrote:
Hi everybody!
I've found a handful of trivial PRs from new contributors that have gone un-core-reviewed since November. CLAs are signed, tests are passing, and I've verified the quality and correctness of each one.
If anybody has a few spare minutes to merge these, I know that it would make the authors very happy! :)
Clarify numeric padding behaviour in string formatting: - A helpful doc addition (just a few words). - https://github.com/python/cpython/pull/17036
argparse unittest tracebacks are confusing if an error is raised when not expected: - This just changes a "raise" to a "raise from None" in the argparse unit test machinery. - https://github.com/python/cpython/pull/17120
Reuse identifier of PREDICT macros as PREDICT_ID: - Unifies some shared naming logic in the ceval prediction macros (don't worry, it's simple). - https://github.com/python/cpython/pull/17155/files
Thanks.
Brandt _______________________________________________ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-leave@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/46U2H5U2... Code of Conduct: http://python.org/psf/codeofconduct/
_______________________________________________ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-leave@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/PAOV4YWV... Code of Conduct: http://python.org/psf/codeofconduct/
I think all are merged now even the C PR. * I was looking at it but found it merged.* On Fri, Feb 21, 2020 at 5:02 AM Tal Einat <taleinat@gmail.com> wrote:
Thanks for bringing these to our attention Brandt!
Mariatta merged the first PR a few hours ago, and I just merged the second PR now.
The third PR looks good, but it would be good for someone with a bit more experience with our C code to take a quick glance before we merge it.
- Tal Einat
On Fri, Feb 21, 2020 at 8:49 AM Kyle Stanley <aeros167@gmail.com> wrote:
Thanks for bring attention to these PRs, Brandt! I think the second one should be particularly uncontroversial, seeing as it's just applying PEP 409 (raise from None) to an existing exception in an argparse unit test to clean up some unhelpful context clutter in the traceback.
On Thu, Feb 20, 2020 at 11:41 PM Brandt Bucher <brandtbucher@gmail.com> wrote:
Hi everybody!
I've found a handful of trivial PRs from new contributors that have gone un-core-reviewed since November. CLAs are signed, tests are passing, and I've verified the quality and correctness of each one.
If anybody has a few spare minutes to merge these, I know that it would make the authors very happy! :)
Clarify numeric padding behaviour in string formatting: - A helpful doc addition (just a few words). - https://github.com/python/cpython/pull/17036
argparse unittest tracebacks are confusing if an error is raised when not expected: - This just changes a "raise" to a "raise from None" in the argparse unit test machinery. - https://github.com/python/cpython/pull/17120
Reuse identifier of PREDICT macros as PREDICT_ID: - Unifies some shared naming logic in the ceval prediction macros (don't worry, it's simple). - https://github.com/python/cpython/pull/17155/files
Thanks.
Brandt _______________________________________________ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-leave@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/46U2H5U2... Code of Conduct: http://python.org/psf/codeofconduct/
_______________________________________________ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-leave@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/PAOV4YWV... Code of Conduct: http://python.org/psf/codeofconduct/
_______________________________________________ Python-Dev mailing list -- python-dev@python.org To unsubscribe send an email to python-dev-leave@python.org https://mail.python.org/mailman3/lists/python-dev.python.org/ Message archived at https://mail.python.org/archives/list/python-dev@python.org/message/VILCDKNH... Code of Conduct: http://python.org/psf/codeofconduct/
-- Best, Joannah Nanjekye *"You think you know when you learn, are more sure when you can write, even more when you can teach, but certain when you can program." Alan J. Perlis*
participants (4)
-
Brandt Bucher -
joannah nanjekye -
Kyle Stanley -
Tal Einat