Currently working on the release of Python 3.8.0rc1

Team, amazing job on getting us back on track over the weekend. Thank you All release blockers and deferred release blockers solved. And there was relatively little additional activity on the branch -- as expected at this point! Thank you for this, it will help get the release candidate out on time. I'm working on cutting RC1 today Hopefully all sanity checks, as well as building the source tarball and the binary installers for macOS and Windows will all work out fine and we'll be seeing RC1 out tonight. RC2 and the date of 3.8.0 gold If we manage to avoid the need for RC2, we will be able to release 3.8.0 on October 14th. If we need an RC2, that will slip by a week. I hope we won't. Ideally RC1 should be identical codewise to 3.8.0. To help our chances, please avoid any source-related activity on the 3.8 branch from now until the release of 3.8.0. Yes, that also counts for bug fixes unless they are critical. (Yeah, it might be a bit annoying but nobody wants to be the person who introduced a last minute regression in a major release.) Note I didn't say I forbid any activity. I have no power over you, actually. More importantly though, I trust your judgement if you assess some bug is bad enough the fix absolutely has to get into 3.8.0. Moreover, I specifically said source-related activity because... 3.8.0 is important. To some users it will be the first and the last release in the 3.8 series they will see. We need you to focus on the docs now Are all your changes properly documented? Did you notice other changes you know of to have insufficient documentation? Can you help with the "What's New" document? anxiously configure-&&-makingly y'rs - Ł

On Mon, 30 Sep 2019 at 17:48, Łukasz Langa <lukasz@langa.pl> wrote:
I've filed https://bugs.python.org/issue38326 as a release blocker, as I don't think we should be cutting RCs when changes have been made to a PEP-approved API without any pre-merge design discussion. Cheers, Nick. -- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia

Hi Łukasz, Le lun. 30 sept. 2019 à 16:32, Łukasz Langa <lukasz@langa.pl> a écrit :
Last Friday, I sent an python-dev to get feedback since I dislike modifying a PEP which is already approved and I wasn't sure of the design of my change (stable ABI for PyConfig). There was an interesting discussion and it seems like we all agreed to abandon the whole idea of a stable ABI, so I removed PyConfig.struct_size. The change is already merged into 3.8 and the PEP has been updated again. Nick approved and merged my PRs which means that we agreed the on solution ;-) Victor -- Night gathers, and now my watch begins. It shall not end until my death.

Hello Łukasz, I consider this one critical enough to get into 3.8: https://bugs.python.org/issue38319 Long story short: shutil.copyfile() and socket.sendfile() are broken on 32-bit platforms for files >= 2GiB. shutil.copyfile() was modified by me in the 3.8 cycle so the bug only affects 3.8 and 3.9. On Mon, Sep 30, 2019 at 3:48 PM Łukasz Langa <lukasz@langa.pl> wrote:
-- Giampaolo - http://grodola.blogspot.com

Can you help with the "What's New" document?
After seeing this, I went through the whatsnew for 3.8 and found a couple of typos and broken links (from Sphinx roles that were slightly off). I opened a PR to fix as many as I was able to: https://github.com/python/cpython/pull/16535. Raymond will be the one to make the final decision as the editor, but I would appreciate it if anyone could help with verifying the changes and providing feedback. I'd like to have the PR finished a good bit before October 14th to avoid last minute additions. Having additional reviewers would likely help to accelerate the process. On Mon, Sep 30, 2019 at 3:53 AM Łukasz Langa <lukasz@langa.pl> wrote:

On Mon, 30 Sep 2019 at 17:48, Łukasz Langa <lukasz@langa.pl> wrote:
I've filed https://bugs.python.org/issue38326 as a release blocker, as I don't think we should be cutting RCs when changes have been made to a PEP-approved API without any pre-merge design discussion. Cheers, Nick. -- Nick Coghlan | ncoghlan@gmail.com | Brisbane, Australia

Hi Łukasz, Le lun. 30 sept. 2019 à 16:32, Łukasz Langa <lukasz@langa.pl> a écrit :
Last Friday, I sent an python-dev to get feedback since I dislike modifying a PEP which is already approved and I wasn't sure of the design of my change (stable ABI for PyConfig). There was an interesting discussion and it seems like we all agreed to abandon the whole idea of a stable ABI, so I removed PyConfig.struct_size. The change is already merged into 3.8 and the PEP has been updated again. Nick approved and merged my PRs which means that we agreed the on solution ;-) Victor -- Night gathers, and now my watch begins. It shall not end until my death.

Hello Łukasz, I consider this one critical enough to get into 3.8: https://bugs.python.org/issue38319 Long story short: shutil.copyfile() and socket.sendfile() are broken on 32-bit platforms for files >= 2GiB. shutil.copyfile() was modified by me in the 3.8 cycle so the bug only affects 3.8 and 3.9. On Mon, Sep 30, 2019 at 3:48 PM Łukasz Langa <lukasz@langa.pl> wrote:
-- Giampaolo - http://grodola.blogspot.com

Can you help with the "What's New" document?
After seeing this, I went through the whatsnew for 3.8 and found a couple of typos and broken links (from Sphinx roles that were slightly off). I opened a PR to fix as many as I was able to: https://github.com/python/cpython/pull/16535. Raymond will be the one to make the final decision as the editor, but I would appreciate it if anyone could help with verifying the changes and providing feedback. I'd like to have the PR finished a good bit before October 14th to avoid last minute additions. Having additional reviewers would likely help to accelerate the process. On Mon, Sep 30, 2019 at 3:53 AM Łukasz Langa <lukasz@langa.pl> wrote:
participants (5)
-
Giampaolo Rodola'
-
Kyle Stanley
-
Nick Coghlan
-
Victor Stinner
-
Łukasz Langa