Re: [scikit-image] Request to try a GitHub integration for automatic code style review | "PEP8Speaks"
I second Egor’s motion. Regards, Steve
On Mar 21, 2017, at 2:46 AM, Egor Panfilov <egor.v.panfilov@gmail.com> wrote:
Hi Himanshu,
The bot looks really nice! What would be the pre-requisites from our side to deploy it?
@scikit-image/core,
I'd vote to give it a try. What do you think about 3-4 months probation period for the bot? During the period we could evaluate how well it supplements our current practices, and how the contributors are responding.
Regards, Egor
2017-03-21 2:08 GMT+03:00 Stefan van der Walt <stefanv@berkeley.edu <mailto:stefanv@berkeley.edu>>: This also came across my radar today:
https://landscape.io/ <https://landscape.io/>
Stéfan
On Mon, Mar 20, 2017, at 14:33, Stefan van der Walt wrote:
Hi Himanshu
On Mon, Mar 20, 2017, at 12:24, Himanshu Mishra wrote:
I am not sure if this is the right place to talk about it, but a lot of times I have witnessed reviewers leave a little comment after reviewing the whole PR, and it is more or less about "some style issues. :)". It should be better for the reviewer to focus more on the implementation of the PR and leave the style issues to a bot. Thinking this in mind, a while ago, I created a Github Integration called PEP8 Speaks which automatically reviews the code style and comments on the Pull Request. It is written in Python and is open source. Github - https://github.com/orkohunter/pep8speaks <https://github.com/orkohunter/pep8speaks>
I've been wanting to put something like this in place for a while; so, if you're willing to help out, we'd be grateful.
We've also looked at Code Climate before; do you know how your proposed solution compares?
Thanks! Stéfan
_______________________________________________ scikit-image mailing list scikit-image@python.org <mailto:scikit-image@python.org> https://mail.python.org/mailman/listinfo/scikit-image <https://mail.python.org/mailman/listinfo/scikit-image>
_______________________________________________ scikit-image mailing list scikit-image@python.org https://mail.python.org/mailman/listinfo/scikit-image
Hello, Just putting my two cents here. I believe we have something like this done. Take a look at Coala <https://coala.io/>and Gitmate <http://gitmate.io/>. The Gitmate is a bot which can check your PRs for all the stuff( PEP8, Lint Errors and such ) and tell the contributor about the exact problems in the code. The Gitmate requires coala to run, maybe we can discuss with Coala devs regarding the integration of the bot, since the bot can do more than just PEP8 checks. Regards, Sourav
participants (2)
-
Sourav Singh
-
Steven Silvester