14 Dec
2012
14 Dec
'12
6:45 p.m.
On 12/14/2012 07:31 PM, Eric P. Mangold wrote:
Oh, and uh technically, since I have not changed the original author's patch (hence, I am not the original author of the code) I can perform the review on this patch myself? I believe I have done this before, and unless there is some objection, I guess I can go ahead and do that...
I've definitely gotten a patch or two in where the verification was done manually by a reviewer due to obscureness of the platform and lack of current buildslave (*cough*python-gi*cough*). So I'd say yes. But having a build machine is *much* better.