[Twisted-Python] Review tag for closed tickets
Jean Paul commented that for merged tickets I should remove the review tag. I am lost between wiki pages and sphinx documentation. Where is the place where these these steps are described and maybe I am also not aware of other steps required after a branch is merged? ---- Since the ticket is automatically closed, maybe the bot can also remove the review ticket. Thanks! -- Adi Roiban
On Jan 26, 2015, at 11:12 AM, Adi Roiban <adi@roiban.ro> wrote:
Jean Paul commented that for merged tickets I should remove the review tag.
I am lost between wiki pages and sphinx documentation.
<https://twistedmatrix.com/trac/wiki/ReviewProcess#Reviewers:Howtoreviewachan... <https://twistedmatrix.com/trac/wiki/ReviewProcess#Reviewers:Howtoreviewachange>> pretty much describes the whole process. Notice that the "remove the review keyword" step comes before the "merge the change to trunk" step.
Where is the place where these these steps are described and maybe I am also not aware of other steps required after a branch is merged?
The reason you are not finding this in a list of steps after the branch is merged is because it should be done in advance of merging the branch, you skipped an earlier part of the process :).
Since the ticket is automatically closed, maybe the bot can also remove the review ticket.
The review should be completed before the ticket is merged, so the bot should not be doing this automatically. -glyph
On 26 January 2015 at 20:11, Glyph Lefkowitz <glyph@twistedmatrix.com> wrote:
On Jan 26, 2015, at 11:12 AM, Adi Roiban <adi@roiban.ro> wrote:
Jean Paul commented that for merged tickets I should remove the review tag.
I am lost between wiki pages and sphinx documentation.
<https://twistedmatrix.com/trac/wiki/ReviewProcess#Reviewers:Howtoreviewachan...> pretty much describes the whole process.
Notice that the "remove the review keyword" step comes before the "merge the change to trunk" step.
Where is the place where these these steps are described and maybe I am also not aware of other steps required after a branch is merged?
The reason you are not finding this in a list of steps after the branch is merged is because it should be done in advance of merging the branch, you skipped an earlier part of the process :).
True. Thanks! My bad... but then it also state "Make sure that it's green! " ... but in a previous email I just found out that is ok for twistededchecker and pyflakes to be red.
Since the ticket is automatically closed, maybe the bot can also remove the review ticket.
The review should be completed before the ticket is merged, so the bot should not be doing this automatically.
but in the commit message I do add the author, why not have the bot automatically assign the first author form the list, review merge and close the ticket? What is the purpose of these manual task and why you don't want to automate them? PS: Trac "reasing to" field is a PITA :) -- Adi Roiban
On 26 Jan, 08:51 pm, adi@roiban.ro wrote:
The review should be completed before the ticket is merged, so the bot should not be doing this automatically.
but in the commit message I do add the author, why not have the bot automatically assign the first author form the list, review merge and close the ticket?
What is the purpose of these manual task and why you don't want to automate them?
You jumped pretty quickly from "it is not automated" to "you don't want to automate them". Building reliable automation is work. If that's work you want to do, feel free. One challenge you'll have to contend with is that the metadata automatically collected by trac is often incorrect. For example, the author field is populated based on the person who creates the svn branch. Non-committers can never create svn branches so the tickets worked on by non-committers often have an incorrect author field. I'm sure this can be overcome. It's just one example of an extra difficulty you might not have immediately recognized when thinking about how reliable automation to take over this menial task could work. Jean-Paul
On 27 January 2015 at 00:44, <exarkun@twistedmatrix.com> wrote:
On 26 Jan, 08:51 pm, adi@roiban.ro wrote:
The review should be completed before the ticket is merged, so the bot should not be doing this automatically.
but in the commit message I do add the author, why not have the bot automatically assign the first author form the list, review merge and close the ticket?
What is the purpose of these manual task and why you don't want to automate them?
You jumped pretty quickly from "it is not automated" to "you don't want to automate them".
Sorry for that. I have interpreted "the bot should not be doing this automatically" as a statement that any work in this direction will be rejected
Building reliable automation is work. If that's work you want to do, feel free.
Will do. https://github.com/twisted-infra/trac-config/issues/19 Thanks for the comments! -- Adi Roiban
On Jan 26, 2015, at 12:51 PM, Adi Roiban <adi@roiban.ro> wrote:
My bad... but then it also state "Make sure that it's green! " ... but in a previous email I just found out that is ok for twistededchecker and pyflakes to be red.
This was definitely an oversight, so I've updated the wiki page to include information about what to do when a tool has a bug: <https://twistedmatrix.com/trac/wiki/ReviewProcess#Reviewers:Howtoreviewachan... <https://twistedmatrix.com/trac/wiki/ReviewProcess#Reviewers:Howtoreviewachange>> -glyph
participants (3)
-
Adi Roiban -
exarkun＠twistedmatrix.com -
Glyph Lefkowitz