Unit systems PR--needs some review

Hi devs, The unit system PR is still open for review: https://bitbucket.org/yt_analysis/yt/pull-requests/1904/switching-between-di... <https://bitbucket.org/yt_analysis/yt/pull-requests/1904/switching-between-di...> This is a big PR that touches in some way nearly every frontend and many other parts of the code, so I’d like to get about 5 approvals on it before we merge it in, especially from people that work on specific frontends. It has docs and tests, and there is a YTEP explaining the rationale behind it and what it does: https://bitbucket.org/yt_analysis/ytep/pull-requests/58/adding-ytep-0028-for... <https://bitbucket.org/yt_analysis/ytep/pull-requests/58/adding-ytep-0028-for...> This should go in before 3.3 is out. Best, John

Hi John, Thanks for poking about this. Do you think that the non-spatial stuff is also a candidate for 3.3? -Matt On Fri, Jan 29, 2016 at 12:03 PM, John ZuHone <jzuhone@gmail.com> wrote:
Hi devs,
The unit system PR is still open for review:
https://bitbucket.org/yt_analysis/yt/pull-requests/1904/switching-between-di...
This is a big PR that touches in some way nearly every frontend and many other parts of the code, so I’d like to get about 5 approvals on it before we merge it in, especially from people that work on specific frontends.
It has docs and tests, and there is a YTEP explaining the rationale behind it and what it does:
https://bitbucket.org/yt_analysis/ytep/pull-requests/58/adding-ytep-0028-for...
This should go in before 3.3 is out.
Best,
John
_______________________________________________ yt-dev mailing list yt-dev@lists.spacepope.org http://lists.spacepope.org/listinfo.cgi/yt-dev-spacepope.org
participants (2)
-
John ZuHone
-
Matthew Turk