[core-workflow] self-approving pull requests

[Donald Stufft]

> On Feb 22, 2017, at 11:25 AM, Barry Warsaw <barry at python.org> wrote:
> 
> Since we're squashing commits wouldn't that obliterate the original author's
> credit for the work?


Yes, github will credit the person who opened the PR, but the person who made the person who made the PR can check the box (which I *believe* is checked by default) to allow maintainers to edit their PR. If that is checked, then maintainers can edit their branch on their fork directly, in which case no credit gets lost.

So just make your changes directly in their branch, and things will continue to work.

—
Donald Stufft



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.python.org/pipermail/core-workflow/attachments/20170222/d1e7c16e/attachment.html>