[core-workflow] self-approving pull requests
Ethan Furman
ethan at stoneleaf.us
Wed Feb 22 14:16:04 EST 2017
On 02/22/2017 08:39 AM, Donald Stufft wrote:
>> On Feb 22, 2017, at 11:25 AM, Barry Warsaw wrote:
>> Since we're squashing commits wouldn't that obliterate the original author's
>> credit for the work?
>
> Yes, github will credit the person who opened the PR, but the person who made
> the person who made the PR can check the box (which I *believe* is checked by
> default) to allow maintainers to edit their PR. If that is checked, then
> maintainers can edit their branch on their fork directly, in which case no
> credit gets lost.
>
> So just make your changes directly in their branch, and things will continue
> to work.
Is there a list of instructions somewhere on how to do all that?
--
~Ethan~
More information about the core-workflow
mailing list