[core-workflow] self-approving pull requests

[Donald Stufft]

You can clone their repository and make changes directly to their branch and push to it I believe, assuming they allowed that when they made the PR. You should also be able to add their fork as a remote on your current branch using 'git remote add foobar githuburl' then checkout the got branch from them. 

Sent from my iPhone

> On Feb 22, 2017, at 2:16 PM, Ethan Furman <ethan at stoneleaf.us> wrote:
> 
> On 02/22/2017 08:39 AM, Donald Stufft wrote:
>>> On Feb 22, 2017, at 11:25 AM, Barry Warsaw wrote:
> 
>>> Since we're squashing commits wouldn't that obliterate the original author's
>>> credit for the work?
>> 
>> Yes, github will credit the person who opened the PR, but the person who made
>> the person who made the PR can check the box (which I *believe* is checked by
>> default) to allow maintainers to edit their PR. If that is checked, then
>> maintainers can edit their branch on their fork directly, in which case no
>> credit gets lost.
>> 
>> So just make your changes directly in their branch, and things will continue
>> to work.
> 
> Is there a list of instructions somewhere on how to do all that?
> 
> --
> ~Ethan~
> _______________________________________________
> core-workflow mailing list
> core-workflow at python.org
> https://mail.python.org/mailman/listinfo/core-workflow
> This list is governed by the PSF Code of Conduct: https://www.python.org/psf/codeofconduct