[IPython-dev] Min: Cmd-P/Ctrl-P for new print code question..

[Brian Granger]

On Tue, Oct 26, 2010 at 1:06 PM, Fernando Perez <fperez.net at gmail.com> wrote:
> Hey Min,
>
> in console/console_widget.py:
>
> e11b615e (MinRK          2010-10-18 16:34:07 -0700  170)         #
> Configure actions.
> e11b615e (MinRK          2010-10-18 16:34:07 -0700  171)
> action = QtGui.QAction('Print', None)
> e11b615e (MinRK          2010-10-18 16:34:07 -0700  172)
> action.setEnabled(True)
> e11b615e (MinRK          2010-10-18 16:34:07 -0700  173)
> action.setShortcut(QtGui.QKeySequence.Print)
> e11b615e (MinRK          2010-10-18 16:34:07 -0700  174)
> action.triggered.connect(self.print_)
> e11b615e (MinRK          2010-10-18 16:34:07 -0700  175)
> self.addAction(action)
> e11b615e (MinRK          2010-10-18 16:34:07 -0700  176)
> self._print_action = action
>
> you added in line 173 the default print keybinding to the Print
> action.  One problem that introduces is that it overwrites the
> keybinding we had for Ctrl-P, which was equivalent to 'smart up arrow'
> (history-aware).  Since that keybinding has been there for a long
> time, is consistent with the terminal and we want to preserve as much
> similarity as reasonable with habits from the terminal, we need to
> change this.  I think a reasonable compromise is to make:
>
> Ctrl-P -> 'smart up arrow'
> Ctrl-Shift-P -> Print
>
> But I don't want to make any changes, as I don't know if on the Mac,
> there is no problem.  I don't know if on the mac, Control-p and Cmd-p
> are different, so that Ctrl-p remains as before and only Cmd-p goes to
> print.

Yes, on the Mac I think this is the right approach.

> If that's the case, then we should probably leave it as you did for
> the Mac, and only change the keybinding for Linux/windows (which don't
> have a separate Cmd key).
>
> Thoughts?
>
> Cheers,
>
> f
> _______________________________________________
> IPython-dev mailing list
> IPython-dev at scipy.org
> http://mail.scipy.org/mailman/listinfo/ipython-dev
>



-- 
Brian E. Granger, Ph.D.
Assistant Professor of Physics
Cal Poly State University, San Luis Obispo
bgranger at calpoly.edu
ellisonbg at gmail.com