dinov at microsoft.com
Fri Feb 24 07:20:11 CET 2012
Forget that moving AssemblyResolve to PythonOps comment... chicken, egg, etc... :)
From: ironpython-users-bounces+dinov=microsoft.com at python.org [mailto:ironpython-users-bounces+dinov=microsoft.com at python.org] On Behalf Of Dino Viehland
Sent: Thursday, February 23, 2012 10:16 PM
To: Slide; ironpython-users at python.org
Subject: Re: [Ironpython-users] Patch
This is awesome, a couple comments:
Can AssemblyResolve be moved into PythonOps? It looks like it keys off of Assembly.GetEntryAssembly() and so doesn't rely on anything in the generated assembly. That'd make it easier to read and update the code. Maybe I missed something that depends upon the assembly, but if that's the case the assembly could be passed into a class which has the AssemblyResolve method.
I think the GlobalAssemblyCache check is too strong. Ipy install via the MSI will go into the GAC and so I think it won't be embedded. This should probably exclude the known Ipy/Dlr assemblies from the GAC check.
+1 on what Jeff said as well, I'd just add an overload instead of doing the default value thing.
Now I'm going to have to think more about pyc support for PTVS.
From: ironpython-users-bounces+dinov=microsoft.com at python.org<mailto:ironpython-users-bounces+dinov=microsoft.com at python.org> [mailto:ironpython-users-bounces+dinov=microsoft.com at python.org]<mailto:[mailto:ironpython-users-bounces+dinov=microsoft.com at python.org]> On Behalf Of Slide
Sent: Thursday, February 23, 2012 7:55 PM
To: ironpython-users at python.org<mailto:ironpython-users at python.org>
Subject: [Ironpython-users] Patch
Just wanted to get this out for review before I push it. I would have done it through my fork on github and issued a pull request, but my fork is currently messed up. Let me know if you see anything out of the ordinary.
Fixes 32288 and 26706
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Ironpython-users