[Mailman-Developers] Missing footers with latest CVS

Mikhail Zabaluev mhz@alt-linux.org
Wed, 13 Mar 2002 01:23:59 +0300


Hello Barry,

On Tue, Mar 12, 2002 at 03:29:51PM -0500, Barry A. Warsaw wrote:
>
> Index: Decorate.py
> ===================================================================
> RCS file: /cvsroot/mailman/mailman/Mailman/Handlers/Decorate.py,v
> retrieving revision 2.13
> diff -u -r2.13 Decorate.py
> --- Decorate.py	12 Mar 2002 00:49:40 -0000	2.13
> +++ Decorate.py	12 Mar 2002 20:29:12 -0000
> @@ -72,6 +72,7 @@
>      # BAW: If the charsets don't match, should we add the header and footer by
>      # MIME multipart chroming the message?
>      if not msg.is_multipart() and msgtype == 'text/plain' and \
> +           not msg.get('content-transfer-encoding').lower() == 'base64' and \
>             (lcset == 'us-ascii' or mcset == lcset):
>          payload = header + msg.get_payload() + footer
>          msg.set_payload(payload)

That (lcset == 'us-ascii') alternative assumes that the body
charset is always ASCII-friendly. Close, but not exactly true.
Additionally, I would handle quoted-printable by encoding the header
and the footer into it.

-- 
Stay tuned,
  MhZ                                     JID: mookid@jabber.org
___________
To be great is to be misunderstood.
		-- Ralph Waldo Emerson