[Mailman-Users] bin/upgrade has been broken since 2.1.5 (orpossibly longer)

[Mark Sapiro]

Knut Auvor Grythe wrote:

>The _UpdateRecords function in ListAdmin.py is completely broken, and
>has been since 2.1.5. There is a bugreport filed in 2004 at
>https://bugs.launchpad.net/mailman/+bug/266106, and a patch for the
>issue was included in march 2005. It seems the issue has gone unnoticed,
>though. Possibly because the title of the bug report is "Tend to Pending
>Moderator Requests breaks on a few lists", which doesn't seem all that
>bad.
>
>The _UpdateRecords function in ListAdmin.py reads the two-element tuple
>(op, info). It then checks if info has all necessary fields. If it has,
>nothing is done. If info _doesn't_ have all necessary fields (e.g. comes
>from an old version of mailman), the missing fields are added and info
>saved back. Notice how "info" is different from "(op, info)".
>
>This causes all subsequent access to subscription and held message
>records to fail with a ValueError, since an info typle is not 2 elements
>long.
>
>I think it would be very nice to have this fixed in 2.1.11. But even if
>that doesn't happen I thought I should notify people about the problem,
>so they know what to do if their upgrade causes trouble.


Thanks for the report.

It's too late for 2.1.11 which was released on June 7, 2008, however, I
will apply the part of the patch that fixes the actual error to the
2.1 and 2.2 branches so it will be in 2.2 and if there is another 2.1
release post 2.1.11, it will be there too.

I don't see the need to apply the part of the patch that recovers from
the incorect migration. Anyone who migrates with outstanding
subscription approval or held message requests from pre 2.1a4 to
Mailman through 2.1.11 will encounter the problem and will presumably
deal with it somehow before migrating to a still later version. For
anyone who migrates from pre 2.1a4 to a post 2.1.11 Mailman, the
correction will suffice and recovery won't be needed.

-- 
Mark Sapiro <mark at msapiro.net>        The highway is for gamblers,
San Francisco Bay Area, California    better use your sense - B. Dylan