[Mailman-Users] Attachments are unexpectedly re-created.

[Masaharu Kawada]

Hi Mark-san, Kikuchi-san,

Thank you very much for your help.

Just to make sure, about the patch, is it just need to be modified in the
way you mentioned? Which means that it should be look like below.

# vi  /usr/lib/python2.4/email/Charset.py

---<Before modifying>---
    243     def convert(self, s):
    244         """Convert a string from the input_codec to the 
output_codec."""
    245         if self.input_codec <> self.output_codec:
    246             return unicode(s, 
self.input_codec).encode(self.output_codec)
    247         else:
    248             return s

---<After modifying>---
    243     def convert(self, s):
    244         """Convert a string from the input_codec to the 
output_codec."""
    245         if self.input_codec != self.output_codec:
    246             return unicode(s, self.input_codec, 
'replace').encode(self.output_codec, 'replace')
    247             return unicode(s, 
self.input_codec).encode(self.output_codec)
    248         else:
    249             return s

Best Regards,

Tokio Kikuchi wrote:
> Hi,
>
> (10/03/04 1:58), Mark Sapiro wrote:
>   
>> Masaharu Kawada wrote:
>>     
>>> There is one thing that I wonder, is that if the charset.py is done with
>>> that patch, what the current digest.mbox exsisted under lists/<listname>
>>> are supposed to be? Do they need to be deleted or not? My point on
>>> this is that once the patch is done, is there nothing else to do to fix this
>>> problem?
>>>       
>> That is correct. Assuming the underlying issue is fixed by the patch,
>> all you need to do is apply the patch to the Python email library
>> charset.py module (probably at
>> /usr/lib/pythonx.x/lib/email/charset.py) and restart Mailman. Then the
>> next time the digest is triggered, it will be sent with all messages
>> and no more errors.
>>
>> If you apply the patch and restart Mailman and the errors continue,
>> then they are caused by something else.
>>     
>
> In addition, you should have a lot of shunted messages in qfiles/shunt.
>  They are safely deleted.
>
>   
>> Note that the patch:
>>
>> --- Lib/email/charset.py	2009-09-22 08:59:56.000000000 +0900
>> +++ Lib/email/charset.py.orig	2009-09-22 08:58:36.000000000 +0900
>> @@ -264,8 +264,7 @@
>>      def convert(self, s):
>>          """Convert a string from the input_codec to the
>> output_codec."""
>>          if self.input_codec != self.output_codec:
>> -            return unicode(s, self.input_codec, 'replace'
>> -                     ).encode(self.output_codec, 'replace')
>> +            return unicode(s,
>> self.input_codec).encode(self.output_codec)
>>          else:
>>              return s
>>
>> is reversed. The '+' is the original code and the '-' is the new code.
>>
>>     
>
> Yes.  Thanks Mark.
>
>
>   


-- 
-------------------
Masaharu Kawada
Associate Technical Support Engineer
Red Hat K K
Ebisu Neonato 5F
1-18 Ebisu 4-chome, Shibuya-ku
Tokyo 150-0013, Japan
Direct: +81-3-5798-8482