[Mailman-Users] Message.UserNotification vs Message.OwnerNotification in Handlers/Hold.py

[Jim Popovitch]

On Mon, Oct 10, 2016 at 5:32 PM, Jim Popovitch <jimpop at gmail.com> wrote:
> On Mon, Oct 10, 2016 at 4:30 PM, Jim Popovitch <jimpop at gmail.com> wrote:
>> SO... I've digging further into Mailman code looking to further
>> improve problems with DMARC.   I've noticed that Mailman "hold"
>> notifications (to:list-owner@) fail DMARC (if the mailing list domain
>> has a _dmarc RR) because of a simple code issue..... (not calling it a
>> bug at this point)
>>
>> In Handlers/Hold.py, "held for moderation" notices to posters
>> correctly uses Message.UserNotification() to craft and send the poster
>> a notification.   However, notification to list-owners (it really
>> should be list moderators...) also uses Message.UserNotification()
>> rather than Message.OwnerNotification(tomoderators=1).
>>
>> Any thoughts on why?
>
> Further data.  The same "problem" exists with Bouncer.py using
> UserNotification() instead of OwnerNotification()
>
> To be clear, using UserNotification() , for some strange reason, sends
> "owner-" notices in such a fashion that "Sender:" is set to sitelist
> rather than mlist.host_name.

And to wrap it all up, here's what I propose to fix what I see as
coding problems that result in DMARC failures for list notifications.
 Like it or not, DMARC is the way forward (and the current way in many
places) to get your list's notifications into the inboxes of your
owners and admins.  I'm not talking about mailinglist traffic, I'm
talking about admin/owner notices.

http://bazaar.launchpad.net/~jimpop/mailman/virtual-notices/revision/1378?&compare_revid=1374

-Jim P.